All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: Raphael Pavlidis <raphael.pavlidis@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/shadow: disable on uclibc
Date: Mon, 04 Mar 2024 12:46:54 +0100	[thread overview]
Message-ID: <87plwa2p8x.fsf@48ers.dk> (raw)
In-Reply-To: <20240303181859.1103815-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Sun, 3 Mar 2024 19:18:59 +0100")

>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:

 > shadow unconditionally uses reallocarray, reallocf and explicit_bzero
 > since bump to version 4.14.3 in commit
 > 8a01774d9897310c00a0945865f5a6d5167dfca3 and
 > https://github.com/shadow-maint/shadow/commit/1aa22c14674e14e84efa171614dea2b515d5a223
 > https://github.com/shadow-maint/shadow/commit/0e0a310acf5111251589116343897a63ebc88e7a
 > https://github.com/shadow-maint/shadow/commit/0ec157d579931cfec1cc8439288ed17adf19da5d
 > resulting in the following uclibc build failure:

 > /home/autobuild/autobuild/instance-9/output-1/host/lib/gcc/arc-buildroot-linux-uclibc/13.1.1/../../../../arc-buildroot-linux-uclibc/bin/ld:
 > groups.o: in function `main':
 > groups.c:(.text.startup+0x20): undefined reference to `reallocarray'

 > Fixes:
 >  - http://autobuild.buildroot.org/results/98be07d299aa383a447a1f1dd2924a00c1a29a34

 > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

I got a bit confused about reallocf as musl doesn't provide that, but it
turns out that it is no longer used since:

https://github.com/shadow-maint/shadow/commit/6e58c1275252f3314d1aa5cc4d7e7f9068e3a902

So I dropped the reallocf reference and added a comment about
reallocarray/explicit_bzero as suggested by Raphael and committed,
thanks.


> ---
 >  package/shadow/Config.in | 6 ++++--
 >  1 file changed, 4 insertions(+), 2 deletions(-)

 > diff --git a/package/shadow/Config.in b/package/shadow/Config.in
 > index 230271af7d..bc85d0d135 100644
 > --- a/package/shadow/Config.in
 > +++ b/package/shadow/Config.in
 > @@ -2,6 +2,7 @@ menuconfig BR2_PACKAGE_SHADOW
 >  	bool "shadow"
 >  	depends on !BR2_STATIC_LIBS
 >  	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14
 > +	depends on !BR2_TOOLCHAIN_USES_UCLIBC
 >  	help
 >  	  Utilities to deal with user accounts.
 
 > @@ -55,5 +56,6 @@ config BR2_PACKAGE_SHADOW_YESCRYPT
 
 >  endif # BR2_PACKAGE_SHADOW
 
 > -comment "shadow needs a toolchain w/ headers >= 4.14, dynamic library"
 > -	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14 || BR2_STATIC_LIBS
 > +comment "shadow needs a glibc or musl toolchain w/ headers >= 4.14, dynamic library"
 > +	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_14 || \
 > +		BR2_STATIC_LIBS || BR2_TOOLCHAIN_USES_UCLIBC
 > -- 

 > 2.43.0

 > _______________________________________________
 > buildroot mailing list
 > buildroot@buildroot.org
 > https://lists.buildroot.org/mailman/listinfo/buildroot


-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2024-03-04 11:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-03 18:18 [Buildroot] [PATCH 1/1] package/shadow: disable on uclibc Fabrice Fontaine
2024-03-03 19:15 ` Raphael Pavlidis
2024-03-04 11:46 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plwa2p8x.fsf@48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=raphael.pavlidis@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.