From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [git commit] package/wlroots: add hwdata and hwdata_pnp_ids as a dependency
Date: Mon, 08 Jan 2024 11:56:02 +0100 [thread overview]
Message-ID: <87plycxfel.fsf@48ers.dk> (raw)
In-Reply-To: <20231223145109.DC63E87D3E@busybox.osuosl.org> (Thomas Petazzoni via buildroot's message of "Sat, 23 Dec 2023 15:46:58 +0100")
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> commit: https://git.buildroot.net/buildroot/commit/?id=50eed2060ae6a35be257a8773b8e217a623eb29e
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> Since upstream commit
> eec95e3d5e1a4f2e13b1f6b34cc287475ca57daf ("backend/drm: use pnp.ids to
> fetch EDID data"), the pnp.ids file from hwdata is parsed at build
> time to generate a C source file. As per backend/drm/meson.build:
> hwdata = dependency('hwdata', required: false, native: true)
> if hwdata.found()
> hwdata_dir = hwdata.get_variable(pkgconfig: 'pkgdatadir')
> pnp_ids = files(hwdata_dir / 'pnp.ids')
> else
> pnp_ids = files('/usr/share/hwdata/pnp.ids')
> endif
> This is only needed when the DRM backend of wlroots is enabled, but
> currently, Buildroot enables this backend unconditionally.
> This failure can be reproduced using the following defconfig:
> BR2_x86_64=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
> BR2_PACKAGE_MESA3D=y
> BR2_PACKAGE_MESA3D_OSMESA_GALLIUM=y
> BR2_PACKAGE_MESA3D_OPENGL_EGL=y
> BR2_PACKAGE_MESA3D_OPENGL_ES=y
> BR2_PACKAGE_WLROOTS=y
> The issue was not caught in the autobuilders because the last
> successful build of a configuration that includes wlroots dates back
> from 2022-05-05, at which time Buildroot had wlroots 0.15.1.
> This change in wlroots was introduced in wlroots 0.16.0, which means
> that it's only since Buildroot bumped from 0.15.1 to 0.16.2 in
> d6279bc82c02b43c9a2f28c36639e092b9e9e08b ("package/wlroots: bump to
> version 0.16.2") that the issue occurs. This commit is not yet in any
> tagged release, so there is no need to backport this fix.
Ehh, git describe --contains d6279bc82c02b43c9a2f28c36639e092b9e9e08b
2023.11-rc1~361
So I've backported it to 2023.11.x as well, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-01-08 10:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-23 14:46 [Buildroot] [git commit] package/wlroots: add hwdata and hwdata_pnp_ids as a dependency Thomas Petazzoni via buildroot
2024-01-08 10:56 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plycxfel.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.