From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E06BC4167B for ; Wed, 29 Nov 2023 01:09:36 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=MWXJgvfH; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Sg1SZ4SK5z3cfB for ; Wed, 29 Nov 2023 12:09:34 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=MWXJgvfH; dkim-atps=neutral Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Sg1Rd4Qp1z3bx0 for ; Wed, 29 Nov 2023 12:08:45 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1701220117; bh=wBhFEZBwpVw/gHKTxfsy5vdBLb+lUAIAkOZ/hGhamxQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=MWXJgvfHJxliQBJkiXNpdWXvsPfgqvLUynOOGsEPC+D7Yi1QuhXmEfN+kMXE7CeG7 KnPLpSF4ktvj+swOi0eXMpV/JO1cOaCu70SgnmZ8sRPdkmwRTP+6c3PYp1RRDfS1aI /Qyed0XlK0zbrTl1rKGgGQlvJkFIIT1uj0OlZuWStkm3ERSzHE+9MPvz9pHYv+y6bL ZvL8fKh8T9mdNYOURZY5yfMY091t0Keiq7Of77u0caHbvFejdKjKjmS8usdJQR0PAT RNrBCTf6vm0roULx2/sPjSw7fGhWapxX3X5zPrngGsycCbNCpABsFyYlJ3A2ocQU/A yCVTJdjqXrT8g== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4Sg1RT02Gtz4wxY; Wed, 29 Nov 2023 12:08:36 +1100 (AEDT) From: Michael Ellerman To: Nathan Lynch via B4 Relay , Nicholas Piggin Subject: Re: [PATCH v4 13/13] powerpc/selftests: Add test for papr-sysparm In-Reply-To: <20231117-papr-sys_rtas-vs-lockdown-v4-13-b794d8cb8502@linux.ibm.com> References: <20231117-papr-sys_rtas-vs-lockdown-v4-0-b794d8cb8502@linux.ibm.com> <20231117-papr-sys_rtas-vs-lockdown-v4-13-b794d8cb8502@linux.ibm.com> Date: Wed, 29 Nov 2023 12:08:33 +1100 Message-ID: <87plzt2woe.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nathan Lynch , tyreld@linux.ibm.com, Michal =?utf-8?Q?Such=C3=A1nek?= , linuxppc-dev@lists.ozlabs.org, gcwilson@linux.ibm.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Nathan Lynch via B4 Relay writes: > From: Nathan Lynch > > Consistently testing system parameter access is a bit difficult by > nature -- the set of parameters available depends on the model and > system configuration, and updating a parameter should be considered a > destructive operation reserved for the admin. ... > diff --git a/tools/testing/selftests/powerpc/papr_sysparm/papr_sysparm.c b/tools/testing/selftests/powerpc/papr_sysparm/papr_sysparm.c > new file mode 100644 > index 000000000000..fc25c03e8bc7 > --- /dev/null > +++ b/tools/testing/selftests/powerpc/papr_sysparm/papr_sysparm.c > @@ -0,0 +1,164 @@ ... > +static int set_hmc0(void) > +{ > + struct papr_sysparm_io_block sp = { > + .parameter = 0, // HMC0, not a settable parameter > + }; > + const int devfd = open(DEVPATH, O_RDONLY); > + > + SKIP_IF_MSG(devfd < 0 && errno == ENOENT, > + DEVPATH " not present"); > + > + FAIL_IF(devfd < 0); > + > + // Ensure expected error > + FAIL_IF(ioctl(devfd, PAPR_SYSPARM_IOC_SET, &sp) != -1); > + FAIL_IF(errno != EPERM); > + > + FAIL_IF(close(devfd) != 0); > + > + return 0; > +} This one fails when run with qemu/KVM. # selftests: powerpc: papr_sysparm # test: open and close /dev/papr-sysparm without issuing commands # tags: git_version:v6.7-rc2-35-g41ada9f713ae # success: open and close /dev/papr-sysparm without issuing commands # test: retrieve SPLPAR characteristics # tags: git_version:v6.7-rc2-35-g41ada9f713ae # success: retrieve SPLPAR characteristics # test: verify EOPNOTSUPP for known-bad parameter # tags: git_version:v6.7-rc2-35-g41ada9f713ae # success: verify EOPNOTSUPP for known-bad parameter # test: PAPR_SYSPARM_IOC_GET returns EFAULT on bad address # tags: git_version:v6.7-rc2-35-g41ada9f713ae # success: PAPR_SYSPARM_IOC_GET returns EFAULT on bad address # test: PAPR_SYSPARM_IOC_SET returns EFAULT on bad address # tags: git_version:v6.7-rc2-35-g41ada9f713ae # success: PAPR_SYSPARM_IOC_SET returns EFAULT on bad address # test: ensure EPERM on attempt to update HMC0 # tags: git_version:v6.7-rc2-35-g41ada9f713ae # [FAIL] Test FAILED on line 113 # failure: ensure EPERM on attempt to update HMC0 It's returning EOPNOTSUPP. Something like below would work to fix it. cheers diff --git a/tools/testing/selftests/powerpc/papr_sysparm/papr_sysparm.c b/tools/testing/selftests/powerpc/papr_sysparm/papr_sysparm.c index fc25c03e8bc7..9d4850c25aed 100644 --- a/tools/testing/selftests/powerpc/papr_sysparm/papr_sysparm.c +++ b/tools/testing/selftests/powerpc/papr_sysparm/papr_sysparm.c @@ -110,6 +110,7 @@ static int set_hmc0(void) // Ensure expected error FAIL_IF(ioctl(devfd, PAPR_SYSPARM_IOC_SET, &sp) != -1); + SKIP_IF_MSG(errno == EOPNOTSUPP, "operation not supported"); FAIL_IF(errno != EPERM); FAIL_IF(close(devfd) != 0);