From: Thomas Gleixner <tglx@linutronix.de>
To: Dan Carpenter <dan.carpenter@linaro.org>,
oe-kbuild@lists.linux.dev,
Andrzej Hajda <andrzej.hajda@intel.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev
Subject: Re: [tglx-devel:queue/core 1/1] lib/debugobjects.c:730 debug_object_activate() error: 'obj' dereferencing possible ERR_PTR()
Date: Tue, 21 Nov 2023 16:17:29 +0100 [thread overview]
Message-ID: <87pm0316gm.ffs@tglx> (raw)
In-Reply-To: <2999d03c-4002-474f-9654-e9eded9af8c3@suswa.mountain>
On Mon, Nov 20 2023 at 03:55, Dan Carpenter wrote:
> smatch warnings:
> lib/debugobjects.c:730 debug_object_activate() error: 'obj' dereferencing possible ERR_PTR()
>
> vim +/obj +730 lib/debugobjects.c
>
> aedcade6f4fa9a Stephen Boyd 2020-08-14 694 int debug_object_activate(void *addr, const struct debug_obj_descr *descr)
> 3ac7fe5a4aab40 Thomas Gleixner 2008-04-30 695 {
> 63a759694eed61 Thomas Gleixner 2023-04-12 696 struct debug_obj o = { .object = addr, .state = ODEBUG_STATE_NOTAVAILABLE, .descr = descr };
> 3ac7fe5a4aab40 Thomas Gleixner 2008-04-30 697 struct debug_bucket *db;
> 3ac7fe5a4aab40 Thomas Gleixner 2008-04-30 698 struct debug_obj *obj;
> 3ac7fe5a4aab40 Thomas Gleixner 2008-04-30 699 unsigned long flags;
> 3ac7fe5a4aab40 Thomas Gleixner 2008-04-30 700
> 3ac7fe5a4aab40 Thomas Gleixner 2008-04-30 701 if (!debug_objects_enabled)
> b778ae25366e6f Paul E. McKenney 2013-04-23 702 return 0;
> 3ac7fe5a4aab40 Thomas Gleixner 2008-04-30 703
> 0af462f19e635a Thomas Gleixner 2023-05-01 704 debug_objects_fill_pool();
> 0af462f19e635a Thomas Gleixner 2023-05-01 705
> 3ac7fe5a4aab40 Thomas Gleixner 2008-04-30 706 db = get_bucket((unsigned long) addr);
> 3ac7fe5a4aab40 Thomas Gleixner 2008-04-30 707
> aef9cb05247df3 Thomas Gleixner 2009-11-17 708 raw_spin_lock_irqsave(&db->lock, flags);
> 3ac7fe5a4aab40 Thomas Gleixner 2008-04-30 709
> 63a759694eed61 Thomas Gleixner 2023-04-12 710 obj = lookup_object_or_alloc(addr, db, descr, false, true);
> 265c43c4e983ed Andrzej Hajda 2023-10-25 711 if (unlikely(!obj)) {
> 265c43c4e983ed Andrzej Hajda 2023-10-25 712 raw_spin_unlock_irqrestore(&db->lock, flags);
> 265c43c4e983ed Andrzej Hajda 2023-10-25 713 debug_objects_oom();
> 265c43c4e983ed Andrzej Hajda 2023-10-25 714 return 0;
> 265c43c4e983ed Andrzej Hajda 2023-10-25 715 } else if (likely(!IS_ERR(obj))) {
> ^^^^^^^^^^^^
> obj is an error pointer
Ah. Right that's silly. lookup_object_or_alloc() either returns a valid
pointer or NULL. Let me amend that before I move it over to tip.
Thanks,
tglx
next prev parent reply other threads:[~2023-11-21 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 8:55 [tglx-devel:queue/core 1/1] lib/debugobjects.c:730 debug_object_activate() error: 'obj' dereferencing possible ERR_PTR() Dan Carpenter
2023-11-21 15:17 ` Thomas Gleixner [this message]
2023-11-22 9:21 ` Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2023-11-09 13:25 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm0316gm.ffs@tglx \
--to=tglx@linutronix.de \
--cc=andrzej.hajda@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.