From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from ws5-mx01.kavi.com (ws5-mx01.kavi.com [34.193.7.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AA0FCDB47E for ; Wed, 18 Oct 2023 11:05:35 +0000 (UTC) Received: from lists.oasis-open.org (oasis.ws5.connectedcommunity.org [10.110.1.242]) by ws5-mx01.kavi.com (Postfix) with ESMTP id 68B1A22368 for ; Wed, 18 Oct 2023 11:05:34 +0000 (UTC) Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 4864498689F for ; Wed, 18 Oct 2023 11:05:34 +0000 (UTC) Received: from host09.ws5.connectedcommunity.org (host09.ws5.connectedcommunity.org [10.110.1.97]) by lists.oasis-open.org (Postfix) with QMQP id 349F1986898; Wed, 18 Oct 2023 11:05:34 +0000 (UTC) Mailing-List: contact virtio-comment-help@lists.oasis-open.org; run by ezmlm List-ID: Sender: Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 13C51986899 for ; Wed, 18 Oct 2023 11:04:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at kavi.com X-MC-Unique: RWLj60HuM3CPwZBBayQAFA-1 From: Cornelia Huck To: "Michael S. Tsirkin" Cc: Parav Pandit , "virtio-comment@lists.oasis-open.org" , "hengqi@linux.alibaba.com" , "xuanzhuo@linux.alibaba.com" , Shahaf Shuler In-Reply-To: <20231018062704-mutt-send-email-mst@kernel.org> Organization: "Red Hat GmbH, Sitz: Werner-von-Siemens-Ring 12, D-85630 Grasbrunn, Handelsregister: Amtsgericht =?utf-8?Q?M=C3=BCnchen=2C?= HRB 153243, =?utf-8?Q?Gesch=C3=A4ftsf=C3=BChrer=3A?= Ryan Barnhart, Charles Cachera, Michael O'Neill, Amy Ross" References: <20231002051601.6626-1-parav@nvidia.com> <20231002051601.6626-3-parav@nvidia.com> <871qdte8r6.fsf@redhat.com> <87sf68cjn0.fsf@redhat.com> <20231018062704-mutt-send-email-mst@kernel.org> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Date: Wed, 18 Oct 2023 13:03:57 +0200 Message-ID: <87pm1cchuq.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Subject: Re: [virtio-comment] RE: [PATCH v3 2/2] content: Support enabling virtqueue after DRIVER_OK stage On Wed, Oct 18 2023, "Michael S. Tsirkin" wrote: > On Wed, Oct 18, 2023 at 12:25:23PM +0200, Cornelia Huck wrote: >> On Tue, Oct 17 2023, Parav Pandit wrote: >> >> >> From: Cornelia Huck >> >> Sent: Tuesday, October 17, 2023 5:55 PM >> >> >> >> On Mon, Oct 02 2023, Parav Pandit wrote: >> >> > +When VIRTIO_F_RING_DYNAMIC is not negotiated, the driver MUST enable >> >> > +the required number of virtqueues before setting the DRIVER_OK status bit. >> >> >> >> What does "required" mean here? It just chooses to enable the queues it wants >> >> to use, right? >> > Right. >> > Required meaning, whatever number of queues that driver choose to enable, those must be enabled before driver_ok. >> > So it is "required by the driver". >> > Would that be ok? >> >> I'd write it as "the driver MUST enable any virtqueue it plans to use" >> or something like that. >> >> (...) > > It would have to be SHOULD - we can't add new MUST requirements not > contingent on a feature bit, we can give recommendation based on > existing installed base. Then I wonder whether we need to add any normative statement at all -- prior to the introduction of this new feature, the driver had to enable anything it wanted to use before DRIVER_OK, and if it does not negotiate the new feature, nothing changes. Spelling that out in non-normative sections should be enough? This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/