From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 743F4CD37B0 for ; Mon, 18 Sep 2023 15:50:30 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9A180826; Mon, 18 Sep 2023 17:49:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9A180826 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1695052227; bh=mseSK3ZSewXYklzOE4h9nvxnkWqsILfV0Wha+coMKfk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=oussC62BH1+BfjCqdEhHzYxa32d7Rcid3ccWX+Ym90HQft5PP33QfX+57X7aZ4H1D tnUdh9tTz6Ju9dJbY4gZAjENgIyQKyxgaeIGzs9Ji5oOscsi5Pg5VZQTqy0Euo60Wl WyUSbsDJZDqqbb2EdzVV1lvuZiT1yOQq+L0hiz2s= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 61149F80549; Mon, 18 Sep 2023 17:49:09 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 0D104F8025A; Mon, 18 Sep 2023 17:49:09 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 24638F8025A; Mon, 18 Sep 2023 17:49:05 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 8C6C4F80124 for ; Mon, 18 Sep 2023 17:48:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 8C6C4F80124 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=CLFa/s66; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=/0vvBK5v Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CE8611FFA7; Mon, 18 Sep 2023 15:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1695052138; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+TBDXEFXeuwNuiuJhWMyvfIEB4DoLQi0V//jCdnTRzE=; b=CLFa/s6695YKVHXk1v9UW0qPvnXIwdX9wpSMTu/17LIoz+v5d/frv05iuT4cZlcXqw8X0j +fCZhJddxUJhcUDAuPZnK2Jgd5g+02vAzWuB2sHU3aodPt+D0Oks8N/D9ABRVmrQzG+hm5 CodUGv5lFlU3+nE2Hbs1eyiZ4NrIISk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1695052138; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+TBDXEFXeuwNuiuJhWMyvfIEB4DoLQi0V//jCdnTRzE=; b=/0vvBK5vCUFyZNKHCEP+REFNt3NM9oSpmwh+henQXgNNK0NSwPpe8fIJLkNpskv7ZoSYrB OXEvNbGN2kfHMbAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A31FF13480; Mon, 18 Sep 2023 15:48:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id p/LvJmpxCGXuZgAAMHmgww (envelope-from ); Mon, 18 Sep 2023 15:48:58 +0000 Date: Mon, 18 Sep 2023 17:48:57 +0200 Message-ID: <87pm2fzdli.wl-tiwai@suse.de> From: Takashi Iwai To: "Geoffrey D. Bennett" Cc: Takashi Iwai , alsa-devel@alsa-project.org, Philippe Perrot Subject: Re: [PATCH 0/4] ALSA: scarlett2: Driver updates In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: 7IMV7UYYYVCWJTBLAC2T7FL6RI2AYYH4 X-Message-ID-Hash: 7IMV7UYYYVCWJTBLAC2T7FL6RI2AYYH4 X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 14 Sep 2023 19:31:37 +0200, Geoffrey D. Bennett wrote: > > Hi Takashi, > > I think it's time to enable this driver by default because: > > - Early versions of this mixer driver did not work on all hardware, so > out of caution the driver was disabled by default and had to be > explicitly enabled with device_setup=1. > > - Since commit 764fa6e686e0 ("ALSA: usb-audio: scarlett2: Fix device > hang with ehci-pci") (21/May/2021) no more problems of this nature > have been reported. > > - Therefore, patch 1 in this series proposes to enable the driver by > default, but provide a new device_setup option to disable the driver > in case that is needed. > > Patch 3 adds support for the Clarett 8Pre USB. This is the first > device supported by this driver which is controlled identically to > another, so patch 2 first allows sharing the device_info struct > between models. > > Patch 4 adds the specific product series name (like "Scarlett Gen 2") > to various messages so the text is correct without being unwieldy & > generic (like "Scarlett Gen 2/3/Clarett USB/Clarett+"). > > Geoffrey D. Bennett (4): > ALSA: scarlett2: Default mixer driver to enabled > ALSA: scarlett2: Move USB IDs out from device_info struct > ALSA: scarlett2: Add support for Clarett 8Pre USB > ALSA: scarlett2: Add correct product series name to messages Applied all four patches now. Thanks. Takashi