All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	igt-dev@lists.freedesktop.org,
	Alan Previn <alan.previn.teres.alexis@intel.com>,
	Kamil Konieczny <kamil.konieczny@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] lib/i915: Add a helper lib to read mmio registers via ioctl
Date: Thu, 17 Aug 2023 06:23:12 -0700	[thread overview]
Message-ID: <87pm3lsszj.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20230816142739.k2ycx6vn5rrx33rt@kamilkon-desk1>

On Wed, 16 Aug 2023 07:27:39 -0700, Kamil Konieczny wrote:
>

Hi Alan/Kamil,

> Hi Alan,
>
> On 2023-08-15 at 10:36:59 -0700, Alan Previn wrote:
> > Add a helper lib function to call DRM_IOCTL_I915_REG_READ to
> > read whitelisted registers.
> >
> > Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> > ---
> >  lib/i915/i915_reg_read_ioctl.c | 34 ++++++++++++++++++++++++++++++++++
> ---------------- ^^^^^^^^^^^^^^
>
> imho better name would be i915_mmio_reg
>
> >  lib/i915/i915_reg_read_ioctl.h |  9 +++++++++

Can't this just go in lib/ioctl_wrappers.*? Do we need a new file for this?

Thanks.
--
Ashutosh

  reply	other threads:[~2023-08-17 13:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-15 17:36 [igt-dev] [PATCH i-g-t] lib/i915: Add a helper lib to read mmio registers via ioctl Alan Previn
2023-08-15 18:11 ` [igt-dev] ○ CI.xeBAT: info for " Patchwork
2023-08-15 18:25 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-08-15 20:13 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-08-16 14:27 ` [igt-dev] [PATCH i-g-t] " Kamil Konieczny
2023-08-17 13:23   ` Dixit, Ashutosh [this message]
2023-08-17 17:12     ` Kamil Konieczny
2023-08-25 17:19       ` Teres Alexis, Alan Previn
2023-08-25 17:25   ` Teres Alexis, Alan Previn
2023-08-25 17:41     ` Teres Alexis, Alan Previn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pm3lsszj.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=alan.previn.teres.alexis@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@intel.com \
    --cc=kamil.konieczny@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.