All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Cc: qemu-devel@nongnu.org,  peter.maydell@linaro.org
Subject: Re: [PULL 1/5] qapi/block-core: Tidy up BlockLatencyHistogramInfo documentation
Date: Wed, 26 Jul 2023 14:01:34 +0200	[thread overview]
Message-ID: <87pm4e6fvl.fsf@pond.sub.org> (raw)
In-Reply-To: <a86c0dc4-a5dc-48cb-57af-92ecdf27ac81@yandex-team.ru> (Vladimir Sementsov-Ogievskiy's message of "Wed, 26 Jul 2023 14:33:36 +0300")

Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:

> On 26.07.23 14:28, Markus Armbruster wrote:
>> Documentation for member @bin comes out like
>>      list of io request counts corresponding to histogram intervals.
>>      len("bins") = len("boundaries") + 1 For the example above, "bins"
>>      may be something like [3, 1, 5, 2], and corresponding histogram
>>      looks like:
>>
>> Note how the equation and the sentence following it run together.
>> Replace the equation:
>>
>>      list of io request counts corresponding to histogram intervals,
>>      same number of elements as "boundaries".  For the example above,
>
> not same, but one more. N points break the line into N+1 intervals

Thanks for catching this.

What about "one more element than @boundaries has"?

>>      "bins" may be something like [3, 1, 5, 2], and corresponding
>>      histogram looks like:
>> Cc: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> Message-ID: <20230720071610.1096458-2-armbru@redhat.com>



  reply	other threads:[~2023-07-26 12:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26 11:28 [PULL 0/5] QAPI patches patches for 2023-07-26 Markus Armbruster
2023-07-26 11:28 ` [PULL 1/5] qapi/block-core: Tidy up BlockLatencyHistogramInfo documentation Markus Armbruster
2023-07-26 11:33   ` Vladimir Sementsov-Ogievskiy
2023-07-26 12:01     ` Markus Armbruster [this message]
2023-07-26 12:47       ` Vladimir Sementsov-Ogievskiy
2023-07-26 11:28 ` [PULL 2/5] qapi/block: Tidy up block-latency-histogram-set documentation Markus Armbruster
2023-07-26 11:28 ` [PULL 3/5] qapi/qdev: Tidy up device_add documentation Markus Armbruster
2023-07-26 11:28 ` [PULL 4/5] qapi/trace: Tidy up trace-event-get-state, -set-state documentation Markus Armbruster
2023-07-26 11:28 ` [PULL 5/5] qapi: Reformat recent doc comments to conform to current conventions Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pm4e6fvl.fsf@pond.sub.org \
    --to=armbru@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.