From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:b2c6:b0:930:eaf4:5c09 with SMTP id cf6csp525961ejb; Wed, 29 Mar 2023 07:02:10 -0700 (PDT) X-Google-Smtp-Source: AKy350bxwW7kuPRJtkeRlqFLV8VJE9Z753Vd67UpjrJVsuU114Sl+yEJXxeYwylKIODFFnVd9L0j X-Received: by 2002:adf:eb8c:0:b0:2ce:a8e9:bb3a with SMTP id t12-20020adfeb8c000000b002cea8e9bb3amr13947232wrn.4.1680098530496; Wed, 29 Mar 2023 07:02:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680098530; cv=none; d=google.com; s=arc-20160816; b=nyzuap67Qxeh3m1sdseHbIErp+0lV1/NgUQINiRUBecZrGNK+/5/r0pHlFlU0cNXzD kbJsHw8gVTGwFfzvFTsv0PuhCIpoMtZRSShek3hr0YHL7RZBa8ypXcfHeSQG3VGQWjfJ oREvyiveF1Gmg1Y9cMiMo6DqzDzooylY/OgPMTdMFRyA1p0a7P8d16fOAmwOD07/H0TB bzyAqqXXwaN1bRSo46n9CpLzEu4SRKTObCIOkAu2eMV2IiIq8AytWPDxzerFrFtE3odv k1qJPWnI4GbgdAQn50UUjxHgVZhF8hWcnA8L80MmZckLxM+tUH/2zkeMcf/N15XOGiLD X8MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature:dkim-signature; bh=0v7smsUOkD+0PDWZRSps2dW8wIjUlqektUnRtiqndwY=; b=RA8vpIeX00enffw5MU26lU1TkEcY8jcMBqHtvzVgSy10EyHeXuxJg1skdrLEwKOCQZ 256fS9h6Fhvindceh3MwsQuFYArbmT597tRYCgiRvCPdJZtnFvM7VNBSXAC6JqbyWQdA B8/7pxcgBcs3u5jhW6R7AiQKWo41N8BvUyRwpcewKGQbmAI10pa3drypjtzmDVfV8wzX RKGP3yQv3jIeFDC5RUVlClC3ek73BavzyesCdOVwILSEsmDH4os/OgOWlGl/HNDnJGHC Zfb1VLpDWqDZNTXRFYUvZ4k4IaCFQdkWSF8h9RXB+hi6D/Jl++VCkY4UsM8LnxmWar3j z8jA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=x+WCetoC; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of farosas@suse.de designates 2001:67c:2178:6::1d as permitted sender) smtp.mailfrom=farosas@suse.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de. [2001:67c:2178:6::1d]) by mx.google.com with ESMTPS id k4-20020a5d66c4000000b002cea8a21ea9si26947502wrw.521.2023.03.29.07.02.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Mar 2023 07:02:10 -0700 (PDT) Received-SPF: pass (google.com: domain of farosas@suse.de designates 2001:67c:2178:6::1d as permitted sender) client-ip=2001:67c:2178:6::1d; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=x+WCetoC; dkim=neutral (no key) header.i=@suse.de header.s=susede2_ed25519; spf=pass (google.com: domain of farosas@suse.de designates 2001:67c:2178:6::1d as permitted sender) smtp.mailfrom=farosas@suse.de; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D9B681FDD1; Wed, 29 Mar 2023 14:02:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1680098529; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0v7smsUOkD+0PDWZRSps2dW8wIjUlqektUnRtiqndwY=; b=x+WCetoCefp5zIX8H2o3l0n5Qc0ZTC8CAqx87CZ0otdreXGDyg7ulFSUHkWaKiV6kJRsFt jnuePyciEk9aABf86M+aIMJZWk8qEOPqjWd9l1EsoSXmxf1x9NjWExvGPAdY0bgUR9m9gj QkgxEbItVIkewPyATZO/zjrwntHys8o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1680098529; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0v7smsUOkD+0PDWZRSps2dW8wIjUlqektUnRtiqndwY=; b=iU6ws4hZnGFp9de3bINqs+L2zex2gzAkj9c1srM1RHqHc/2cWdg0eFSfdyiFGZmZRYPdNJ g90hJm/Ot2XsspBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 666DE138FF; Wed, 29 Mar 2023 14:02:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id XVoMDOFEJGSkJwAAMHmgww (envelope-from ); Wed, 29 Mar 2023 14:02:09 +0000 From: Fabiano Rosas To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Halil Pasic , David Gibson , Daniel Henrique Barboza , qemu-ppc@nongnu.org, Yanan Wang , David Hildenbrand , Christian Borntraeger , Eduardo Habkost , Paolo Bonzini , Marcel Apfelbaum , Greg Kurz , kvm@vger.kernel.org, Ilya Leoshkevich , Peter Maydell , Alex =?utf-8?Q?Benn=C3=A9e?= , Thomas Huth , Richard Henderson , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Philippe =?utf-8?Q?Mathieu-Da?= =?utf-8?Q?ud=C3=A9?= , =?utf-8?Q?C=C3=A9dric?= Le Goater Subject: Re: [PATCH-for-8.0 v2 3/3] softmmu: Restore use of CPU watchpoint for all accelerators In-Reply-To: <20230328173117.15226-4-philmd@linaro.org> References: <20230328173117.15226-1-philmd@linaro.org> <20230328173117.15226-4-philmd@linaro.org> Date: Wed, 29 Mar 2023 11:02:06 -0300 Message-ID: <87pm8ry7tt.fsf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TUID: p4Od1wHhCLwo Philippe Mathieu-Daud=C3=A9 writes: > CPU watchpoints can be use by non-TCG accelerators. > > KVM uses them: > > $ git grep CPUWatchpoint|fgrep kvm > target/arm/kvm64.c:1558: CPUWatchpoint *wp =3D find_hw_watchpoin= t(cs, debug_exit->far); > target/i386/kvm/kvm.c:5216:static CPUWatchpoint hw_watchpoint; > target/ppc/kvm.c:443:static CPUWatchpoint hw_watchpoint; > target/s390x/kvm/kvm.c:139:static CPUWatchpoint hw_watchpoint; > > See for example commit e4482ab7e3 ("target-arm: kvm - add support > for HW assisted debug"): > > This adds basic support for HW assisted debug. The ioctl interface > to KVM allows us to pass an implementation defined number of break > and watch point registers. [...] > > This partially reverts commit 2609ec2868e6c286e755a73b4504714a0296a. > > Fixes: 2609ec2868 ("softmmu: Extract watchpoint API from physmem.c") > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Fabiano Rosas