From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1740C05027 for ; Fri, 10 Feb 2023 09:33:19 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9B0C8847; Fri, 10 Feb 2023 10:32:27 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9B0C8847 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1676021597; bh=0ZplTmzQIw25b3akK9VQ1Bi4kdqTDuqO5RJksPuOQEs=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=R/RPhR4wC5Lkwzz+mkwJLbAReamHi0CaSGAFVdbvriLjQ8RGQfwnpkMoJEgKl7NYC CJKVs/5f5Rn3SXz1YSSTwfXogiigqEy9Bw4MFyP7925bE5OwWEOJjfLN87b+Y1zv0D v3ciqWdBdot+/iWKWH7p6UjO2yOQPEMQhcIqORvY= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 81458F80094; Fri, 10 Feb 2023 10:32:01 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BBE82F800E4; Fri, 10 Feb 2023 10:31:56 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 43C2EF80094 for ; Fri, 10 Feb 2023 10:31:45 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 43C2EF80094 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=hom8Tnls; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=lFGVWH4G Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 70CE7672EC; Fri, 10 Feb 2023 09:31:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676021504; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wnyh3ERVtrJcQax+/pzemQ3sT6BIlPSO2Zi7DS4QHlQ=; b=hom8TnlsJnGfIp54M3G0L2dCrM7Bh9JWE4TXv8+d8ALXOVjqDgXweC1lHOFZv0UQdjVJKK 44OxXmUmNqapsE7wupRC4FuuRFUJw1mt+H+Ak6sG8m9R8x3dlQjCGsJuXo/uRv+WX7mM+f lZJTZ7E/MTY3kVPKwe0SXctEcf/QuHM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676021504; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wnyh3ERVtrJcQax+/pzemQ3sT6BIlPSO2Zi7DS4QHlQ=; b=lFGVWH4Gtq49LKsHqOlzk+FK6mhk3tGDi3HjEJhuyt0f60sfW1qD4NnXMvuxv3rKBG3imd nHCdNNAJAcXSOHDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2FF0913206; Fri, 10 Feb 2023 09:31:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GAbxCgAP5mP/KwAAMHmgww (envelope-from ); Fri, 10 Feb 2023 09:31:44 +0000 Date: Fri, 10 Feb 2023 10:31:43 +0100 Message-ID: <87pmahj280.wl-tiwai@suse.de> From: Takashi Iwai To: Lucas Tanure Subject: Re: [PATCH v5 0/4] Add CS35L41 shared boost feature In-Reply-To: <20230210091942.10866-1-lucas.tanure@collabora.com> References: <20230210091942.10866-1-lucas.tanure@collabora.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: J476F626HGIJM6IQRPWEHBDS3A6W7RC5 X-Message-ID-Hash: J476F626HGIJM6IQRPWEHBDS3A6W7RC5 X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Rhodes , Charles Keepax , Liam Girdwood , Krzysztof Kozlowski , Mark Brown , Rob Herring , Takashi Iwai , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, kernel@collabora.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 10 Feb 2023 10:19:38 +0100, Lucas Tanure wrote: > > Valve's Steam Deck uses CS35L41 in shared boost mode, where both speakers > share the boost circuit. > Add this support in the shared lib, but for now, shared boost is not > supported in HDA systems as would require BIOS changes. > > Based on David Rhodes shared boost patches. > > Also, fix boost config overwriting in IRQ found in the review and do a > small refactor of the code. > > Changes from V4: > - Fix Document subject > > Changes from V3: > - Fix wrong code sent > - Fix ISO C90 mixed declarations and code > > Changes from V2: > - Drop External boost without VSPK Documentation > - Move Shared boost to use values 2 and 3 > - Revert back to reg_sequence but reading the value first and only update > the necessary bits > - Fix bug found by Intel kernel Test Robot > > Changes from V1: > - Fix Documentation patch subject > - New patch for External boost without VSPK Documentation > - New patch to fix boost IRQ overwriting issue > - New patch to refactor IRQ release error code > - reinit_completion on pcm_startup > - fix DRE switch overwriting > - return IRQ_HANDLED in PLL_LOCK case > > Lucas Tanure (4): > ASoC: cs35l41: Only disable internal boost > ASoC: cs35l41: Refactor error release code > ALSA: cs35l41: Add shared boost feature > ASoC: dt-bindings: cirrus,cs35l41: Document CS35l41 shared boost In case the series going through Mark's tree: Reviewed-by: Takashi Iwai thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F32BC636CD for ; Fri, 10 Feb 2023 09:31:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230286AbjBJJb6 (ORCPT ); Fri, 10 Feb 2023 04:31:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231667AbjBJJbs (ORCPT ); Fri, 10 Feb 2023 04:31:48 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D165245219; Fri, 10 Feb 2023 01:31:45 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 70CE7672EC; Fri, 10 Feb 2023 09:31:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1676021504; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wnyh3ERVtrJcQax+/pzemQ3sT6BIlPSO2Zi7DS4QHlQ=; b=hom8TnlsJnGfIp54M3G0L2dCrM7Bh9JWE4TXv8+d8ALXOVjqDgXweC1lHOFZv0UQdjVJKK 44OxXmUmNqapsE7wupRC4FuuRFUJw1mt+H+Ak6sG8m9R8x3dlQjCGsJuXo/uRv+WX7mM+f lZJTZ7E/MTY3kVPKwe0SXctEcf/QuHM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1676021504; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wnyh3ERVtrJcQax+/pzemQ3sT6BIlPSO2Zi7DS4QHlQ=; b=lFGVWH4Gtq49LKsHqOlzk+FK6mhk3tGDi3HjEJhuyt0f60sfW1qD4NnXMvuxv3rKBG3imd nHCdNNAJAcXSOHDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2FF0913206; Fri, 10 Feb 2023 09:31:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id GAbxCgAP5mP/KwAAMHmgww (envelope-from ); Fri, 10 Feb 2023 09:31:44 +0000 Date: Fri, 10 Feb 2023 10:31:43 +0100 Message-ID: <87pmahj280.wl-tiwai@suse.de> From: Takashi Iwai To: Lucas Tanure Cc: David Rhodes , Charles Keepax , Liam Girdwood , Krzysztof Kozlowski , Mark Brown , Rob Herring , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v5 0/4] Add CS35L41 shared boost feature In-Reply-To: <20230210091942.10866-1-lucas.tanure@collabora.com> References: <20230210091942.10866-1-lucas.tanure@collabora.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 10 Feb 2023 10:19:38 +0100, Lucas Tanure wrote: > > Valve's Steam Deck uses CS35L41 in shared boost mode, where both speakers > share the boost circuit. > Add this support in the shared lib, but for now, shared boost is not > supported in HDA systems as would require BIOS changes. > > Based on David Rhodes shared boost patches. > > Also, fix boost config overwriting in IRQ found in the review and do a > small refactor of the code. > > Changes from V4: > - Fix Document subject > > Changes from V3: > - Fix wrong code sent > - Fix ISO C90 mixed declarations and code > > Changes from V2: > - Drop External boost without VSPK Documentation > - Move Shared boost to use values 2 and 3 > - Revert back to reg_sequence but reading the value first and only update > the necessary bits > - Fix bug found by Intel kernel Test Robot > > Changes from V1: > - Fix Documentation patch subject > - New patch for External boost without VSPK Documentation > - New patch to fix boost IRQ overwriting issue > - New patch to refactor IRQ release error code > - reinit_completion on pcm_startup > - fix DRE switch overwriting > - return IRQ_HANDLED in PLL_LOCK case > > Lucas Tanure (4): > ASoC: cs35l41: Only disable internal boost > ASoC: cs35l41: Refactor error release code > ALSA: cs35l41: Add shared boost feature > ASoC: dt-bindings: cirrus,cs35l41: Document CS35l41 shared boost In case the series going through Mark's tree: Reviewed-by: Takashi Iwai thanks, Takashi