From: Juan Quintela <quintela@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org,
Leonardo Bras Soares Passos <lsoaresp@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
qemu-stable@nongnu.org, Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH] migration: Fix migration crash when target psize larger than host
Date: Mon, 30 Jan 2023 05:38:35 +0100 [thread overview]
Message-ID: <87pmawmyb8.fsf@secure.mitica> (raw)
In-Reply-To: <20230120163147.2343050-1-peterx@redhat.com> (Peter Xu's message of "Fri, 20 Jan 2023 11:31:47 -0500")
Peter Xu <peterx@redhat.com> wrote:
> Commit d9e474ea56 overlooked the case where the target psize is even larger
> than the host psize. One example is Alpha has 8K page size and migration
> will start to crash the source QEMU when running Alpha migration on x86.
>
> Fix it by detecting that case and set host start/end just to cover the
> single page to be migrated.
>
> This will slightly optimize the common case where host psize equals to
> guest psize so we don't even need to do the roundups, but that's trivial.
>
> Cc: qemu-stable@nongnu.org
> Reported-by: Thomas Huth <thuth@redhat.com>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1456
> Fixes: d9e474ea56 ("migration: Teach PSS about host page")
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
queued
prev parent reply other threads:[~2023-01-30 4:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 16:31 [PATCH] migration: Fix migration crash when target psize larger than host Peter Xu
2023-01-23 9:15 ` Thomas Huth
2023-01-30 4:38 ` Juan Quintela [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmawmyb8.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lsoaresp@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.