From: Jakub Sitnicki <jakub@cloudflare.com>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: davem@davemloft.net, edumazet@google.com,
kernel-team@cloudflare.com, kuba@kernel.org,
netdev@vger.kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net-next v2 2/2] selftests/net: Cover the IP_LOCAL_PORT_RANGE socket option
Date: Wed, 11 Jan 2023 13:45:10 +0100 [thread overview]
Message-ID: <87pmblck9c.fsf@cloudflare.com> (raw)
In-Reply-To: <20230111012500.48018-1-kuniyu@amazon.com>
On Wed, Jan 11, 2023 at 10:25 AM +09, Kuniyuki Iwashima wrote:
> From: Jakub Sitnicki <jakub@cloudflare.com>
> Date: Tue, 10 Jan 2023 14:37:30 +0100
>> Exercise IP_LOCAL_PORT_RANGE socket option in various scenarios:
>>
>> 1. pass invalid values to setsockopt
>> 2. pass a range outside of the per-netns port range
>> 3. configure a single-port range
>> 4. exhaust a configured multi-port range
>> 5. check interaction with late-bind (IP_BIND_ADDRESS_NO_PORT)
>> 6. set then get the per-socket port range
>>
>> v1 -> v2:
>> * selftests: Instead of iterating over socket families (ip4, ip6) and types
>> (tcp, udp), generate tests for each combo from a template. This keeps the
>> code indentation level down and makes tests more granular.
>
> We can use TEST_F(), FIXTURE_VARIANT() and FIXTURE_VARIANT_ADD() for
> such cases.
>
> e.g.) tools/testing/selftests/net/tls.c
Just what I need. Thank you for pointing me to it.
prev parent reply other threads:[~2023-01-11 12:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 13:37 [PATCH net-next v2 0/2] Add IP_LOCAL_PORT_RANGE socket option Jakub Sitnicki
2023-01-10 13:37 ` [PATCH net-next v2 1/2] inet: " Jakub Sitnicki
2023-01-10 14:28 ` Eric Dumazet
2023-01-10 21:36 ` Jakub Sitnicki
2023-01-11 0:59 ` Kuniyuki Iwashima
2023-01-11 12:44 ` Jakub Sitnicki
2023-01-10 13:37 ` [PATCH net-next v2 2/2] selftests/net: Cover the " Jakub Sitnicki
2023-01-11 1:25 ` Kuniyuki Iwashima
2023-01-11 12:45 ` Jakub Sitnicki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmblck9c.fsf@cloudflare.com \
--to=jakub@cloudflare.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.