From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5976C352A1 for ; Wed, 7 Dec 2022 17:32:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 22C3610E40B; Wed, 7 Dec 2022 17:32:03 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA78610E40B for ; Wed, 7 Dec 2022 17:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670434317; x=1701970317; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=2WY22f5EwwAAcXFDTZLhgnwUzz3RLmfs2yAohXeBTig=; b=mTpMf77elrbRpUjrZyIMgGQKgyU6HbuPvZeXuj82mErRR06muglef66u r1FijIUyoqrc4InHJqxxlOwqd+jDaccbi0Xq76zk/3lwCa2mwZjiRiRIE lvJ6gFFbmU8e7stqpg3CAO3fITH/jjNdAFG5wyfUVc1LJPgveY2Eaz+HC BqB6JPFRQ4LALrH26ZVbmmfAtbbxkq8DWH+ghBTF+eUqwhGuVQSGZqm8f NwknlXuJdvitm1uiSkPm3XxwuMVcihgtqnHT8sbEBxl3ujxcE7lyuFNdo SvwpSqD6UCCHbIeuxOaNZKCsBT1BW2AYDZ4Ndx+1Cgrk6Tu6dDhy+hWjj w==; X-IronPort-AV: E=McAfee;i="6500,9779,10554"; a="296646682" X-IronPort-AV: E=Sophos;i="5.96,225,1665471600"; d="scan'208";a="296646682" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2022 09:31:57 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10554"; a="646689331" X-IronPort-AV: E=Sophos;i="5.96,225,1665471600"; d="scan'208";a="646689331" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.106.185]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2022 09:31:56 -0800 Date: Wed, 07 Dec 2022 09:24:28 -0800 Message-ID: <87pmcvcek3.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Alan Previn In-Reply-To: <20221206092100.274195-6-alan.previn.teres.alexis@intel.com> References: <20221206092100.274195-1-alan.previn.teres.alexis@intel.com> <20221206092100.274195-6-alan.previn.teres.alexis@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH v2 5/5] drm/i915/guc: Move guc_log_relay_chan debugfs path to uc X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 06 Dec 2022 01:21:00 -0800, Alan Previn wrote: > > All other GuC Relay Logging debugfs handles including recent > additions are under the 'i915/gt/uc/path' so let's also move > 'guc_log_relay_chan' to its proper home. > > Signed-off-by: Alan Previn > --- > drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 ++ > drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 2 +- > drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 ++ > 3 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h b/drivers/gpu/drm/i915/gt/uc/intel_guc.h > index bb4dfe707a7d..f5394d12c3dd 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h > @@ -41,6 +41,8 @@ struct intel_guc { > struct intel_guc_slpc slpc; > /** @capture: the error-state-capture module's data and objects */ > struct intel_guc_state_capture *capture; > + /** @dbgfs_node: the debugfs path for guc file handles */ > + struct dentry *dbgfs_node; > > /** @sched_engine: Global engine used to submit requests to GuC */ > struct i915_sched_engine *sched_engine; > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c > index d019c60d34e8..2f1825f367bf 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c > @@ -552,7 +552,7 @@ static int guc_log_relay_create(struct intel_guc_log *log) > n_subbufs = intel_guc_log_relay_subbuf_count(log); > > guc_log_relay_chan = relay_open("guc_log_relay_chan", > - dev_priv->drm.primary->debugfs_root, > + guc->dbgfs_node, > subbuf_size, n_subbufs, > &relay_callbacks, dev_priv); > if (!guc_log_relay_chan) { > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c > index 284d6fbc2d08..2f93cc4e408a 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c > @@ -54,6 +54,8 @@ void intel_uc_debugfs_register(struct intel_uc *uc, struct dentry *gt_root) > if (IS_ERR(root)) > return; > > + uc->guc.dbgfs_node = root; > + Nit but why touch GuC specific field in UC level function, set it in intel_guc_debugfs_register? > intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), uc); > > intel_guc_debugfs_register(&uc->guc, root); After moving the line above to intel_guc_debugfs_register, this is: Reviewed-by: Ashutosh Dixit