From: Jani Nikula <jani.nikula@intel.com>
To: Kees Cook <keescook@chromium.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/hti: avoid theoretically possible negative shift
Date: Wed, 23 Nov 2022 11:18:02 +0200 [thread overview]
Message-ID: <87pmdevxkl.fsf@intel.com> (raw)
In-Reply-To: <202211222116.5B28E9B8B@keescook>
On Tue, 22 Nov 2022, Kees Cook <keescook@chromium.org> wrote:
> On Tue, Nov 22, 2022 at 02:09:48PM +0200, Jani Nikula wrote:
>> If phy is PHY_NONE, the shift to register bits becomes negative. Check
>> and warn about this.
>>
>> Reported-by: coverity-bot <keescook@chromium.org>
>> References: https://lore.kernel.org/r/202211180848.D39006C@keescook
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
Thanks for the review, pushed to drm-intel-next.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
prev parent reply other threads:[~2022-11-23 9:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 12:09 [Intel-gfx] [PATCH] drm/i915/hti: avoid theoretically possible negative shift Jani Nikula
2022-11-22 17:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-11-23 4:25 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-11-23 5:16 ` [Intel-gfx] [PATCH] " Kees Cook
2022-11-23 9:18 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmdevxkl.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=keescook@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.