From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B1F0C4332F for ; Wed, 16 Nov 2022 14:05:23 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E27BC1654; Wed, 16 Nov 2022 15:04:30 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E27BC1654 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1668607520; bh=3tcjET53ccOen+SmImjAyU1rdUOOiqESz18ZmEcTy7k=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=X6yhCxFVYaOPo0spTfHNuSZtEZNoYj/yQ0UV42ScOi0Osbgp93zLXVRw5CT7r+fZy FIBvVftfaC6NBXjLXNHERq8orO3m1/DLVPywLBqOHKT8S6AA7osdc1KaMW9SmgCNe0 UShHe0TJ3ycFc8D44tvhAsayNyyY0gRDcziAOBx4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 80C84F80089; Wed, 16 Nov 2022 15:04:30 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 18FC5F80169; Wed, 16 Nov 2022 15:04:29 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E254CF80089 for ; Wed, 16 Nov 2022 15:03:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E254CF80089 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="MypaEH4O"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="d02xtedN" Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 74764336F7; Wed, 16 Nov 2022 14:03:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1668607436; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WwzAEC8k7kmJVTViEBMpc5e9CFVnrcRygA0pQ8SwSEs=; b=MypaEH4O6a3p7lTXXepyuOcp2zzH+rAZwl5NDFYX9IX3lxx+zoylKLk6pMyDeYGa7faAAG OaM2ufad+kQPaOTGrTwD8rSPsQ98a9ouxr4ASn+mlriMqkMLAPE5gChnD3/GGXll4Mdi6D uKyYa/MNoZdM+1rW198+yb5Le0nfuaA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1668607436; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WwzAEC8k7kmJVTViEBMpc5e9CFVnrcRygA0pQ8SwSEs=; b=d02xtedNfBcpT0+wQiB41OOD8YCzqKK1D3k0HFXddyQCQLs58Zv3TGMKZZQ0TJhadfeOsm 4WaI5QyDPaYWvSDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 569E9134CE; Wed, 16 Nov 2022 14:03:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id AxSiFMztdGMtTQAAMHmgww (envelope-from ); Wed, 16 Nov 2022 14:03:56 +0000 Date: Wed, 16 Nov 2022 15:03:55 +0100 Message-ID: <87pmdn3sj8.wl-tiwai@suse.de> From: Takashi Iwai To: Jaroslav Kysela Subject: Re: [PATCH v2] [RFC] selftests: alsa - add PCM test In-Reply-To: <20221108115914.3751090-1-perex@perex.cz> References: <20221108115914.3751090-1-perex@perex.cz> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Cc: ALSA development , Jimmy Cheng-Yi Chiang , Curtis Malainey , Brian Norris , Mark Brown , Liam Girdwood , Jesse Barnes , Pierre-Louis Bossart X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 08 Nov 2022 12:59:14 +0100, Jaroslav Kysela wrote: > > This initial code does a simple sample transfer tests. By default, > all PCM devices are detected and tested with short and long > buffering parameters for 4 seconds. If the sample transfer timing > is not in a +-100ms boundary, the test fails. Only the interleaved > buffering scheme is supported in this version. > > The configuration may be modified with the configuration files. > A specific hardware configuration is detected and activated > using the sysfs regex matching. This allows to use the DMI string > (/sys/class/dmi/id/* tree) or any other system parameters > exposed in sysfs for the matching for the CI automation. > > The configuration file may also specify the PCM device list to detect > the missing PCM devices. > > v1..v2: > - added missing alsa-local.h header file > > Cc: Mark Brown > Cc: Pierre-Louis Bossart > Cc: Liam Girdwood > Cc: Jesse Barnes > Cc: Jimmy Cheng-Yi Chiang > Cc: Curtis Malainey > Cc: Brian Norris > Signed-off-by: Jaroslav Kysela Sorry for the late reply. The patch looks good and works fine on the smoke test, so I applied it now. There are a few issues Mark already commented on, and we can fix or improve them in incremental manner later. thanks, Takashi