From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4A95ECAAD8 for ; Fri, 16 Sep 2022 05:44:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229685AbiIPFoe (ORCPT ); Fri, 16 Sep 2022 01:44:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229613AbiIPFoc (ORCPT ); Fri, 16 Sep 2022 01:44:32 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3BDF5E669 for ; Thu, 15 Sep 2022 22:44:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B4D9BB8235A for ; Fri, 16 Sep 2022 05:44:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF3E4C433D6; Fri, 16 Sep 2022 05:44:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663307063; bh=R1S8FgHayaYhk3ltK1TLwAkBP0yqIaxNrzlMpbcUWqg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=QKl9K0Dz71ZfLtqU4u8YitF/WPfWLWa7TFVLgzHQdUtRxUSQ18Av8t4uJUr9a7JUI kr7koPLdwBoqYv0aBKI/WtVnYEEYvT6uEMWo2VFlaBpE7G+uUXMsMLY8Pk6hBWwoWC JvxJlwUTGI8FoDjs1rPGGF5Cd9FGlpt7nu6uKCPPEZqHyhM1+6Q6QXTrgetu0UTlsz trl589AeiOZvbUXDh+4DgBJt3fpv5Pgq4mnvhY0KmpD7Fsj11Z6U7N/ajGEBMRPt2x Isj896uSB/Qnc4F7vEVuM0hxxsi89PntE1yB3YZG2sNAsppgbk5QSaJ00LEk5xbs4s dC70oGzlyDsXg== From: Kalle Valo To: James Prestwood Cc: linux-wireless@vger.kernel.org Subject: Re: [PATCH] net: mac80211: remove/avoid misleading prints References: <20220915195553.1052931-1-prestwoj@gmail.com> Date: Fri, 16 Sep 2022 08:44:17 +0300 In-Reply-To: <20220915195553.1052931-1-prestwoj@gmail.com> (James Prestwood's message of "Thu, 15 Sep 2022 12:55:53 -0700") Message-ID: <87pmfvan66.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org James Prestwood writes: > At some point a few kernel debug prints started appearing which > indicated something was sending invalid IEs: > > "bad VHT capabilities, disabling VHT" > "Invalid HE elem, Disable HE" > > Turns out these were being printed because the local hardware > supported HE/VHT but the peer/AP did not. Bad/invalid indicates, > to me at least, that the IE is in some way malformed, not missing. > > For the HE print (ieee80211_verify_peer_he_mcs_support) it will > now silently fail if the HE capability element is missing (still > prints if the element size is wrong). > > For the VHT print, it has been removed completely and will silently > set the DISABLE_VHT flag which is consistent with how DISABLE_HT > is set. > > Signed-off-by: James Prestwood This has been cluttering my test logs as well, thanks for fixing this. But the title should be: wifi: mac80211: remove/avoid misleading prints I assume Johannes can fix it during commit. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches