From: Petr Machata <petrm@nvidia.com>
To: Ido Schimmel <idosch@nvidia.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<kuba@kernel.org>, <pabeni@redhat.com>, <edumazet@google.com>,
<petrm@nvidia.com>, <jie2x.zhou@intel.com>, <mlxsw@nvidia.com>
Subject: Re: [PATCH net] netdevsim: Fix hwstats debugfs file permissions
Date: Mon, 12 Sep 2022 10:57:06 +0200 [thread overview]
Message-ID: <87pmg1dl5z.fsf@nvidia.com> (raw)
In-Reply-To: <20220909153830.3732504-1-idosch@nvidia.com>
Ido Schimmel <idosch@nvidia.com> writes:
> The hwstats debugfs files are only writeable, but they are created with
> read and write permissions, causing certain selftests to fail [1].
>
> Fix by creating the files with write permission only.
>
> [1]
> # ./test_offload.py
> Test destruction of generic XDP...
> Traceback (most recent call last):
> File "/home/idosch/code/linux/tools/testing/selftests/bpf/./test_offload.py", line 810, in <module>
> simdev = NetdevSimDev()
> [...]
> Exception: Command failed: cat /sys/kernel/debug/netdevsim/netdevsim0//ports/0/dev/hwstats/l3/disable_ifindex
>
> cat: /sys/kernel/debug/netdevsim/netdevsim0//ports/0/dev/hwstats/l3/disable_ifindex: Invalid argument
>
> Fixes: 1a6d7ae7d63c ("netdevsim: Introduce support for L3 offload xstats")
> Reported-by: Jie2x Zhou <jie2x.zhou@intel.com>
> Tested-by: Jie2x Zhou <jie2x.zhou@intel.com>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Petr Machata <petrm@nvidia.com>
next prev parent reply other threads:[~2022-09-12 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 15:38 [PATCH net] netdevsim: Fix hwstats debugfs file permissions Ido Schimmel
2022-09-12 8:57 ` Petr Machata [this message]
2022-09-20 1:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmg1dl5z.fsf@nvidia.com \
--to=petrm@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=jie2x.zhou@intel.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.