From: Kalle Valo <kvalo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, pabeni@redhat.com,
edumazet@google.com, petrm@nvidia.com
Subject: Re: [PATCH net-next 1/3] rtnl: allocate more attr tables on the heap
Date: Sat, 30 Apr 2022 10:32:25 +0300 [thread overview]
Message-ID: <87pmkzc9h2.fsf@kernel.org> (raw)
In-Reply-To: <20220429235508.268349-2-kuba@kernel.org> (Jakub Kicinski's message of "Fri, 29 Apr 2022 16:55:06 -0700")
Jakub Kicinski <kuba@kernel.org> writes:
> Commit a293974590cf ("rtnetlink: avoid frame size warning in rtnl_newlink()")
> moved to allocating the largest attribute array of rtnl_newlink()
> on the heap. Kalle reports the stack has grown above 1k again:
>
> net/core/rtnetlink.c:3557:1: error: the frame size of 1104 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
>
> Move more attrs to the heap, wrap them in a struct.
> Don't bother with linkinfo, it's referenced a lot and we take
> its size so it's awkward to move, plus it's small (6 elements).
>
> Reported-by: Kalle Valo <kvalo@kernel.org>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
I don't see the warning anymore, thanks!
Tested-by: Kalle Valo <kvalo@kernel.org>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-04-30 7:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 23:55 [PATCH net-next 0/3] net: more heap allocation and split of rtnl_newlink() Jakub Kicinski
2022-04-29 23:55 ` [PATCH net-next 1/3] rtnl: allocate more attr tables on the heap Jakub Kicinski
2022-04-30 7:32 ` Kalle Valo [this message]
2022-04-29 23:55 ` [PATCH net-next 2/3] rtnl: split __rtnl_newlink() into two functions Jakub Kicinski
2022-04-29 23:55 ` [PATCH net-next 3/3] rtnl: move rtnl_newlink_create() Jakub Kicinski
2022-05-02 13:30 ` [PATCH net-next 0/3] net: more heap allocation and split of rtnl_newlink() patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmkzc9h2.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.