From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E339BC433EF for ; Thu, 31 Mar 2022 13:59:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3770910EE8E; Thu, 31 Mar 2022 13:59:17 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1FFBA10EE8E for ; Thu, 31 Mar 2022 13:59:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648735156; x=1680271156; h=from:to:subject:in-reply-to:references:date:message-id: mime-version:content-transfer-encoding; bh=85rK6yuqh72TbMshPvVFgzQFeAE1OxQzsgM0AnYDedE=; b=ADtthzmvSDo8Cy2VHL/Sa9YjgoA/9ujpu8F/gJbYQul75LTYMfpziqMn eFzB/CaXbTfTI1GIwheVVgQ6rYtQJfqjLAvlsw41+L/h3AVEIkagR4stz 87q/pure79IXKv4ljR9P2ZjZMOj+O6aSXW1kymYFR4WoHlhRzAci0UnfA skhcSv00g0YHOJzdeHQ7y8teoPZpuU5Dfak4fP9rUqleTCRdIG8TVLv1b HAX9kScKk1TsnkW8xrZ/Pn1wZvdiZc7FbeCL4V0CkZBevqvZscR24eg0f CQyfWKK9tHXXfKWY3BePZq7Gt82HMIFh1dxJUJ0HDNX5UrwO6ZVClANed g==; X-IronPort-AV: E=McAfee;i="6200,9189,10302"; a="260025631" X-IronPort-AV: E=Sophos;i="5.90,225,1643702400"; d="scan'208";a="260025631" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2022 06:59:15 -0700 X-IronPort-AV: E=Sophos;i="5.90,225,1643702400"; d="scan'208";a="720473098" Received: from gluca-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.48.194]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2022 06:59:14 -0700 From: Jani Nikula To: Ville Syrjala , intel-gfx@lists.freedesktop.org In-Reply-To: <20220331112822.11462-12-ville.syrjala@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20220331112822.11462-1-ville.syrjala@linux.intel.com> <20220331112822.11462-12-ville.syrjala@linux.intel.com> Date: Thu, 31 Mar 2022 16:59:11 +0300 Message-ID: <87pmm28bps.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH v2 11/11] drm/i915: Allow static DRRS on LVDS X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 31 Mar 2022, Ville Syrjala wrote: > From: Ville Syrj=C3=A4l=C3=A4 > > Nothing special about static DRRS on LVDS, it's just your > bog standard modeset. Let's allow it. > > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 > --- > drivers/gpu/drm/i915/display/intel_lvds.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_lvds.c b/drivers/gpu/drm/= i915/display/intel_lvds.c > index 73129d21f5e5..e8478161f8b9 100644 > --- a/drivers/gpu/drm/i915/display/intel_lvds.c > +++ b/drivers/gpu/drm/i915/display/intel_lvds.c > @@ -968,7 +968,8 @@ void intel_lvds_init(struct drm_i915_private *dev_pri= v) > intel_connector->edid =3D edid; >=20=20 > /* Try EDID first */ > - intel_panel_add_edid_fixed_modes(intel_connector, false); > + intel_panel_add_edid_fixed_modes(intel_connector, > + dev_priv->vbt.drrs_type !=3D DRRS_TYPE_NONE); I guess the final question on this, and the previous patch for that matter, is why would the VBT block your regular modeset between two different refresh rates? It does sound like the VBT setting is more about OEM decided policy than anything else. Anyway, Reviewed-by: Jani Nikula >=20=20 > /* Failed to get EDID, what about VBT? */ > if (!intel_panel_preferred_fixed_mode(intel_connector)) --=20 Jani Nikula, Intel Open Source Graphics Center