From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Felix Fietkau <nbd@nbd.name>,
"Jesper D. Brouer" <netdev@brouer.com>,
netdev@vger.kernel.org, bpf <bpf@vger.kernel.org>
Cc: brouer@redhat.com, John Fastabend <john.fastabend@gmail.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH] net: xdp: allow user space to request a smaller packet headroom requirement
Date: Mon, 14 Mar 2022 23:16:10 +0100 [thread overview]
Message-ID: <87pmmouqmt.fsf@toke.dk> (raw)
In-Reply-To: <4ff44a95-2818-32d9-c907-20e84f24a3e6@nbd.name>
Felix Fietkau <nbd@nbd.name> writes:
> On 14.03.22 21:39, Jesper D. Brouer wrote:
>> (Cc. BPF list and other XDP maintainers)
>>
>> On 14/03/2022 11.22, Felix Fietkau wrote:
>>> Most ethernet drivers allocate a packet headroom of NET_SKB_PAD. Since it is
>>> rounded up to L1 cache size, it ends up being at least 64 bytes on the most
>>> common platforms.
>>> On most ethernet drivers, having a guaranteed headroom of 256 bytes for XDP
>>> adds an extra forced pskb_expand_head call when enabling SKB XDP, which can
>>> be quite expensive.
>>> Many XDP programs need only very little headroom, so it can be beneficial
>>> to have a way to opt-out of the 256 bytes headroom requirement.
>>
>> IMHO 64 bytes is too small.
>> We are using this area for struct xdp_frame and also for metadata
>> (XDP-hints). This will limit us from growing this structures for
>> the sake of generic-XDP.
>>
>> I'm fine with reducting this to 192 bytes, as most Intel drivers
>> have this headroom, and have defacto established that this is
>> a valid XDP headroom, even for native-XDP.
>>
>> We could go a small as two cachelines 128 bytes, as if xdp_frame
>> and metadata grows above a cache-line (64 bytes) each, then we have
>> done something wrong (performance wise).
> Here's some background on why I chose 64 bytes: I'm currently
> implementing a userspace + xdp program to act as generic fastpath to
> speed network bridging.
Any reason this can't run in the TC ingress hook instead? Generic XDP is
a bit of an odd duck, and I'm not a huge fan of special-casing it this
way...
-Toke
next prev parent reply other threads:[~2022-03-14 22:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 10:22 [PATCH] net: xdp: allow user space to request a smaller packet headroom requirement Felix Fietkau
2022-03-14 20:39 ` Jesper D. Brouer
2022-03-14 21:42 ` Felix Fietkau
2022-03-14 22:16 ` Toke Høiland-Jørgensen [this message]
2022-03-14 22:20 ` Daniel Borkmann
2022-03-14 22:43 ` Felix Fietkau
2022-03-15 6:50 ` Jesper Dangaard Brouer
2022-03-15 7:25 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmmouqmt.fsf@toke.dk \
--to=toke@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@brouer.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.