From: Markus Armbruster <armbru@redhat.com>
To: zhenwei pi <pizhenwei@bytedance.com>
Cc: michael.roth@amd.com, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/2] qapi: Introduce NVMe disk bus type
Date: Wed, 02 Mar 2022 10:35:54 +0100 [thread overview]
Message-ID: <87pmn4k879.fsf@pond.sub.org> (raw)
In-Reply-To: <20220302085410.1302157-2-pizhenwei@bytedance.com> (zhenwei pi's message of "Wed, 2 Mar 2022 16:54:09 +0800")
zhenwei pi <pizhenwei@bytedance.com> writes:
> Assigning a NVMe disk by VFIO or emulating a NVMe controller by QEMU,
> a NVMe disk get exposed in guest side. Support NVMe disk bus type for
> QAPI.
>
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> ---
> qga/qapi-schema.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index 94e4aacdcc..1b5ea4c5f8 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -827,13 +827,14 @@
> # @mmc: Win multimedia card (MMC) bus type
> # @virtual: Win virtual bus type
> # @file-backed-virtual: Win file-backed bus type
> +# @nvme: NVMe disks
> #
> # Since: 2.2; 'Unknown' and all entries below since 2.4
> ##
> { 'enum': 'GuestDiskBusType',
> 'data': [ 'ide', 'fdc', 'scsi', 'virtio', 'xen', 'usb', 'uml', 'sata',
> 'sd', 'unknown', 'ieee1394', 'ssa', 'fibre', 'raid', 'iscsi',
> - 'sas', 'mmc', 'virtual', 'file-backed-virtual' ] }
> + 'sas', 'mmc', 'virtual', 'file-backed-virtual', 'nvme' ] }
>
>
> ##
Please change the title to something like
qga: Introduce NVMe disk bus type
I'd squash the two patches together.
next prev parent reply other threads:[~2022-03-02 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 8:54 [PATCH 0/2] QAPI: Support NVMe disk type zhenwei pi
2022-03-02 8:54 ` [PATCH 1/2] qapi: Introduce NVMe disk bus type zhenwei pi
2022-03-02 9:35 ` Markus Armbruster [this message]
2022-03-02 8:54 ` [PATCH 2/2] qga/commands-posix: Support NVMe disk type zhenwei pi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmn4k879.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=michael.roth@amd.com \
--cc=pizhenwei@bytedance.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.