From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Ellerman Date: Wed, 09 Feb 2022 15:46:05 +1100 Subject: [PATCH v5 0/6] KEXEC_SIG with appended signature In-Reply-To: References: Message-ID: <87pmnwlkaa.fsf@mpe.ellerman.id.au> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kexec@lists.infradead.org Luis Chamberlain writes: > On Tue, Jan 11, 2022 at 12:37:42PM +0100, Michal Suchanek wrote: >> Hello, >> >> This is a refresh of the KEXEC_SIG series. >> >> This adds KEXEC_SIG support on powerpc and deduplicates the code dealing >> with appended signatures in the kernel. >> >> powerpc supports IMA_KEXEC but that's an exception rather than the norm. >> On the other hand, KEXEC_SIG is portable across platforms. >> >> For distributions to have uniform security features across platforms one >> option should be used on all platforms. >> >> Thanks >> >> Michal >> >> Previous revision: https://lore.kernel.org/linuxppc-dev/cover.1637862358.git.msuchanek at suse.de/ >> Patched kernel tree: https://github.com/hramrach/kernel/tree/kexec_sig >> >> Michal Suchanek (6): >> s390/kexec_file: Don't opencode appended signature check. >> powerpc/kexec_file: Add KEXEC_SIG support. >> kexec_file: Don't opencode appended signature verification. >> module: strip the signature marker in the verification function. >> module: Use key_being_used_for for log messages in >> verify_appended_signature >> module: Move duplicate mod_check_sig users code to mod_parse_sig > > What tree should this go through? I'd prefer if over through modules > tree as it can give a chance for Aaron Tomlin to work with this for his > code refactoring of kernel/module*.c to kernel/module/ Yeah that's fine by me, the arch changes are pretty minimal and unlikely to conflict much. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42C16C433FE for ; Wed, 9 Feb 2022 05:14:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234668AbiBIFNj (ORCPT ); Wed, 9 Feb 2022 00:13:39 -0500 Received: from gmail-smtp-in.l.google.com ([23.128.96.19]:43416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230197AbiBIEqF (ORCPT ); Tue, 8 Feb 2022 23:46:05 -0500 Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DBB3C061578; Tue, 8 Feb 2022 20:46:09 -0800 (PST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4JtnQ60Fbjz4xNq; Wed, 9 Feb 2022 15:46:06 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1644381966; bh=4LBu3b4sqV42JJCmT2RvLfUf47/jOabbpGeO17DWNxg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=VpsRKjTOAuTL4YVFAXqLwlQNTVN2PnFaRNMaDdmekioS+Axih9wqxwuuZXvgF38GV BtlQrTRz2IAQ9QmpujmvPxeEPJBOCKQODVTttnlXUqTA3LNbZRxgAs7FMDYFW7UAzp hNZMjJnJRRBuEQsm/scDVGFl3F1CnxD/UQBFK7HXqfl2FNQM9xzVfhzm6vaSQz1Oui eoQoylhJFl+fMdpPBEWkx0gW9z1nkkfG9Ee4wjyAlpTXz2FASBp3lrsVq34UIp87iV WiyxUBkfMXtIWN/O5RXzGc5uFFcCQQWtagfWwXYs+Xzz/Ci/ixvZSY69tgrW3wLzm6 VxO4WOGIITJUw== From: Michael Ellerman To: Luis Chamberlain , Michal Suchanek , David Howells , Aaron Tomlin Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org, kexec@lists.infradead.org, Philipp Rudo , Mimi Zohar , Nayna , Rob Herring , linux-s390@vger.kernel.org, Vasily Gorbik , Lakshmi Ramasubramanian , Heiko Carstens , Jessica Yu , linux-kernel@vger.kernel.org, David Howells , Christian Borntraeger , Paul Mackerras , Hari Bathini , Alexander Gordeev , linuxppc-dev@lists.ozlabs.org, Frank van der Linden , Thiago Jung Bauermann , Daniel Axtens , buendgen@de.ibm.com, Benjamin Herrenschmidt , Christian Borntraeger , Herbert Xu , "David S. Miller" , Dmitry Kasatkin , James Morris , "Serge E. Hallyn" , Sven Schnelle , Baoquan He , linux-security-module@vger.kernel.org Subject: Re: [PATCH v5 0/6] KEXEC_SIG with appended signature In-Reply-To: References: Date: Wed, 09 Feb 2022 15:46:05 +1100 Message-ID: <87pmnwlkaa.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: keyrings@vger.kernel.org Luis Chamberlain writes: > On Tue, Jan 11, 2022 at 12:37:42PM +0100, Michal Suchanek wrote: >> Hello, >> >> This is a refresh of the KEXEC_SIG series. >> >> This adds KEXEC_SIG support on powerpc and deduplicates the code dealing >> with appended signatures in the kernel. >> >> powerpc supports IMA_KEXEC but that's an exception rather than the norm. >> On the other hand, KEXEC_SIG is portable across platforms. >> >> For distributions to have uniform security features across platforms one >> option should be used on all platforms. >> >> Thanks >> >> Michal >> >> Previous revision: https://lore.kernel.org/linuxppc-dev/cover.1637862358.git.msuchanek@suse.de/ >> Patched kernel tree: https://github.com/hramrach/kernel/tree/kexec_sig >> >> Michal Suchanek (6): >> s390/kexec_file: Don't opencode appended signature check. >> powerpc/kexec_file: Add KEXEC_SIG support. >> kexec_file: Don't opencode appended signature verification. >> module: strip the signature marker in the verification function. >> module: Use key_being_used_for for log messages in >> verify_appended_signature >> module: Move duplicate mod_check_sig users code to mod_parse_sig > > What tree should this go through? I'd prefer if over through modules > tree as it can give a chance for Aaron Tomlin to work with this for his > code refactoring of kernel/module*.c to kernel/module/ Yeah that's fine by me, the arch changes are pretty minimal and unlikely to conflict much. cheers From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C785C433EF for ; Wed, 9 Feb 2022 04:46:46 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4JtnQs1rpYz3bcF for ; Wed, 9 Feb 2022 15:46:45 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=VpsRKjTO; dkim-atps=neutral Received: from gandalf.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4JtnQB0xBLz2yPL for ; Wed, 9 Feb 2022 15:46:10 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ellerman.id.au header.i=@ellerman.id.au header.a=rsa-sha256 header.s=201909 header.b=VpsRKjTO; dkim-atps=neutral Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4JtnQ60Fbjz4xNq; Wed, 9 Feb 2022 15:46:06 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellerman.id.au; s=201909; t=1644381966; bh=4LBu3b4sqV42JJCmT2RvLfUf47/jOabbpGeO17DWNxg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=VpsRKjTOAuTL4YVFAXqLwlQNTVN2PnFaRNMaDdmekioS+Axih9wqxwuuZXvgF38GV BtlQrTRz2IAQ9QmpujmvPxeEPJBOCKQODVTttnlXUqTA3LNbZRxgAs7FMDYFW7UAzp hNZMjJnJRRBuEQsm/scDVGFl3F1CnxD/UQBFK7HXqfl2FNQM9xzVfhzm6vaSQz1Oui eoQoylhJFl+fMdpPBEWkx0gW9z1nkkfG9Ee4wjyAlpTXz2FASBp3lrsVq34UIp87iV WiyxUBkfMXtIWN/O5RXzGc5uFFcCQQWtagfWwXYs+Xzz/Ci/ixvZSY69tgrW3wLzm6 VxO4WOGIITJUw== From: Michael Ellerman To: Luis Chamberlain , Michal Suchanek , David Howells , Aaron Tomlin Subject: Re: [PATCH v5 0/6] KEXEC_SIG with appended signature In-Reply-To: References: Date: Wed, 09 Feb 2022 15:46:05 +1100 Message-ID: <87pmnwlkaa.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nayna , Mimi Zohar , Sven Schnelle , David Howells , keyrings@vger.kernel.org, Paul Mackerras , Alexander Gordeev , Rob Herring , Herbert Xu , Baoquan He , Christian Borntraeger , James Morris , Lakshmi Ramasubramanian , Christian Borntraeger , "Serge E. Hallyn" , Vasily Gorbik , linux-s390@vger.kernel.org, Heiko Carstens , Dmitry Kasatkin , Hari Bathini , Daniel Axtens , Philipp Rudo , Frank van der Linden , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-crypto@vger.kernel.org, Jessica Yu , linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" , Thiago Jung Bauermann , buendgen@de.ibm.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Luis Chamberlain writes: > On Tue, Jan 11, 2022 at 12:37:42PM +0100, Michal Suchanek wrote: >> Hello, >> >> This is a refresh of the KEXEC_SIG series. >> >> This adds KEXEC_SIG support on powerpc and deduplicates the code dealing >> with appended signatures in the kernel. >> >> powerpc supports IMA_KEXEC but that's an exception rather than the norm. >> On the other hand, KEXEC_SIG is portable across platforms. >> >> For distributions to have uniform security features across platforms one >> option should be used on all platforms. >> >> Thanks >> >> Michal >> >> Previous revision: https://lore.kernel.org/linuxppc-dev/cover.1637862358.git.msuchanek@suse.de/ >> Patched kernel tree: https://github.com/hramrach/kernel/tree/kexec_sig >> >> Michal Suchanek (6): >> s390/kexec_file: Don't opencode appended signature check. >> powerpc/kexec_file: Add KEXEC_SIG support. >> kexec_file: Don't opencode appended signature verification. >> module: strip the signature marker in the verification function. >> module: Use key_being_used_for for log messages in >> verify_appended_signature >> module: Move duplicate mod_check_sig users code to mod_parse_sig > > What tree should this go through? I'd prefer if over through modules > tree as it can give a chance for Aaron Tomlin to work with this for his > code refactoring of kernel/module*.c to kernel/module/ Yeah that's fine by me, the arch changes are pretty minimal and unlikely to conflict much. cheers