From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 1206510E347
 for <igt-dev@lists.freedesktop.org>; Tue,  8 Feb 2022 12:38:18 +0000 (UTC)
Date: Tue, 08 Feb 2022 04:38:17 -0800
Message-ID: <87pmnxfs92.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <YgIhKUWdW8d0ZFb8@zkempczy-mobl2>
References: <20220207183437.205388-1-zbigniew.kempczynski@intel.com>
 <87r18efewq.wl-ashutosh.dixit@intel.com>
 <YgIhKUWdW8d0ZFb8@zkempczy-mobl2>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: quoted-printable
Subject: Re: [igt-dev] [PATCH i-g-t] tests/api_intel_bb: Handle different
 alignments in delta-check
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org
List-ID: <igt-dev@lists.freedesktop.org>

On Mon, 07 Feb 2022 23:52:09 -0800, Zbigniew Kempczy=F1ski wrote:
>
> > Patch is correct. However shouldn't we add gem_detect_safe_alignment() =
to
> > intel_bb_add_object() too? Thanks.
>
> If you mean we should fix intel_bb_add_object() and __intel_bb_create()
> I'm with you.

Correct!

> Currently it works because bb gem object is created within system memory
> and generally both offsets are page aligned. But I agree, we should change
> intel-bb alignment handling.
>
> I'm going to prepare such patch soon but I don't know should I mix this
> with delta-check. Please decide.

Sorry, I meant do this independently of delta-check. Delta-check is already
merged. Thanks.