All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Tomasz Warniełło" <tomasz.warniello@gmail.com>,
	"Jonathan Corbet" <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts: kernel-doc: transform documentation into POD
Date: Mon, 03 Jan 2022 11:04:53 +0200	[thread overview]
Message-ID: <87pmp9tcju.fsf@intel.com> (raw)
In-Reply-To: <0796a780-f5ee-0b6c-e7ef-544ba5f6a429@gmail.com>

On Mon, 03 Jan 2022, Tomasz Warniełło <tomasz.warniello@gmail.com> wrote:
> On 17/12/2021 00:12, Jonathan Corbet wrote:
>>>  my $kernelversion;
>>> @@ -468,7 +306,7 @@ while ($ARGV[0] =~ m/^--?(.*)/) {
>>>      } elsif ($cmd eq "Werror") {
>>>  	$Werror = 1;
>>>      } elsif (($cmd eq "h") || ($cmd eq "help")) {
>>> -	usage();
>>> +			pod2usage(-exitval => 0, -verbose => 2);
>> 
>> Why the strange indentation here?  This file is far from pretty, but
>> that makes it worse.  (Other places too).
>
> Sometimes beauty requires cooperation. You can help it in your pager.
> If it's less, then try `-x 2`, `-x 4`, etc.

In kernel, tabs are 8 characters.

See Documentation/process/coding-style.rst


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center

  reply	other threads:[~2022-01-03  9:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-09 22:55 [PATCH] scripts: kernel-doc: transform documentation into POD Tomasz Warniełło
2021-12-16 23:12 ` Jonathan Corbet
2021-12-17  9:43   ` Jani Nikula
2022-01-03  4:18   ` Tomasz Warniełło
2022-01-03  9:04     ` Jani Nikula [this message]
2022-01-03 17:30       ` Tomasz Warniełło
2022-01-03 20:04         ` Jonathan Corbet
2022-01-03 21:48           ` Tomasz Warniełło
2022-01-03 21:57             ` Jonathan Corbet
2022-01-03 23:56               ` Tomasz Warniełło
2022-01-03 20:40   ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmp9tcju.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomasz.warniello@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.