From: Felipe Balbi <balbi@kernel.org>
To: Andreas Bauer <andreas.bauer.nexus@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: gadget/legacy/ether: assume saner default power mode
Date: Fri, 17 Sep 2021 08:28:16 +0300 [thread overview]
Message-ID: <87pmt7ahtj.fsf@kernel.org> (raw)
In-Reply-To: <YUNbDyoTPa+5J9Od@ws2>
Hi,
Andreas Bauer <andreas.bauer.nexus@gmail.com> writes:
> I propose the included patch to the OTG USB ethernet gadget code:
>
> Report default of bus powered and 500mA bMaxPower consumption.
>
> Reason:
>
> The USB spec requires all devices consuming more than 100mA from
> the bus to report in this manner. Devices such as Rpi Zero can operate
> in this mode and will then falsly report being self-powered when they
> are not.
>
> The more sane default is to report being 500mA bus-powered than being
> self-powered
>
> This patch was born from an issue within the Raspberry Pi Zero ecosystem,
> therefore I would invite comment regarding other usage of this OTG code.
Have a look at other commits to get examples of how to write commits for
upstream. You're missing your Signed-off-by, adding extra unnecessary
spaces and making your signature show up in the commit log. All of
these are described in kernel documentation this
(https://www.kernel.org/doc/html/latest/process/submitting-patches.html)
is a good starting point.
> $ diff -u linux-5.14.2/drivers/usb/gadget/legacy/ether.c.orig linux-5.14.2/drivers/usb/gadget/legacy/ether.c
> --- linux-5.14.2/drivers/usb/gadget/legacy/ether.c.orig 2021-09-08 13:52:41.000000000 +0700
> +++ linux-5.14.2/drivers/usb/gadget/legacy/ether.c 2021-09-16 21:25:06.782958554 +0700
> @@ -296,7 +296,8 @@
> /* .label = f(hardware) */
> .bConfigurationValue = 1,
> /* .iConfiguration = DYNAMIC */
> - .bmAttributes = USB_CONFIG_ATT_SELFPOWER,
> + .bmAttributes = 0, /* bus powered implied */
> + .bMaxPower = 250, /* 500mA in 2mA units */
right, your "sane" default now prevents this gadget driver from working
behind bus powered hubs. Considering that a linux-based device is likely
to have its own battery, this is not really a sane default.
The default value of "self powered", seems much saner ;-)
--
balbi
next prev parent reply other threads:[~2021-09-17 5:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 14:56 [PATCH] usb: gadget/legacy/ether: assume saner default power mode Andreas Bauer
2021-09-16 15:36 ` Greg KH
2021-09-17 5:28 ` Felipe Balbi [this message]
2021-09-17 7:15 ` Andreas Bauer
2021-09-17 8:29 ` Felipe Balbi
2021-09-17 17:12 ` Andreas Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmt7ahtj.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=andreas.bauer.nexus@gmail.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.