From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A2C3C47424 for ; Fri, 4 Jun 2021 16:22:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E94D9613BF for ; Fri, 4 Jun 2021 16:22:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231415AbhFDQYV convert rfc822-to-8bit (ORCPT ); Fri, 4 Jun 2021 12:24:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:42490 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230426AbhFDQYU (ORCPT ); Fri, 4 Jun 2021 12:24:20 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED6A461009; Fri, 4 Jun 2021 16:22:33 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lpCad-005WC5-NQ; Fri, 04 Jun 2021 17:22:32 +0100 Date: Fri, 04 Jun 2021 17:22:30 +0100 Message-ID: <87pmx1zjjt.wl-maz@kernel.org> From: Marc Zyngier To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Lorenzo Pieralisi , Thomas Petazzoni , Rob Herring , Bjorn Helgaas , Russell King , Marek =?UTF-8?B?QmVow7pu?= , Remi Pommarel , Xogium , Tomasz Maciej Nowak , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 17/42] PCI: aardvark: Fix support for MSI interrupts In-Reply-To: <20210604160246.vrix6fngictqpmbg@pali> References: <20210506153153.30454-1-pali@kernel.org> <20210506153153.30454-18-pali@kernel.org> <87czu2q25h.wl-maz@kernel.org> <20210507144420.24aess56cc7ie2x2@pali> <875yzupl52.wl-maz@kernel.org> <20210604160246.vrix6fngictqpmbg@pali> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: pali@kernel.org, lorenzo.pieralisi@arm.com, thomas.petazzoni@bootlin.com, robh@kernel.org, bhelgaas@google.com, rmk+kernel@armlinux.org.uk, kabel@kernel.org, repk@triplefau.lt, contact@xogium.me, tmn505@gmail.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, 04 Jun 2021 17:02:46 +0100, Pali Rohár wrote: > > On Friday 07 May 2021 17:24:25 Marc Zyngier wrote: > > On Fri, 07 May 2021 15:44:20 +0100, > > Pali Rohár wrote: > > > > > > On Friday 07 May 2021 11:16:58 Marc Zyngier wrote: > > > > On Thu, 06 May 2021 16:31:28 +0100, > > > > Pali Rohár wrote: > > > > > > > > > > MSI domain callback .alloc (implemented by advk_msi_irq_domain_alloc() > > > > > function) should return zero on success. Returning non-zero value indicates > > > > > failure. Fix return value of this function as in many cases it now returns > > > > > failure while allocating IRQs. > > > > > > > > > > Aardvark hardware supports Multi-MSI and MSI_FLAG_MULTI_PCI_MSI is already > > > > > set. But when allocating MSI interrupt numbers for Multi-MSI, they need to > > > > > be properly aligned, otherwise endpoint devices send MSI interrupt with > > > > > incorrect numbers. Fix this issue by using function bitmap_find_free_region() > > > > > instead of bitmap_find_next_zero_area(). > > > > > > > > > > To ensure that aligned MSI interrupt numbers are used by endpoint devices, > > > > > we cannot use Linux virtual irq numbers (as they are random and not > > > > > properly aligned). So use hwirq numbers allocated by the function > > > > > bitmap_find_free_region(), which are aligned. This needs an update in > > > > > advk_msi_irq_compose_msi_msg() and advk_pcie_handle_msi() functions to do > > > > > proper mapping between Linux virtual irq numbers and hwirq MSI inner domain > > > > > numbers. > > > > > > > > > > Also the whole 16-bit MSI number is stored in the PCIE_MSI_PAYLOAD_REG > > > > > register, not only lower 8 bits. Fix reading content of this register. > > > > > > > > > > This change fixes receiving MSI interrupts on Armada 3720 boards and allows > > > > > using NVMe disks which use Multi-MSI feature with 3 interrupts. > > > > > > > > > > Without this change, NVMe disks just freeze booting Linux on Armada 3720 > > > > > boards as linux nvme-core.c driver is waiting 60s for an interrupt. > > > > > > > > > > Signed-off-by: Pali Rohár > > > > > Reviewed-by: Marek Behún > > > > > Cc: stable@vger.kernel.org # f21a8b1b6837 ("PCI: aardvark: Move to MSI handling using generic MSI support") > > > > > --- > > > > > drivers/pci/controller/pci-aardvark.c | 32 ++++++++++++++++----------- > > > > > 1 file changed, 19 insertions(+), 13 deletions(-) > > > > > > > > > > diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c > > > > > index 366d7480bc1b..498810c00b6d 100644 > > > > > --- a/drivers/pci/controller/pci-aardvark.c > > > > > +++ b/drivers/pci/controller/pci-aardvark.c > > > > > @@ -118,6 +118,7 @@ > > > > > #define PCIE_MSI_STATUS_REG (CONTROL_BASE_ADDR + 0x58) > > > > > #define PCIE_MSI_MASK_REG (CONTROL_BASE_ADDR + 0x5C) > > > > > #define PCIE_MSI_PAYLOAD_REG (CONTROL_BASE_ADDR + 0x9C) > > > > > +#define PCIE_MSI_DATA_MASK GENMASK(15, 0) > > > > > > > > See my comment below about this addition. > > > > > > > > > /* LMI registers base address and register offsets */ > > > > > #define LMI_BASE_ADDR 0x6000 > > > > > @@ -861,7 +862,7 @@ static void advk_msi_irq_compose_msi_msg(struct irq_data *data, > > > > > > > > > > msg->address_lo = lower_32_bits(msi_msg); > > > > > msg->address_hi = upper_32_bits(msi_msg); > > > > > - msg->data = data->irq; > > > > > + msg->data = data->hwirq; > > > > > } > > > > > > > > > > static int advk_msi_set_affinity(struct irq_data *irq_data, > > > > > @@ -878,15 +879,11 @@ static int advk_msi_irq_domain_alloc(struct irq_domain *domain, > > > > > int hwirq, i; > > > > > > > > > > mutex_lock(&pcie->msi_used_lock); > > > > > - hwirq = bitmap_find_next_zero_area(pcie->msi_used, MSI_IRQ_NUM, > > > > > - 0, nr_irqs, 0); > > > > > - if (hwirq >= MSI_IRQ_NUM) { > > > > > - mutex_unlock(&pcie->msi_used_lock); > > > > > - return -ENOSPC; > > > > > - } > > > > > - > > > > > - bitmap_set(pcie->msi_used, hwirq, nr_irqs); > > > > > + hwirq = bitmap_find_free_region(pcie->msi_used, MSI_IRQ_NUM, > > > > > + order_base_2(nr_irqs)); > > > > > mutex_unlock(&pcie->msi_used_lock); > > > > > + if (hwirq < 0) > > > > > + return -ENOSPC; > > > > > > > > > > for (i = 0; i < nr_irqs; i++) > > > > > irq_domain_set_info(domain, virq + i, hwirq + i, > > > > > @@ -894,7 +891,7 @@ static int advk_msi_irq_domain_alloc(struct irq_domain *domain, > > > > > domain->host_data, handle_simple_irq, > > > > > NULL, NULL); > > > > > > > > > > - return hwirq; > > > > > + return 0; > > > > > } > > > > > > > > > > static void advk_msi_irq_domain_free(struct irq_domain *domain, > > > > > @@ -904,7 +901,7 @@ static void advk_msi_irq_domain_free(struct irq_domain *domain, > > > > > struct advk_pcie *pcie = domain->host_data; > > > > > > > > > > mutex_lock(&pcie->msi_used_lock); > > > > > - bitmap_clear(pcie->msi_used, d->hwirq, nr_irqs); > > > > > + bitmap_release_region(pcie->msi_used, d->hwirq, order_base_2(nr_irqs)); > > > > > mutex_unlock(&pcie->msi_used_lock); > > > > > } > > > > > > > > > > @@ -1048,6 +1045,7 @@ static void advk_pcie_handle_msi(struct advk_pcie *pcie) > > > > > { > > > > > u32 msi_val, msi_mask, msi_status, msi_idx; > > > > > u16 msi_data; > > > > > + int virq; > > > > > > > > > > msi_mask = advk_readl(pcie, PCIE_MSI_MASK_REG); > > > > > msi_val = advk_readl(pcie, PCIE_MSI_STATUS_REG); > > > > > @@ -1057,9 +1055,17 @@ static void advk_pcie_handle_msi(struct advk_pcie *pcie) > > > > > if (!(BIT(msi_idx) & msi_status)) > > > > > continue; > > > > > > > > > > + /* > > > > > + * msi_idx contains bits [4:0] of the msi_data and msi_data > > > > > + * contains 16bit MSI interrupt number from MSI inner domain > > > > > + */ > > > > > advk_writel(pcie, BIT(msi_idx), PCIE_MSI_STATUS_REG); > > > > > - msi_data = advk_readl(pcie, PCIE_MSI_PAYLOAD_REG) & 0xFF; > > > > > - generic_handle_irq(msi_data); > > > > > + msi_data = advk_readl(pcie, PCIE_MSI_PAYLOAD_REG) & PCIE_MSI_DATA_MASK; > > > > > > > > Can this be moved to a separate patch? It seems like this patch should > > > > only focus on correctly dealing with the irq/hwirq issues. > > > > > > Well, hwirq is read from PCIE_MSI_PAYLOAD_REG register and it is 16-bit. > > > That is why I included this change in this patch, to fix also reading > > > IRQ number, not only setting IRQ number. > > > > But this irq number still is a 5 bit quantity at this stage, and the > > Yes, it should be 5 bit number. And in case wrongly programmed PCIe card > sends interrupt with "incorrect number" then A3720 PCIe controller How? This driver is in control of what gets programmed. > "should not try" to map this 16-bit unknown MSI interrupt number to > something in 5-bit domain (by setting upper bits to zero) and trying to > deliver this invalid interrupt via some existing virq. > > Interrupt number of received MSI is stored in low 16 bits in > PCIE_MSI_PAYLOAD_REG register and you should use / validate whole > number, not just few bits from it. Meh. i still maintain that this isn't a logical split for this patch, but at this stage I don't care (my 3720 is in the recycling pile). M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFCE8C47425 for ; Fri, 4 Jun 2021 16:24:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ABB2361009 for ; Fri, 4 Jun 2021 16:24:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABB2361009 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mDrXH2ClBdSyOw2jWWiC9Ulbh4qNsnYNmrXaohNOXU4=; b=ndLdTdMIp79yf+ 53kjDcGVXldEsKOV6ztBVOu9SEVqxGYCM4spN4N6pOBnbxmDjzrdIU5TB8LFpY2M/Mq/3Zq2wyI16 eM+VoP+hIjdN+/VafcMf+/50joH3Ty40By6+RpKUX6F4JwABPmjw80CnmPGoa9wK8LPm2W+g43KXz htmhb5CRJc+d/vl6pl8MxbLRNNrPhEK5BykUkrIqKH0UfdRDWtXR3unDGvP+5/ReHJiLAVS6YN2gZ vM0nn4UVvLEwlzigAUuWuph2khKPnS9BT/B7tPmeDMR1YNed5jwskvJabPnNugShmJEl97aLjM25o OMEdPkGWa+kYeGgfKR2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lpCal-00EKO9-EE; Fri, 04 Jun 2021 16:22:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lpCag-00EKM8-Dh for linux-arm-kernel@lists.infradead.org; Fri, 04 Jun 2021 16:22:36 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED6A461009; Fri, 4 Jun 2021 16:22:33 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1lpCad-005WC5-NQ; Fri, 04 Jun 2021 17:22:32 +0100 Date: Fri, 04 Jun 2021 17:22:30 +0100 Message-ID: <87pmx1zjjt.wl-maz@kernel.org> From: Marc Zyngier To: Pali =?UTF-8?B?Um9ow6Fy?= Cc: Lorenzo Pieralisi , Thomas Petazzoni , Rob Herring , Bjorn Helgaas , Russell King , Marek =?UTF-8?B?QmVow7pu?= , Remi Pommarel , Xogium , Tomasz Maciej Nowak , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 17/42] PCI: aardvark: Fix support for MSI interrupts In-Reply-To: <20210604160246.vrix6fngictqpmbg@pali> References: <20210506153153.30454-1-pali@kernel.org> <20210506153153.30454-18-pali@kernel.org> <87czu2q25h.wl-maz@kernel.org> <20210507144420.24aess56cc7ie2x2@pali> <875yzupl52.wl-maz@kernel.org> <20210604160246.vrix6fngictqpmbg@pali> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: pali@kernel.org, lorenzo.pieralisi@arm.com, thomas.petazzoni@bootlin.com, robh@kernel.org, bhelgaas@google.com, rmk+kernel@armlinux.org.uk, kabel@kernel.org, repk@triplefau.lt, contact@xogium.me, tmn505@gmail.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210604_092234_527082_D062EFC2 X-CRM114-Status: GOOD ( 48.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCAwNCBKdW4gMjAyMSAxNzowMjo0NiArMDEwMCwKUGFsaSBSb2jDoXIgPHBhbGlAa2Vy bmVsLm9yZz4gd3JvdGU6Cj4gCj4gT24gRnJpZGF5IDA3IE1heSAyMDIxIDE3OjI0OjI1IE1hcmMg WnluZ2llciB3cm90ZToKPiA+IE9uIEZyaSwgMDcgTWF5IDIwMjEgMTU6NDQ6MjAgKzAxMDAsCj4g PiBQYWxpIFJvaMOhciA8cGFsaUBrZXJuZWwub3JnPiB3cm90ZToKPiA+ID4gCj4gPiA+IE9uIEZy aWRheSAwNyBNYXkgMjAyMSAxMToxNjo1OCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4gPiA+ID4gT24g VGh1LCAwNiBNYXkgMjAyMSAxNjozMToyOCArMDEwMCwKPiA+ID4gPiBQYWxpIFJvaMOhciA8cGFs aUBrZXJuZWwub3JnPiB3cm90ZToKPiA+ID4gPiA+IAo+ID4gPiA+ID4gTVNJIGRvbWFpbiBjYWxs YmFjayAuYWxsb2MgKGltcGxlbWVudGVkIGJ5IGFkdmtfbXNpX2lycV9kb21haW5fYWxsb2MoKQo+ ID4gPiA+ID4gZnVuY3Rpb24pIHNob3VsZCByZXR1cm4gemVybyBvbiBzdWNjZXNzLiBSZXR1cm5p bmcgbm9uLXplcm8gdmFsdWUgaW5kaWNhdGVzCj4gPiA+ID4gPiBmYWlsdXJlLiBGaXggcmV0dXJu IHZhbHVlIG9mIHRoaXMgZnVuY3Rpb24gYXMgaW4gbWFueSBjYXNlcyBpdCBub3cgcmV0dXJucwo+ ID4gPiA+ID4gZmFpbHVyZSB3aGlsZSBhbGxvY2F0aW5nIElSUXMuCj4gPiA+ID4gPiAKPiA+ID4g PiA+IEFhcmR2YXJrIGhhcmR3YXJlIHN1cHBvcnRzIE11bHRpLU1TSSBhbmQgTVNJX0ZMQUdfTVVM VElfUENJX01TSSBpcyBhbHJlYWR5Cj4gPiA+ID4gPiBzZXQuIEJ1dCB3aGVuIGFsbG9jYXRpbmcg TVNJIGludGVycnVwdCBudW1iZXJzIGZvciBNdWx0aS1NU0ksIHRoZXkgbmVlZCB0bwo+ID4gPiA+ ID4gYmUgcHJvcGVybHkgYWxpZ25lZCwgb3RoZXJ3aXNlIGVuZHBvaW50IGRldmljZXMgc2VuZCBN U0kgaW50ZXJydXB0IHdpdGgKPiA+ID4gPiA+IGluY29ycmVjdCBudW1iZXJzLiBGaXggdGhpcyBp c3N1ZSBieSB1c2luZyBmdW5jdGlvbiBiaXRtYXBfZmluZF9mcmVlX3JlZ2lvbigpCj4gPiA+ID4g PiBpbnN0ZWFkIG9mIGJpdG1hcF9maW5kX25leHRfemVyb19hcmVhKCkuCj4gPiA+ID4gPiAKPiA+ ID4gPiA+IFRvIGVuc3VyZSB0aGF0IGFsaWduZWQgTVNJIGludGVycnVwdCBudW1iZXJzIGFyZSB1 c2VkIGJ5IGVuZHBvaW50IGRldmljZXMsCj4gPiA+ID4gPiB3ZSBjYW5ub3QgdXNlIExpbnV4IHZp cnR1YWwgaXJxIG51bWJlcnMgKGFzIHRoZXkgYXJlIHJhbmRvbSBhbmQgbm90Cj4gPiA+ID4gPiBw cm9wZXJseSBhbGlnbmVkKS4gU28gdXNlIGh3aXJxIG51bWJlcnMgYWxsb2NhdGVkIGJ5IHRoZSBm dW5jdGlvbgo+ID4gPiA+ID4gYml0bWFwX2ZpbmRfZnJlZV9yZWdpb24oKSwgd2hpY2ggYXJlIGFs aWduZWQuIFRoaXMgbmVlZHMgYW4gdXBkYXRlIGluCj4gPiA+ID4gPiBhZHZrX21zaV9pcnFfY29t cG9zZV9tc2lfbXNnKCkgYW5kIGFkdmtfcGNpZV9oYW5kbGVfbXNpKCkgZnVuY3Rpb25zIHRvIGRv Cj4gPiA+ID4gPiBwcm9wZXIgbWFwcGluZyBiZXR3ZWVuIExpbnV4IHZpcnR1YWwgaXJxIG51bWJl cnMgYW5kIGh3aXJxIE1TSSBpbm5lciBkb21haW4KPiA+ID4gPiA+IG51bWJlcnMuCj4gPiA+ID4g PiAKPiA+ID4gPiA+IEFsc28gdGhlIHdob2xlIDE2LWJpdCBNU0kgbnVtYmVyIGlzIHN0b3JlZCBp biB0aGUgUENJRV9NU0lfUEFZTE9BRF9SRUcKPiA+ID4gPiA+IHJlZ2lzdGVyLCBub3Qgb25seSBs b3dlciA4IGJpdHMuIEZpeCByZWFkaW5nIGNvbnRlbnQgb2YgdGhpcyByZWdpc3Rlci4KPiA+ID4g PiA+IAo+ID4gPiA+ID4gVGhpcyBjaGFuZ2UgZml4ZXMgcmVjZWl2aW5nIE1TSSBpbnRlcnJ1cHRz IG9uIEFybWFkYSAzNzIwIGJvYXJkcyBhbmQgYWxsb3dzCj4gPiA+ID4gPiB1c2luZyBOVk1lIGRp c2tzIHdoaWNoIHVzZSBNdWx0aS1NU0kgZmVhdHVyZSB3aXRoIDMgaW50ZXJydXB0cy4KPiA+ID4g PiA+IAo+ID4gPiA+ID4gV2l0aG91dCB0aGlzIGNoYW5nZSwgTlZNZSBkaXNrcyBqdXN0IGZyZWV6 ZSBib290aW5nIExpbnV4IG9uIEFybWFkYSAzNzIwCj4gPiA+ID4gPiBib2FyZHMgYXMgbGludXgg bnZtZS1jb3JlLmMgZHJpdmVyIGlzIHdhaXRpbmcgNjBzIGZvciBhbiBpbnRlcnJ1cHQuCj4gPiA+ ID4gPiAKPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IFBhbGkgUm9ow6FyIDxwYWxpQGtlcm5lbC5v cmc+Cj4gPiA+ID4gPiBSZXZpZXdlZC1ieTogTWFyZWsgQmVow7puIDxrYWJlbEBrZXJuZWwub3Jn Pgo+ID4gPiA+ID4gQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcgIyBmMjFhOGIxYjY4MzcgKCJQ Q0k6IGFhcmR2YXJrOiBNb3ZlIHRvIE1TSSBoYW5kbGluZyB1c2luZyBnZW5lcmljIE1TSSBzdXBw b3J0IikKPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gIGRyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNp LWFhcmR2YXJrLmMgfCAzMiArKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0KPiA+ID4gPiA+ICAx IGZpbGUgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4gPiA+ID4g PiAKPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS1hYXJk dmFyay5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2ktYWFyZHZhcmsuYwo+ID4gPiA+ID4g aW5kZXggMzY2ZDc0ODBiYzFiLi40OTg4MTBjMDBiNmQgMTAwNjQ0Cj4gPiA+ID4gPiAtLS0gYS9k cml2ZXJzL3BjaS9jb250cm9sbGVyL3BjaS1hYXJkdmFyay5jCj4gPiA+ID4gPiArKysgYi9kcml2 ZXJzL3BjaS9jb250cm9sbGVyL3BjaS1hYXJkdmFyay5jCj4gPiA+ID4gPiBAQCAtMTE4LDYgKzEx OCw3IEBACj4gPiA+ID4gPiAgI2RlZmluZSBQQ0lFX01TSV9TVEFUVVNfUkVHCQkJKENPTlRST0xf QkFTRV9BRERSICsgMHg1OCkKPiA+ID4gPiA+ICAjZGVmaW5lIFBDSUVfTVNJX01BU0tfUkVHCQkJ KENPTlRST0xfQkFTRV9BRERSICsgMHg1QykKPiA+ID4gPiA+ICAjZGVmaW5lIFBDSUVfTVNJX1BB WUxPQURfUkVHCQkJKENPTlRST0xfQkFTRV9BRERSICsgMHg5QykKPiA+ID4gPiA+ICsjZGVmaW5l ICAgICBQQ0lFX01TSV9EQVRBX01BU0sJCQlHRU5NQVNLKDE1LCAwKQo+ID4gPiA+IAo+ID4gPiA+ IFNlZSBteSBjb21tZW50IGJlbG93IGFib3V0IHRoaXMgYWRkaXRpb24uCj4gPiA+ID4gCj4gPiA+ ID4gPiAgLyogTE1JIHJlZ2lzdGVycyBiYXNlIGFkZHJlc3MgYW5kIHJlZ2lzdGVyIG9mZnNldHMg Ki8KPiA+ID4gPiA+ICAjZGVmaW5lIExNSV9CQVNFX0FERFIJCQkJMHg2MDAwCj4gPiA+ID4gPiBA QCAtODYxLDcgKzg2Miw3IEBAIHN0YXRpYyB2b2lkIGFkdmtfbXNpX2lycV9jb21wb3NlX21zaV9t c2coc3RydWN0IGlycV9kYXRhICpkYXRhLAo+ID4gPiA+ID4gIAo+ID4gPiA+ID4gIAltc2ctPmFk ZHJlc3NfbG8gPSBsb3dlcl8zMl9iaXRzKG1zaV9tc2cpOwo+ID4gPiA+ID4gIAltc2ctPmFkZHJl c3NfaGkgPSB1cHBlcl8zMl9iaXRzKG1zaV9tc2cpOwo+ID4gPiA+ID4gLQltc2ctPmRhdGEgPSBk YXRhLT5pcnE7Cj4gPiA+ID4gPiArCW1zZy0+ZGF0YSA9IGRhdGEtPmh3aXJxOwo+ID4gPiA+ID4g IH0KPiA+ID4gPiA+ICAKPiA+ID4gPiA+ICBzdGF0aWMgaW50IGFkdmtfbXNpX3NldF9hZmZpbml0 eShzdHJ1Y3QgaXJxX2RhdGEgKmlycV9kYXRhLAo+ID4gPiA+ID4gQEAgLTg3OCwxNSArODc5LDEx IEBAIHN0YXRpYyBpbnQgYWR2a19tc2lfaXJxX2RvbWFpbl9hbGxvYyhzdHJ1Y3QgaXJxX2RvbWFp biAqZG9tYWluLAo+ID4gPiA+ID4gIAlpbnQgaHdpcnEsIGk7Cj4gPiA+ID4gPiAgCj4gPiA+ID4g PiAgCW11dGV4X2xvY2soJnBjaWUtPm1zaV91c2VkX2xvY2spOwo+ID4gPiA+ID4gLQlod2lycSA9 IGJpdG1hcF9maW5kX25leHRfemVyb19hcmVhKHBjaWUtPm1zaV91c2VkLCBNU0lfSVJRX05VTSwK PiA+ID4gPiA+IC0JCQkJCSAgIDAsIG5yX2lycXMsIDApOwo+ID4gPiA+ID4gLQlpZiAoaHdpcnEg Pj0gTVNJX0lSUV9OVU0pIHsKPiA+ID4gPiA+IC0JCW11dGV4X3VubG9jaygmcGNpZS0+bXNpX3Vz ZWRfbG9jayk7Cj4gPiA+ID4gPiAtCQlyZXR1cm4gLUVOT1NQQzsKPiA+ID4gPiA+IC0JfQo+ID4g PiA+ID4gLQo+ID4gPiA+ID4gLQliaXRtYXBfc2V0KHBjaWUtPm1zaV91c2VkLCBod2lycSwgbnJf aXJxcyk7Cj4gPiA+ID4gPiArCWh3aXJxID0gYml0bWFwX2ZpbmRfZnJlZV9yZWdpb24ocGNpZS0+ bXNpX3VzZWQsIE1TSV9JUlFfTlVNLAo+ID4gPiA+ID4gKwkJCQkJb3JkZXJfYmFzZV8yKG5yX2ly cXMpKTsKPiA+ID4gPiA+ICAJbXV0ZXhfdW5sb2NrKCZwY2llLT5tc2lfdXNlZF9sb2NrKTsKPiA+ ID4gPiA+ICsJaWYgKGh3aXJxIDwgMCkKPiA+ID4gPiA+ICsJCXJldHVybiAtRU5PU1BDOwo+ID4g PiA+ID4gIAo+ID4gPiA+ID4gIAlmb3IgKGkgPSAwOyBpIDwgbnJfaXJxczsgaSsrKQo+ID4gPiA+ ID4gIAkJaXJxX2RvbWFpbl9zZXRfaW5mbyhkb21haW4sIHZpcnEgKyBpLCBod2lycSArIGksCj4g PiA+ID4gPiBAQCAtODk0LDcgKzg5MSw3IEBAIHN0YXRpYyBpbnQgYWR2a19tc2lfaXJxX2RvbWFp bl9hbGxvYyhzdHJ1Y3QgaXJxX2RvbWFpbiAqZG9tYWluLAo+ID4gPiA+ID4gIAkJCQkgICAgZG9t YWluLT5ob3N0X2RhdGEsIGhhbmRsZV9zaW1wbGVfaXJxLAo+ID4gPiA+ID4gIAkJCQkgICAgTlVM TCwgTlVMTCk7Cj4gPiA+ID4gPiAgCj4gPiA+ID4gPiAtCXJldHVybiBod2lycTsKPiA+ID4gPiA+ ICsJcmV0dXJuIDA7Cj4gPiA+ID4gPiAgfQo+ID4gPiA+ID4gIAo+ID4gPiA+ID4gIHN0YXRpYyB2 b2lkIGFkdmtfbXNpX2lycV9kb21haW5fZnJlZShzdHJ1Y3QgaXJxX2RvbWFpbiAqZG9tYWluLAo+ ID4gPiA+ID4gQEAgLTkwNCw3ICs5MDEsNyBAQCBzdGF0aWMgdm9pZCBhZHZrX21zaV9pcnFfZG9t YWluX2ZyZWUoc3RydWN0IGlycV9kb21haW4gKmRvbWFpbiwKPiA+ID4gPiA+ICAJc3RydWN0IGFk dmtfcGNpZSAqcGNpZSA9IGRvbWFpbi0+aG9zdF9kYXRhOwo+ID4gPiA+ID4gIAo+ID4gPiA+ID4g IAltdXRleF9sb2NrKCZwY2llLT5tc2lfdXNlZF9sb2NrKTsKPiA+ID4gPiA+IC0JYml0bWFwX2Ns ZWFyKHBjaWUtPm1zaV91c2VkLCBkLT5od2lycSwgbnJfaXJxcyk7Cj4gPiA+ID4gPiArCWJpdG1h cF9yZWxlYXNlX3JlZ2lvbihwY2llLT5tc2lfdXNlZCwgZC0+aHdpcnEsIG9yZGVyX2Jhc2VfMihu cl9pcnFzKSk7Cj4gPiA+ID4gPiAgCW11dGV4X3VubG9jaygmcGNpZS0+bXNpX3VzZWRfbG9jayk7 Cj4gPiA+ID4gPiAgfQo+ID4gPiA+ID4gIAo+ID4gPiA+ID4gQEAgLTEwNDgsNiArMTA0NSw3IEBA IHN0YXRpYyB2b2lkIGFkdmtfcGNpZV9oYW5kbGVfbXNpKHN0cnVjdCBhZHZrX3BjaWUgKnBjaWUp Cj4gPiA+ID4gPiAgewo+ID4gPiA+ID4gIAl1MzIgbXNpX3ZhbCwgbXNpX21hc2ssIG1zaV9zdGF0 dXMsIG1zaV9pZHg7Cj4gPiA+ID4gPiAgCXUxNiBtc2lfZGF0YTsKPiA+ID4gPiA+ICsJaW50IHZp cnE7Cj4gPiA+ID4gPiAgCj4gPiA+ID4gPiAgCW1zaV9tYXNrID0gYWR2a19yZWFkbChwY2llLCBQ Q0lFX01TSV9NQVNLX1JFRyk7Cj4gPiA+ID4gPiAgCW1zaV92YWwgPSBhZHZrX3JlYWRsKHBjaWUs IFBDSUVfTVNJX1NUQVRVU19SRUcpOwo+ID4gPiA+ID4gQEAgLTEwNTcsOSArMTA1NSwxNyBAQCBz dGF0aWMgdm9pZCBhZHZrX3BjaWVfaGFuZGxlX21zaShzdHJ1Y3QgYWR2a19wY2llICpwY2llKQo+ ID4gPiA+ID4gIAkJaWYgKCEoQklUKG1zaV9pZHgpICYgbXNpX3N0YXR1cykpCj4gPiA+ID4gPiAg CQkJY29udGludWU7Cj4gPiA+ID4gPiAgCj4gPiA+ID4gPiArCQkvKgo+ID4gPiA+ID4gKwkJICog bXNpX2lkeCBjb250YWlucyBiaXRzIFs0OjBdIG9mIHRoZSBtc2lfZGF0YSBhbmQgbXNpX2RhdGEK PiA+ID4gPiA+ICsJCSAqIGNvbnRhaW5zIDE2Yml0IE1TSSBpbnRlcnJ1cHQgbnVtYmVyIGZyb20g TVNJIGlubmVyIGRvbWFpbgo+ID4gPiA+ID4gKwkJICovCj4gPiA+ID4gPiAgCQlhZHZrX3dyaXRl bChwY2llLCBCSVQobXNpX2lkeCksIFBDSUVfTVNJX1NUQVRVU19SRUcpOwo+ID4gPiA+ID4gLQkJ bXNpX2RhdGEgPSBhZHZrX3JlYWRsKHBjaWUsIFBDSUVfTVNJX1BBWUxPQURfUkVHKSAmIDB4RkY7 Cj4gPiA+ID4gPiAtCQlnZW5lcmljX2hhbmRsZV9pcnEobXNpX2RhdGEpOwo+ID4gPiA+ID4gKwkJ bXNpX2RhdGEgPSBhZHZrX3JlYWRsKHBjaWUsIFBDSUVfTVNJX1BBWUxPQURfUkVHKSAmIFBDSUVf TVNJX0RBVEFfTUFTSzsKPiA+ID4gPiAKPiA+ID4gPiBDYW4gdGhpcyBiZSBtb3ZlZCB0byBhIHNl cGFyYXRlIHBhdGNoPyBJdCBzZWVtcyBsaWtlIHRoaXMgcGF0Y2ggc2hvdWxkCj4gPiA+ID4gb25s eSBmb2N1cyBvbiBjb3JyZWN0bHkgZGVhbGluZyB3aXRoIHRoZSBpcnEvaHdpcnEgaXNzdWVzLgo+ ID4gPiAKPiA+ID4gV2VsbCwgaHdpcnEgaXMgcmVhZCBmcm9tIFBDSUVfTVNJX1BBWUxPQURfUkVH IHJlZ2lzdGVyIGFuZCBpdCBpcyAxNi1iaXQuCj4gPiA+IFRoYXQgaXMgd2h5IEkgaW5jbHVkZWQg dGhpcyBjaGFuZ2UgaW4gdGhpcyBwYXRjaCwgdG8gZml4IGFsc28gcmVhZGluZwo+ID4gPiBJUlEg bnVtYmVyLCBub3Qgb25seSBzZXR0aW5nIElSUSBudW1iZXIuCj4gPiAKPiA+IEJ1dCB0aGlzIGly cSBudW1iZXIgc3RpbGwgaXMgYSA1IGJpdCBxdWFudGl0eSBhdCB0aGlzIHN0YWdlLCBhbmQgdGhl Cj4gCj4gWWVzLCBpdCBzaG91bGQgYmUgNSBiaXQgbnVtYmVyLiBBbmQgaW4gY2FzZSB3cm9uZ2x5 IHByb2dyYW1tZWQgUENJZSBjYXJkCj4gc2VuZHMgaW50ZXJydXB0IHdpdGggImluY29ycmVjdCBu dW1iZXIiIHRoZW4gQTM3MjAgUENJZSBjb250cm9sbGVyCgpIb3c/IFRoaXMgZHJpdmVyIGlzIGlu IGNvbnRyb2wgb2Ygd2hhdCBnZXRzIHByb2dyYW1tZWQuCgo+ICJzaG91bGQgbm90IHRyeSIgdG8g bWFwIHRoaXMgMTYtYml0IHVua25vd24gTVNJIGludGVycnVwdCBudW1iZXIgdG8KPiBzb21ldGhp bmcgaW4gNS1iaXQgZG9tYWluIChieSBzZXR0aW5nIHVwcGVyIGJpdHMgdG8gemVybykgYW5kIHRy eWluZyB0bwo+IGRlbGl2ZXIgdGhpcyBpbnZhbGlkIGludGVycnVwdCB2aWEgc29tZSBleGlzdGlu ZyB2aXJxLgo+IAo+IEludGVycnVwdCBudW1iZXIgb2YgcmVjZWl2ZWQgTVNJIGlzIHN0b3JlZCBp biBsb3cgMTYgYml0cyBpbgo+IFBDSUVfTVNJX1BBWUxPQURfUkVHIHJlZ2lzdGVyIGFuZCB5b3Ug c2hvdWxkIHVzZSAvIHZhbGlkYXRlIHdob2xlCj4gbnVtYmVyLCBub3QganVzdCBmZXcgYml0cyBm cm9tIGl0LgoKTWVoLiBpIHN0aWxsIG1haW50YWluIHRoYXQgdGhpcyBpc24ndCBhIGxvZ2ljYWwg c3BsaXQgZm9yIHRoaXMgcGF0Y2gsCmJ1dCBhdCB0aGlzIHN0YWdlIEkgZG9uJ3QgY2FyZSAobXkg MzcyMCBpcyBpbiB0aGUgcmVjeWNsaW5nIHBpbGUpLgoKCU0uCgotLSAKV2l0aG91dCBkZXZpYXRp b24gZnJvbSB0aGUgbm9ybSwgcHJvZ3Jlc3MgaXMgbm90IHBvc3NpYmxlLgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=