From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2080C433DB for ; Mon, 29 Mar 2021 15:00:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AC5D61964 for ; Mon, 29 Mar 2021 15:00:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229762AbhC2PAA convert rfc822-to-8bit (ORCPT ); Mon, 29 Mar 2021 11:00:00 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:51187 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230213AbhC2O7l (ORCPT ); Mon, 29 Mar 2021 10:59:41 -0400 X-Originating-IP: 91.175.115.186 Received: from localhost (91-175-115-186.subs.proxad.net [91.175.115.186]) (Authenticated sender: gregory.clement@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 01760E000D; Mon, 29 Mar 2021 14:59:35 +0000 (UTC) From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Andrew Lunn , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Marek =?utf-8?Q?Beh=C3=BAn?= , Miquel Raynal , Tomasz Maciej Nowak , Luka Perkov , Andre Heider , Vladimir Vid , Russell King , =?utf-8?Q?G=C3=A9rald?= Kerma , Konstantin Porotchkin Subject: Re: [PATCH mvebu v3 08/10] cpufreq: armada-37xx: Fix determining base CPU frequency In-Reply-To: <20210222194158.12342-9-pali@kernel.org> References: <20210114124032.12765-1-pali@kernel.org> <20210222194158.12342-1-pali@kernel.org> <20210222194158.12342-9-pali@kernel.org> Date: Mon, 29 Mar 2021 16:59:35 +0200 Message-ID: <87pmzidmzs.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Pali Rohár writes: > When current CPU load is not L0 then loading armada-37xx-cpufreq.ko driver > fails with following error: > > # modprobe armada-37xx-cpufreq > [ 502.702097] Unsupported CPU frequency 250 MHz > > This issue was partially fixed by commit 8db82563451f ("cpufreq: > armada-37xx: fix frequency calculation for opp"), but only for calculating > CPU frequency for opp. > > Fix this also for determination of base CPU frequency. > > Signed-off-by: Pali Rohár > Tested-by: Tomasz Maciej Nowak > Tested-by: Anders Trier Olesen > Tested-by: Philip Soares > Fixes: 92ce45fb875d ("cpufreq: Add DVFS support for Armada 37xx") > Cc: stable@vger.kernel.org # 8db82563451f ("cpufreq: armada-37xx: fix > frequency calculation for opp") Acked-by: Gregory CLEMENT Thanks, Gregory > --- > drivers/cpufreq/armada-37xx-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/armada-37xx-cpufreq.c b/drivers/cpufreq/armada-37xx-cpufreq.c > index 1ab2113daef5..e4782f562e7a 100644 > --- a/drivers/cpufreq/armada-37xx-cpufreq.c > +++ b/drivers/cpufreq/armada-37xx-cpufreq.c > @@ -469,7 +469,7 @@ static int __init armada37xx_cpufreq_driver_init(void) > return -EINVAL; > } > > - dvfs = armada_37xx_cpu_freq_info_get(cur_frequency); > + dvfs = armada_37xx_cpu_freq_info_get(base_frequency); > if (!dvfs) { > clk_put(clk); > return -EINVAL; > -- > 2.20.1 > -- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56EDEC433C1 for ; Mon, 29 Mar 2021 23:01:48 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2ACB61989 for ; Mon, 29 Mar 2021 23:01:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2ACB61989 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+C+EBUlSHnlLIoHl6flawHs9gTNB+4q00tQcK5yZs9w=; b=gXtslAo6048XgDZ1UfLaiiDtx EzbCQt4yBbg6/QYZtPBNUmWRI0zrtPsqJXir3z4btKuwGf6+0rE5ycx/DTMP7ELq5Nmw1JyttS0kk zb3Ne7Z0pP/cVBUpB8FBMp/XbL4wot7icLgdF6NCftBD89r4uPpTbGfgbpAckUVTL4FbkjE6wJ/1U jI/JUPh060DiXaCQlG5ClCzaBCbubeUW6XYm3an9lktSqBQt5/x+x8GC+0TwKTWW9/3PCdAcN/DbW dbmYLSOS2CcVYcpy5dC42BNo91snROyGZ0w6GCd7z9+nV4z0iOMrKyyW9SjFdmGAp+FDgbnAkmNJp tKb5yoF3A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lR0qP-001nmt-De; Mon, 29 Mar 2021 22:58:50 +0000 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lQtMk-000ivX-BM for linux-arm-kernel@lists.infradead.org; Mon, 29 Mar 2021 15:00:02 +0000 X-Originating-IP: 91.175.115.186 Received: from localhost (91-175-115-186.subs.proxad.net [91.175.115.186]) (Authenticated sender: gregory.clement@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 01760E000D; Mon, 29 Mar 2021 14:59:35 +0000 (UTC) From: Gregory CLEMENT To: Pali =?utf-8?Q?Roh=C3=A1r?= , Andrew Lunn , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Cc: Marek =?utf-8?Q?Beh=C3=BAn?= , Miquel Raynal , Tomasz Maciej Nowak , Luka Perkov , Andre Heider , Vladimir Vid , Russell King , =?utf-8?Q?G=C3=A9rald?= Kerma , Konstantin Porotchkin Subject: Re: [PATCH mvebu v3 08/10] cpufreq: armada-37xx: Fix determining base CPU frequency In-Reply-To: <20210222194158.12342-9-pali@kernel.org> References: <20210114124032.12765-1-pali@kernel.org> <20210222194158.12342-1-pali@kernel.org> <20210222194158.12342-9-pali@kernel.org> Date: Mon, 29 Mar 2021 16:59:35 +0200 Message-ID: <87pmzidmzs.fsf@BL-laptop> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210329_160000_854804_24FAD955 X-CRM114-Status: GOOD ( 15.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org UGFsaSBSb2jDoXIgPHBhbGlAa2VybmVsLm9yZz4gd3JpdGVzOgoKPiBXaGVuIGN1cnJlbnQgQ1BV IGxvYWQgaXMgbm90IEwwIHRoZW4gbG9hZGluZyBhcm1hZGEtMzd4eC1jcHVmcmVxLmtvIGRyaXZl cgo+IGZhaWxzIHdpdGggZm9sbG93aW5nIGVycm9yOgo+Cj4gICAgICMgbW9kcHJvYmUgYXJtYWRh LTM3eHgtY3B1ZnJlcQo+ICAgICBbICA1MDIuNzAyMDk3XSBVbnN1cHBvcnRlZCBDUFUgZnJlcXVl bmN5IDI1MCBNSHoKPgo+IFRoaXMgaXNzdWUgd2FzIHBhcnRpYWxseSBmaXhlZCBieSBjb21taXQg OGRiODI1NjM0NTFmICgiY3B1ZnJlcToKPiBhcm1hZGEtMzd4eDogZml4IGZyZXF1ZW5jeSBjYWxj dWxhdGlvbiBmb3Igb3BwIiksIGJ1dCBvbmx5IGZvciBjYWxjdWxhdGluZwo+IENQVSBmcmVxdWVu Y3kgZm9yIG9wcC4KPgo+IEZpeCB0aGlzIGFsc28gZm9yIGRldGVybWluYXRpb24gb2YgYmFzZSBD UFUgZnJlcXVlbmN5Lgo+Cj4gU2lnbmVkLW9mZi1ieTogUGFsaSBSb2jDoXIgPHBhbGlAa2VybmVs Lm9yZz4KPiBUZXN0ZWQtYnk6IFRvbWFzeiBNYWNpZWogTm93YWsgPHRtbjUwNUBnbWFpbC5jb20+ Cj4gVGVzdGVkLWJ5OiBBbmRlcnMgVHJpZXIgT2xlc2VuIDxhbmRlcnMudHJpZXIub2xlc2VuQGdt YWlsLmNvbT4KPiBUZXN0ZWQtYnk6IFBoaWxpcCBTb2FyZXMgPHBoaWxpcHNAbmV0aXNlbnNlLmNv bT4KPiBGaXhlczogOTJjZTQ1ZmI4NzVkICgiY3B1ZnJlcTogQWRkIERWRlMgc3VwcG9ydCBmb3Ig QXJtYWRhIDM3eHgiKQo+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnICMgOGRiODI1NjM0NTFm ICgiY3B1ZnJlcTogYXJtYWRhLTM3eHg6IGZpeAo+IGZyZXF1ZW5jeSBjYWxjdWxhdGlvbiBmb3Ig b3BwIikKCkFja2VkLWJ5OiBHcmVnb3J5IENMRU1FTlQgPGdyZWdvcnkuY2xlbWVudEBib290bGlu LmNvbT4KClRoYW5rcywKCkdyZWdvcnkKCj4gLS0tCj4gIGRyaXZlcnMvY3B1ZnJlcS9hcm1hZGEt Mzd4eC1jcHVmcmVxLmMgfCAyICstCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwg MSBkZWxldGlvbigtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvY3B1ZnJlcS9hcm1hZGEtMzd4 eC1jcHVmcmVxLmMgYi9kcml2ZXJzL2NwdWZyZXEvYXJtYWRhLTM3eHgtY3B1ZnJlcS5jCj4gaW5k ZXggMWFiMjExM2RhZWY1Li5lNDc4MmY1NjJlN2EgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9jcHVm cmVxL2FybWFkYS0zN3h4LWNwdWZyZXEuYwo+ICsrKyBiL2RyaXZlcnMvY3B1ZnJlcS9hcm1hZGEt Mzd4eC1jcHVmcmVxLmMKPiBAQCAtNDY5LDcgKzQ2OSw3IEBAIHN0YXRpYyBpbnQgX19pbml0IGFy bWFkYTM3eHhfY3B1ZnJlcV9kcml2ZXJfaW5pdCh2b2lkKQo+ICAJCXJldHVybiAtRUlOVkFMOwo+ ICAJfQo+ICAKPiAtCWR2ZnMgPSBhcm1hZGFfMzd4eF9jcHVfZnJlcV9pbmZvX2dldChjdXJfZnJl cXVlbmN5KTsKPiArCWR2ZnMgPSBhcm1hZGFfMzd4eF9jcHVfZnJlcV9pbmZvX2dldChiYXNlX2Zy ZXF1ZW5jeSk7Cj4gIAlpZiAoIWR2ZnMpIHsKPiAgCQljbGtfcHV0KGNsayk7Cj4gIAkJcmV0dXJu IC1FSU5WQUw7Cj4gLS0gCj4gMi4yMC4xCj4KCi0tIApHcmVnb3J5IENsZW1lbnQsIEJvb3RsaW4K RW1iZWRkZWQgTGludXggYW5kIEtlcm5lbCBlbmdpbmVlcmluZwpodHRwOi8vYm9vdGxpbi5jb20K Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFy bS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r ZXJuZWwK