All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paulo Alcantara <pc@cjr.nz>
To: Steve French <smfrench@gmail.com>
Cc: "Aurélien Aptel" <aaptel@suse.com>, CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH] cifs: allow syscalls to be restarted in __smb_send_rqst()
Date: Mon, 30 Nov 2020 13:34:09 -0300	[thread overview]
Message-ID: <87pn3uhkhq.fsf@cjr.nz> (raw)
In-Reply-To: <CAH2r5msicAhu-NDzf+JxghVEj8dBRrDnMjGEKkE-DbrW=Dm64A@mail.gmail.com>

Steve French <smfrench@gmail.com> writes:

> On Mon, Nov 30, 2020 at 7:02 AM Paulo Alcantara <pc@cjr.nz> wrote:
>>
>> Aurélien Aptel <aaptel@suse.com> writes:
>>
>> > Paulo Alcantara <pc@cjr.nz> writes:
>> >> diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c
>> >> index e27e255d40dd..55853b9ed13d 100644
>> >> --- a/fs/cifs/transport.c
>> >> +++ b/fs/cifs/transport.c
>> >> @@ -338,10 +338,8 @@ __smb_send_rqst(struct TCP_Server_Info *server, int num_rqst,
>> >>      if (ssocket == NULL)
>> >>              return -EAGAIN;
>> >>
>> >> -    if (signal_pending(current)) {
>> >> -            cifs_dbg(FYI, "signal is pending before sending any data\n");
>> >> -            return -EINTR;
>> >> -    }
>> >> +    if (signal_pending(current))
>> >> +            return -ERESTARTSYS;
>> >
>> > Can we keep the debug message call?
>>
>> Yes.
>>
>> Steve, could you please update for-next with above debug msg?
>
> Done. Please check to see if my lightly modified debug message text is ok.

OK for me.  Thanks!

  reply	other threads:[~2020-11-30 16:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-28 18:57 [PATCH] cifs: allow syscalls to be restarted in __smb_send_rqst() Paulo Alcantara
     [not found] ` <CAH2r5msFYUB7RmWjCxQH8s8Amz4eET8_u8V5qZq3KMhdRFDPrA@mail.gmail.com>
2020-11-29 16:40   ` Paulo Alcantara
2020-11-30 10:29 ` Aurélien Aptel
2020-11-30 13:02   ` Paulo Alcantara
2020-11-30 16:24     ` Steve French
2020-11-30 16:34       ` Paulo Alcantara [this message]
2020-11-30 20:11         ` Pavel Shilovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pn3uhkhq.fsf@cjr.nz \
    --to=pc@cjr.nz \
    --cc=aaptel@suse.com \
    --cc=linux-cifs@vger.kernel.org \
    --cc=smfrench@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.