All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: Anton Ivanov <anton.ivanov@cambridgegreys.com>
Cc: Martyn Welch <martyn@collabora.com>,
	richard@nod.at, jdike@addtoit.com, linux-um@lists.infradead.org,
	kernel@collabora.com,
	Christopher Obbard <chris.obbard@collabora.com>
Subject: Re: [PATCH] um: ubd: Submit all data segments atomically
Date: Wed, 18 Nov 2020 16:19:11 -0500	[thread overview]
Message-ID: <87pn4atlbk.fsf@collabora.com> (raw)
In-Reply-To: <7c1bf8c3-0e80-ab90-778c-c124fab3f747@cambridgegreys.com> (Anton Ivanov's message of "Mon, 26 Oct 2020 09:25:51 +0000")

Anton Ivanov <anton.ivanov@cambridgegreys.com> writes:

> On 25/10/2020 04:41, Gabriel Krisman Bertazi wrote:
>> Internally, UBD treats each physical IO segment as a separate command to
>> be submitted in the execution pipe.  If the pipe returns a transient
>> error after a few segments have already been written, UBD will tell the
>> block layer to requeue the request, but there is no way to reclaim the
>> segments already submitted.  When a new attempt to dispatch the request
>> is done, those segments already submitted will get duplicated, causing
>> the WARN_ON below in the best case, and potentially data corruption.
>> In my system, running a UML instance with 2GB of RAM and a 50M UBD
>> disk,

>>   [...]
>> ---[ end trace c6e7444e55386c0f ]---
>> Cc: Christopher Obbard <chris.obbard@collabora.com>
>> Reported-by: Martyn Welch <martyn@collabora.com>
>> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>

> Acked-By: Anton Ivanov <anton.ivanov@cambridgegreys.com>

Hi,

Is this queued somewhere?  I've been watching the linux-next branch of
rw's tree.  Is that the right tree?

Thanks,

-- 
Gabriel Krisman Bertazi

_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um


  reply	other threads:[~2020-11-18 21:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-25  4:41 [PATCH] um: ubd: Submit all data segments atomically Gabriel Krisman Bertazi
2020-10-26  9:25 ` Anton Ivanov
2020-11-18 21:19   ` Gabriel Krisman Bertazi [this message]
2020-11-18 21:46     ` Richard Weinberger
2020-11-22  4:09       ` Gabriel Krisman Bertazi
2020-10-26 11:52 ` Christopher Obbard
2020-11-18 21:45 ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pn4atlbk.fsf@collabora.com \
    --to=krisman@collabora.com \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=chris.obbard@collabora.com \
    --cc=jdike@addtoit.com \
    --cc=kernel@collabora.com \
    --cc=linux-um@lists.infradead.org \
    --cc=martyn@collabora.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.