From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2345C43461 for ; Wed, 16 Sep 2020 08:44:13 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53C4020872 for ; Wed, 16 Sep 2020 08:44:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="K0D4pfNX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53C4020872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIT2y-0005cp-FR for qemu-devel@archiver.kernel.org; Wed, 16 Sep 2020 04:44:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34762) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIT17-0003aO-Bn for qemu-devel@nongnu.org; Wed, 16 Sep 2020 04:42:17 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:37394 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kIT15-0007i0-DH for qemu-devel@nongnu.org; Wed, 16 Sep 2020 04:42:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600245734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iEGnnxh2tj4IV0jT81CDMn3Rywk7wQE7oULSHdffsgI=; b=K0D4pfNXtyJm/SegdtKNn2U8IO5/hC5Cip9h9u1xSSB6+JLv2TG2ZZsEfRQ7BDoCpSZz6Q jGlOkVwnurChaZyzRwQMD5GUL+JtHQST3fB+Cbuaae8Bqywi7xXGQ+Uw+i36mGe7Jv58b4 ZjFQjI5PVUhF8pPV2bGR7CraIe5/t6M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-568-3jUTIOc6POSFxAMYMFGgug-1; Wed, 16 Sep 2020 04:42:11 -0400 X-MC-Unique: 3jUTIOc6POSFxAMYMFGgug-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F172D1868408; Wed, 16 Sep 2020 08:42:09 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-114-66.ams2.redhat.com [10.36.114.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BDDD5100164C; Wed, 16 Sep 2020 08:42:09 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 4BD51113864A; Wed, 16 Sep 2020 10:42:08 +0200 (CEST) From: Markus Armbruster To: John Snow Subject: Re: [PATCH 01/37] python: Require 3.6+ References: <20200915224027.2529813-1-jsnow@redhat.com> <20200915224027.2529813-2-jsnow@redhat.com> Date: Wed, 16 Sep 2020 10:42:08 +0200 In-Reply-To: <20200915224027.2529813-2-jsnow@redhat.com> (John Snow's message of "Tue, 15 Sep 2020 18:39:51 -0400") Message-ID: <87pn6mru3j.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=205.139.110.61; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/16 00:53:39 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.999, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Cleber Rosa , Alex =?utf-8?Q?Benn=C3=A9e?= , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" John Snow writes: > Python 3.5 is now EOL. Python 3.6 brings with it several nice things: > > - Literal string interpolation (PEP 498) > - Syntax for variable annotations (PEP 526) > - Preserving keyword argument order (PEP 468) * > > PEP 526 in particular will allow us to convert the QAPI module to the > statically typed subset of the Python language. These static type hints > improve the interactive editing experience in IDEs and help make > refactoring and adding new features faster, easier and safer. > > *Note: **kwargs is now guaranteed to preserve keyword ordering, but dict > itself is still allowed to have an arbitrary order based on > implementation. It is not until Python 3.7 that the dict type guarantees > insertion order. > > Signed-off-by: John Snow > --- > docs/conf.py | 4 ++-- > configure | 6 +++--- > .readthedocs.yml | 2 +- > .travis.yml | 8 -------- > tests/qemu-iotests/iotests.py | 2 -- > 5 files changed, 6 insertions(+), 16 deletions(-) > > diff --git a/docs/conf.py b/docs/conf.py > index 0dbd90dc11..8aeac40124 100644 > --- a/docs/conf.py > +++ b/docs/conf.py > @@ -36,9 +36,9 @@ > # In newer versions of Sphinx this will display nicely; in older versions > # Sphinx will also produce a Python backtrace but at least the information > # gets printed... > -if sys.version_info < (3,5): > +if sys.version_info < (3,6): > raise ConfigError( > - "QEMU requires a Sphinx that uses Python 3.5 or better\n") > + "QEMU requires a Sphinx that uses Python 3.6 or better\n") > > # The per-manual conf.py will set qemu_docdir for a single-manual build; > # otherwise set it here if this is an entire-manual-set build. > diff --git a/configure b/configure > index ce27eafb0a..33292500e7 100755 > --- a/configure > +++ b/configure > @@ -913,7 +913,7 @@ fi > > : ${make=${MAKE-make}} > > -# We prefer python 3.x. A bare 'python' is traditionally > +# We prefer python 3.6+. A bare 'python' is traditionally We require > # python 2.x, but some distros have it as python 3.x, so > # we check that too > python= > @@ -1961,8 +1961,8 @@ fi > > # Note that if the Python conditional here evaluates True we will exit > # with status 1 which is a shell 'false' value. > -if ! $python -c 'import sys; sys.exit(sys.version_info < (3,5))'; then > - error_exit "Cannot use '$python', Python >= 3.5 is required." \ > +if ! $python -c 'import sys; sys.exit(sys.version_info < (3,6))'; then > + error_exit "Cannot use '$python', Python >= 3.6 is required." \ > "Use --python=/path/to/python to specify a supported Python." > fi > > diff --git a/.readthedocs.yml b/.readthedocs.yml > index 8355dbc634..7fb7b8dd61 100644 > --- a/.readthedocs.yml > +++ b/.readthedocs.yml > @@ -17,4 +17,4 @@ formats: all > # we require for other Python in our codebase (our conf.py > # enforces this, and some code needs it.) > python: > - version: 3.5 > + version: 3.6 > diff --git a/.travis.yml b/.travis.yml > index 65341634d0..0dca15a5e8 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -267,14 +267,6 @@ jobs: > > > # Python builds > - - name: "GCC Python 3.5 (x86_64-softmmu)" > - env: > - - CONFIG="--target-list=x86_64-softmmu" > - - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-default" > - language: python > - python: 3.5 > - > - > - name: "GCC Python 3.6 (x86_64-softmmu)" > env: > - CONFIG="--target-list=x86_64-softmmu" > diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py > index 91e4a57126..f48460480a 100644 > --- a/tests/qemu-iotests/iotests.py > +++ b/tests/qemu-iotests/iotests.py > @@ -40,8 +40,6 @@ > from qemu import qtest > from qemu.qmp import QMPMessage > > -assert sys.version_info >= (3, 6) > - > # Use this logger for logging messages directly from the iotests module > logger = logging.getLogger('qemu.iotests') > logger.addHandler(logging.NullHandler())