All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Egorenkov <egorenar-dev@posteo.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] package/multipath-tools: new package
Date: Sat, 05 Sep 2020 21:18:22 +0200	[thread overview]
Message-ID: <87pn70uj5t.fsf@posteo.net> (raw)
In-Reply-To: <20200903234234.2f4d6793@windsurf.home>


> I've disabled that by passing STACKPROT= as a make option, which allows
> to get passed that. But then it fails with:
>
> parser.c: In function ?set_value?:
> parser.c:375:4: error: ?strncat? specified bound 1 equals source length [-Werror=stringop-overflow=]
>     strncat(alloc, " ", 1);
>     ^~~~~~~~~~~~~~~~~~~~~~
>
> Could you test this package a bit better by using ./utils/test-pkg ?

Done.

>
> Patches should be generated with "git format-patch -N", so that we have
> [PATCH] instead of [PATCH 1/1].
>

Fixed.

>
> Ditto.
>

Fixed.

>
> We need you to add your Signed-off-by on all patches you've imported.
>

Fixed.

>
> 	w/ threads, dynamic library
>

Fixed.

> Some lines are too long. Please run "make check-package" and ensure you
> don't have any warning.
>

Fixed.


Thank you for feedback and patience
Regards
Alex

      reply	other threads:[~2020-09-05 19:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31 18:50 [Buildroot] [PATCH v3 1/1] package/multipath-tools: new package Alexander Egorenkov
2020-09-03 21:42 ` Thomas Petazzoni
2020-09-05 19:18   ` Alexander Egorenkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pn70uj5t.fsf@posteo.net \
    --to=egorenar-dev@posteo.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.