From: Baruch Siach <baruch@tkos.co.il>
To: u-boot@lists.denx.de
Subject: [PATCH v5 1/3] gpio-uclass.c: save the GPIOD flags also in the gpio descriptor
Date: Thu, 02 Jul 2020 22:05:30 +0300 [thread overview]
Message-ID: <87pn9d7n5x.fsf@tarshish> (raw)
In-Reply-To: <20200515140100.3306517-2-hs@denx.de>
Hi Heiko,
On Fri, May 15 2020, Heiko Schocher wrote:
> save the GPIOD_ flags also in the gpio descriptor.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
This fixes SD card access on Hummingboard2. Current master uses the
wrong out polarity to control the SD card power regulator.
Tested-by: Baruch Siach <baruch@tkos.co.il>
Should go to v2020.07 I believe.
One more comment below.
> @@ -614,10 +618,6 @@ int dm_gpio_set_dir_flags(struct gpio_desc *desc, ulong flags)
> flags |= desc->flags;
> ret = _dm_gpio_set_dir_flags(desc, flags);
>
> - /* update the descriptor flags */
> - if (ret)
> - desc->flags = flags;
> -
> return ret;
You can just do
return _dm_gpio_set_dir_flags(desc, flags);
here instead.
Thanks,
baruch
--
~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2020-07-02 19:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 14:00 [PATCH v5 0/3] gpio: add possibility to search for gpio label name Heiko Schocher
2020-05-15 14:00 ` [PATCH v5 1/3] gpio-uclass.c: save the GPIOD flags also in the gpio descriptor Heiko Schocher
2020-05-15 19:36 ` Patrick DELAUNAY
2020-05-20 3:06 ` Simon Glass
2020-07-02 19:05 ` Baruch Siach [this message]
2020-07-03 5:10 ` Heiko Schocher
2020-05-15 14:00 ` [PATCH v5 2/3] sandbox, test: add test for GPIO_HOG function Heiko Schocher
2020-05-20 3:06 ` Simon Glass
2020-05-15 14:00 ` [PATCH v5 3/3] gpio: search for gpio label if gpio is not found through bank name Heiko Schocher
2020-05-20 3:06 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pn9d7n5x.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.