From: Kalle Valo <kvalo@codeaurora.org>
To: Sedat Dilek <sedat.dilek@gmail.com>
Cc: Johannes Berg <johannes.berg@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
Luca Coelho <luciano.coelho@intel.com>,
Intel Linux Wireless <linuxwifi@intel.com>,
"David S. Miller" <davem@davemloft.net>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Chris Rorvick <chris@rorvick.com>
Subject: Re: [PATCH wireless-drivers v3] iwlwifi: actually check allocated conf_tlv pointer
Date: Fri, 17 Apr 2020 11:03:03 +0300 [thread overview]
Message-ID: <87pnc6pmiw.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20200417074558.12316-1-sedat.dilek@gmail.com> (Sedat Dilek's message of "Fri, 17 Apr 2020 09:45:58 +0200")
Sedat Dilek <sedat.dilek@gmail.com> writes:
> From: Chris Rorvick <chris@rorvick.com>
>
> Commit 71bc0334a637 ("iwlwifi: check allocated pointer when allocating
> conf_tlvs") attempted to fix a typoe introduced by commit 17b809c9b22e
> ("iwlwifi: dbg: move debug data to a struct") but does not implement the
> check correctly.
>
> Fixes: 71bc0334a637 ("iwlwifi: check allocated pointer when allocating conf_tlvs")
> Tweeted-by: @grsecurity
> Message-Id: <20200402050219.4842-1-chris@rorvick.com>
> Signed-off-by: Chris Rorvick <chris@rorvick.com>
> Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
Thanks, looks good to me. I'll just remove the Message-Id tag, it's not
really needed in this case.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-04-17 8:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 7:45 [PATCH wireless-drivers v3] iwlwifi: actually check allocated conf_tlv pointer Sedat Dilek
2020-04-17 8:03 ` Kalle Valo [this message]
2020-04-17 8:06 ` Sedat Dilek
2020-04-21 7:50 ` Kalle Valo
2020-04-21 8:32 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnc6pmiw.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=chris@rorvick.com \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxwifi@intel.com \
--cc=luciano.coelho@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sedat.dilek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.