From: Michael Ellerman <mpe@ellerman.id.au>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dmitry Safonov <dima@arista.com>
Cc: linux-kernel@vger.kernel.org,
Dmitry Safonov <0x7f454c46@gmail.com>,
"kernelci.org bot" <bot@kernelci.org>,
Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH] tty/sysrq: Export sysrq_mask()
Date: Thu, 02 Apr 2020 12:45:20 +1100 [thread overview]
Message-ID: <87pncqu0cv.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <20200401151222.GA2508664@kroah.com>
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> On Wed, Apr 01, 2020 at 03:49:56PM +0100, Dmitry Safonov wrote:
>> On 4/1/20 3:46 PM, Greg Kroah-Hartman wrote:
>> > On Wed, Apr 01, 2020 at 03:39:04PM +0100, Dmitry Safonov wrote:
>> >> Build fix for serial_core being module:
>> >> ERROR: modpost: "sysrq_mask" [drivers/tty/serial/serial_core.ko] undefined!
>> >>
>> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> >> Cc: Jiri Slaby <jslaby@suse.com>
>> >> Reported-by: "kernelci.org bot" <bot@kernelci.org>
>> >> Reported-by: Michael Ellerman <mpe@ellerman.id.au>
>> >> Signed-off-by: Dmitry Safonov <dima@arista.com>
>> >> ---
>> >> drivers/tty/sysrq.c | 1 +
>> >> 1 file changed, 1 insertion(+)
>> >
>> > Is this a new problem? What commit does this fix?
>>
>> Right, sorry I've managed to forget adding the tag:
>>
>> Fixes: eaee41727e6d ("sysctl/sysrq: Remove __sysrq_enabled copy")
>>
>> Maybe also:
>>
>> Link:
>> https://lore.kernel.org/linux-fsdevel/87tv23tmy1.fsf@mpe.ellerman.id.au/
>
> Thanks, that works. WIll queue this up after -rc1 is out.
Why wait until after rc1?
It's a build break for a bunch of folks and the fix is obviously correct
(famous last words).
cheers
next prev parent reply other threads:[~2020-04-02 1:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 14:39 [PATCH] tty/sysrq: Export sysrq_mask() Dmitry Safonov
2020-04-01 14:46 ` Greg Kroah-Hartman
2020-04-01 14:49 ` Dmitry Safonov
2020-04-01 15:12 ` Greg Kroah-Hartman
2020-04-02 1:45 ` Michael Ellerman [this message]
2020-04-03 21:53 ` Dave Airlie
2020-04-20 17:34 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pncqu0cv.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=0x7f454c46@gmail.com \
--cc=bot@kernelci.org \
--cc=dima@arista.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.