From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/runc: add an option to build a non-static runc
Date: Fri, 25 Oct 2019 18:45:33 +0200 [thread overview]
Message-ID: <87pnikixjm.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20191023093431.2220-1-jorgar@gmail.com> (James Peach's message of "Wed, 23 Oct 2019 20:34:31 +1100")
>>>>> "James" == James Peach <jorgar@gmail.com> writes:
> From: James Peach <jpeach@apache.org>
> The systemd cgroup driver is compiled out of static builds of
> runc so some users will need a non-static build.
What does that driver exactly do? What distributions enable this?
> Add an option to control whether the runc should be static or not,
> and default it to true for compatibility with existing
> configurations.
Does this then work when running a different libc inside/outside the
containers?
If yes, what is the advantage of linking runc statically?
> Signed-off-by: James Peach <jpeach@apache.org>
> ---
> package/runc/Config.in | 11 +++++++++++
> package/runc/runc.mk | 6 +++++-
> 2 files changed, 16 insertions(+), 1 deletion(-)
> diff --git package/runc/Config.in package/runc/Config.in
> index f181ee334f..ea932120b8 100644
> --- package/runc/Config.in
> +++ package/runc/Config.in
> @@ -10,6 +10,17 @@ config BR2_PACKAGE_RUNC
> https://github.com/opencontainers/runc
> +if BR2_PACKAGE_RUNC
> +
> +config BR2_PACKAGE_RUNC_STATIC
> + bool "static runc binary"
> + default y
> + help
> + Whether to make a static build of runc. This must be false
> + for runc to be able to use the systemd cgroups driver.
> +
> +endif
> +
> comment "runc needs a glibc or musl toolchain w/ threads"
> depends on BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS && \
> BR2_PACKAGE_HOST_GO_TARGET_CGO_LINKING_SUPPORTS
> diff --git package/runc/runc.mk package/runc/runc.mk
> index b858742905..4128afd53a 100644
> --- package/runc/runc.mk
> +++ package/runc/runc.mk
> @@ -13,7 +13,11 @@ RUNC_WORKSPACE = Godeps/_workspace
> RUNC_LDFLAGS = -X main.gitCommit=$(RUNC_VERSION)
> -RUNC_TAGS = cgo static_build
> +RUNC_TAGS = cgo
> +
> +ifeq ($(BR2_PACKAGE_RUNC_STATIC),y)
> +RUNC_TAGS += static_build
> +endif
> ifeq ($(BR2_PACKAGE_LIBSECCOMP),y)
> RUNC_TAGS += seccomp
> --
> 2.21.0
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2019-10-25 16:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 9:34 [Buildroot] [PATCH 1/1] package/runc: add an option to build a non-static runc James Peach
2019-10-25 16:45 ` Peter Korsgaard [this message]
2019-10-25 21:19 ` James Peach
2019-10-28 10:33 ` James Peach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnikixjm.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.