From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com ([134.134.136.20]:1283 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726115AbfGaNrF (ORCPT ); Wed, 31 Jul 2019 09:47:05 -0400 From: Jani Nikula Subject: better kbuild support for drivers spanning multiple directories? Date: Wed, 31 Jul 2019 16:51:24 +0300 Message-ID: <87pnlqmhwj.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Masahiro Yamada , Michal Marek , linux-kbuild@vger.kernel.org Cc: intel-gfx@lists.freedesktop.org Hi - The drm/i915 [1][2] driver has grown quite big over the years: 400+ files with a total sloccount of 175k lines. A flat directory structure just wasn't manageable anymore, and we opted to add subdirectories, despite the general recommendation [3] not to do this. Mostly, it works all right, with some quirks. For example, things like $ make drivers/gpu/drm/i915//.o do not work out of the box; we need to add subdir Makefiles to do things like: subdir-ccflags-y += -I$(srctree)/$(src)/.. and include them using obj-y += / in the top level Makefile. But the main problem really is having to have a top level Makefile specifying everything, instead of being able to recurse into subdirectoris with, say, lib-y += /, and having that build a lib within the subdirectory that gets linked into the parent level module. Is there a better way? Could we have a better way? BR, Jani. [1] drivers/gpu/drm/i915 [2] https://cgit.freedesktop.org/drm/drm-tip/tree/drivers/gpu/drm/i915 [3] Documentation/kbuild/modules.rst section 4.3 -- Jani Nikula, Intel Open Source Graphics Center From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: better kbuild support for drivers spanning multiple directories? Date: Wed, 31 Jul 2019 16:51:24 +0300 Message-ID: <87pnlqmhwj.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1887589BFC for ; Wed, 31 Jul 2019 13:47:09 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Masahiro Yamada , Michal Marek , linux-kbuild@vger.kernel.org Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CkhpIC0KClRoZSBkcm0vaTkxNSBbMV1bMl0gZHJpdmVyIGhhcyBncm93biBxdWl0ZSBiaWcgb3Zl ciB0aGUgeWVhcnM6IDQwMCsKZmlsZXMgd2l0aCBhIHRvdGFsIHNsb2Njb3VudCBvZiAxNzVrIGxp bmVzLiBBIGZsYXQgZGlyZWN0b3J5IHN0cnVjdHVyZQpqdXN0IHdhc24ndCBtYW5hZ2VhYmxlIGFu eW1vcmUsIGFuZCB3ZSBvcHRlZCB0byBhZGQgc3ViZGlyZWN0b3JpZXMsCmRlc3BpdGUgdGhlIGdl bmVyYWwgcmVjb21tZW5kYXRpb24gWzNdIG5vdCB0byBkbyB0aGlzLgoKTW9zdGx5LCBpdCB3b3Jr cyBhbGwgcmlnaHQsIHdpdGggc29tZSBxdWlya3MuIEZvciBleGFtcGxlLCB0aGluZ3MgbGlrZQoK CSQgbWFrZSBkcml2ZXJzL2dwdS9kcm0vaTkxNS88c3ViZGlyPi88ZmlsZT4ubwoKZG8gbm90IHdv cmsgb3V0IG9mIHRoZSBib3g7IHdlIG5lZWQgdG8gYWRkIHN1YmRpciBNYWtlZmlsZXMgdG8gZG8g dGhpbmdzCmxpa2U6CgoJc3ViZGlyLWNjZmxhZ3MteSArPSAtSSQoc3JjdHJlZSkvJChzcmMpLy4u CgphbmQgaW5jbHVkZSB0aGVtIHVzaW5nIG9iai15ICs9IDxzdWJkaXI+LyBpbiB0aGUgdG9wIGxl dmVsIE1ha2VmaWxlLgoKQnV0IHRoZSBtYWluIHByb2JsZW0gcmVhbGx5IGlzIGhhdmluZyB0byBo YXZlIGEgdG9wIGxldmVsIE1ha2VmaWxlCnNwZWNpZnlpbmcgZXZlcnl0aGluZywgaW5zdGVhZCBv ZiBiZWluZyBhYmxlIHRvIHJlY3Vyc2UgaW50bwpzdWJkaXJlY3RvcmlzIHdpdGgsIHNheSwgbGli LXkgKz0gPHN1YmRpcj4vLCBhbmQgaGF2aW5nIHRoYXQgYnVpbGQgYSBsaWIKd2l0aGluIHRoZSBz dWJkaXJlY3RvcnkgdGhhdCBnZXRzIGxpbmtlZCBpbnRvIHRoZSBwYXJlbnQgbGV2ZWwgbW9kdWxl LgoKSXMgdGhlcmUgYSBiZXR0ZXIgd2F5PyBDb3VsZCB3ZSBoYXZlIGEgYmV0dGVyIHdheT8KCkJS LApKYW5pLgoKClsxXSBkcml2ZXJzL2dwdS9kcm0vaTkxNQpbMl0gaHR0cHM6Ly9jZ2l0LmZyZWVk ZXNrdG9wLm9yZy9kcm0vZHJtLXRpcC90cmVlL2RyaXZlcnMvZ3B1L2RybS9pOTE1ClszXSBEb2N1 bWVudGF0aW9uL2tidWlsZC9tb2R1bGVzLnJzdCBzZWN0aW9uIDQuMwoKCi0tIApKYW5pIE5pa3Vs YSwgSW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==