From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: "Janne Heß" <janne@hess.ooo>, bird-users@network.cz
Cc: wireguard@lists.zx2c4.com
Subject: Re: Introduce Wireguard support to bird
Date: Sat, 08 Jun 2019 00:18:44 +0200 [thread overview]
Message-ID: <87pnnp59a3.fsf@toke.dk> (raw)
In-Reply-To: <524c0c7c670e5525c2911bdde2b1211a@hess.ooo>
Janne Heß <janne@hess.ooo> writes:
> Hey everyone,
>
> as advertised, I have completed the Wireguard support.
> You might see that I am not really a C expert, but I hope the code is good enough.
> If you need me to change anything or have additional questions, just
> let me know.
Hi Janne
Awesome that you have taken the time to implement this!
I'll let the Bird maintainers comment on the approach of embedding the
wireguard netlink library; but I have two other concerns:
- As far as I can tell there's nothing preventing Bird from removing
AllowedIPs that it did not itself install from an interface, right?
- The algorithm is basically O(P*M*N) for inserting N routes on an
interface with P peers that each have M existing AllowedIPs. That is
not going to scale very far :/
-Toke
_______________________________________________
WireGuard mailing list
WireGuard@lists.zx2c4.com
https://lists.zx2c4.com/mailman/listinfo/wireguard
next prev parent reply other threads:[~2019-06-07 22:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 18:21 Introduce Wireguard support to bird Janne Heß
2019-06-07 21:57 ` Ondrej Zajicek
2019-06-07 22:20 ` Toke Høiland-Jørgensen
2019-06-07 22:18 ` Toke Høiland-Jørgensen [this message]
2019-07-06 21:05 ` Janne Heß
2019-07-08 11:36 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnnp59a3.fsf@toke.dk \
--to=toke@toke.dk \
--cc=bird-users@network.cz \
--cc=janne@hess.ooo \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.