From: Jani Nikula <jani.nikula@linux.intel.com>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
dri-devel@lists.freedesktop.org
Cc: Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] drm: Format-declare struct drm_format_info in drm_framebuffer.h
Date: Wed, 13 Mar 2019 14:30:11 +0200 [thread overview]
Message-ID: <87pnqvhs8c.fsf@intel.com> (raw)
In-Reply-To: <20190313104249.5483-1-laurent.pinchart+renesas@ideasonboard.com>
On Wed, 13 Mar 2019, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote:
> drm_framebuffer.h makes use of a pointer to struct drm_format_info but
> doesn't include drm_fourcc.h (neither directly nor indirectly).
> Forward-declare the structure.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
With the subject typo fixed,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> include/drm/drm_framebuffer.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/drm/drm_framebuffer.h b/include/drm/drm_framebuffer.h
> index f0b34c977ec5..c23016748e3f 100644
> --- a/include/drm/drm_framebuffer.h
> +++ b/include/drm/drm_framebuffer.h
> @@ -32,6 +32,7 @@
> struct drm_clip_rect;
> struct drm_device;
> struct drm_file;
> +struct drm_format_info;
> struct drm_framebuffer;
> struct drm_gem_object;
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-03-13 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 10:42 [PATCH] drm: Format-declare struct drm_format_info in drm_framebuffer.h Laurent Pinchart
2019-03-13 12:30 ` Jani Nikula [this message]
2019-03-13 16:10 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnqvhs8c.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.