From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 1/3] drm/i915: Use intel_engine_stop_cs when stopping ringbuffer Date: Wed, 27 Feb 2019 19:03:38 +0200 Message-ID: <87pnrdupsl.fsf@gaia.fi.intel.com> References: <20190227165850.17277-1-mika.kuoppala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 406D06E0F0 for ; Wed, 27 Feb 2019 17:04:06 +0000 (UTC) In-Reply-To: <20190227165850.17277-1-mika.kuoppala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org TWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+IHdyaXRlczoKCj4g V2UgaGF2ZSBhbiBleHBvcnRlZCBmdW5jdGlvbiBmb3Igc3RvcHBpbmcgdGhlIGVuZ2luZSBiZWZv cmUKPiBkaXNhYmxpbmcgYSByaW5nYnVmZmVyLiBUYWtlIGl0IGludG8gdXNlLgo+Cj4gQ2M6IENo cmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IFNpZ25lZC1vZmYtYnk6IE1p a2EgS3VvcHBhbGEgPG1pa2Eua3VvcHBhbGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9lbmdpbmVfY3MuYyAgfCAgMyArKysKPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIHwgMzEgKysrKysrKysrKystLS0tLS0tLS0t LS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDE4IGRlbGV0aW9ucygt KQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiBpbmRleCA0ZjI0NDAx OTU2MGQuLjNmZWIwZjc0YzIzOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9lbmdpbmVfY3MuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2lu ZV9jcy5jCj4gQEAgLTgxNyw2ICs4MTcsOSBAQCB2b2lkIGludGVsX2VuZ2luZV9jYW5jZWxfc3Rv cF9jcyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gIHsKPiAgCXN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGVuZ2luZS0+aTkxNTsKPiAgCj4gKwlpZiAoSU5URUxf R0VOKGRldl9wcml2KSA8IDMpCj4gKwkJcmV0dXJuOwo+ICsKPiAgCUdFTV9UUkFDRSgiJXNcbiIs IGVuZ2luZS0+bmFtZSk7Cj4gIAo+ICAJSTkxNV9XUklURV9GVyhSSU5HX01JX01PREUoZW5naW5l LT5tbWlvX2Jhc2UpLAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9y aW5nYnVmZmVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiBp bmRleCAxYjk2YjA5NjBhZGMuLjUzNjNkYWQxMjA4ZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9yaW5nYnVmZmVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9yaW5nYnVmZmVyLmMKPiBAQCAtNjA3LDIzICs2MDcsMTkgQEAgc3RhdGljIHZvaWQg cmluZ19zZXR1cF9zdGF0dXNfcGFnZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4g IHN0YXRpYyBib29sIHN0b3BfcmluZyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4g IHsKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGVuZ2luZS0+aTkxNTsK PiArCWludCByZXQ7Cj4gIAo+IC0JaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPiAyKSB7Cj4gLQkJ STkxNV9XUklURV9NT0RFKGVuZ2luZSwgX01BU0tFRF9CSVRfRU5BQkxFKFNUT1BfUklORykpOwo+ IC0JCWlmIChpbnRlbF93YWl0X2Zvcl9yZWdpc3RlcihkZXZfcHJpdiwKPiAtCQkJCQkgICAgUklO R19NSV9NT0RFKGVuZ2luZS0+bW1pb19iYXNlKSwKPiAtCQkJCQkgICAgTU9ERV9JRExFLAo+IC0J CQkJCSAgICBNT0RFX0lETEUsCj4gLQkJCQkJICAgIDEwMDApKSB7Cj4gLQkJCURSTV9FUlJPUigi JXMgOiB0aW1lZCBvdXQgdHJ5aW5nIHRvIHN0b3AgcmluZ1xuIiwKPiAtCQkJCSAgZW5naW5lLT5u YW1lKTsKPiAtCQkJLyogU29tZXRpbWVzIHdlIG9ic2VydmUgdGhhdCB0aGUgaWRsZSBmbGFnIGlz IG5vdAo+IC0JCQkgKiBzZXQgZXZlbiB0aG91Z2ggdGhlIHJpbmcgaXMgZW1wdHkuIFNvIGRvdWJs ZQo+IC0JCQkgKiBjaGVjayBiZWZvcmUgZ2l2aW5nIHVwLgo+IC0JCQkgKi8KPiAtCQkJaWYgKEk5 MTVfUkVBRF9IRUFEKGVuZ2luZSkgIT0gSTkxNV9SRUFEX1RBSUwoZW5naW5lKSkKPiAtCQkJCXJl dHVybiBmYWxzZTsKPiAtCQl9Cj4gKwlyZXQgPSBpbnRlbF9lbmdpbmVfc3RvcF9jcyhlbmdpbmUp Owo+ICsJaWYgKHJldCA9PSAtRU5PREVWKQo+ICsJCXJldCA9IDA7Cj4gKwo+ICsJaWYgKHJldCkg ewo+ICsJCS8qIFNvbWV0aW1lcyB3ZSBvYnNlcnZlIHRoYXQgdGhlIGlkbGUgZmxhZyBpcyBub3QK PiArCQkgKiBzZXQgZXZlbiB0aG91Z2ggdGhlIHJpbmcgaXMgZW1wdHkuIFNvIGRvdWJsZQo+ICsJ CSAqIGNoZWNrIGJlZm9yZSBnaXZpbmcgdXAuCj4gKwkJICovCj4gKwkJaWYgKEk5MTVfUkVBRF9I RUFEKGVuZ2luZSkgIT0gSTkxNV9SRUFEX1RBSUwoZW5naW5lKSkKCkhtbSB0aGVzZSBjb3VsZCBo YXZlIGJlZW4gYWxzbyBjb252ZXJ0ZWQgdG8gdGhlIF9GVyB2YXJpYW50cy4KLU1pa2EKCgo+ICsJ CQlyZXR1cm4gZmFsc2U7Cj4gIAl9Cj4gIAo+ICAJSTkxNV9XUklURV9IRUFEKGVuZ2luZSwgSTkx NV9SRUFEX1RBSUwoZW5naW5lKSk7Cj4gQEAgLTcxOCw4ICs3MTQsNyBAQCBzdGF0aWMgaW50IGlu aXRfcmluZ19jb21tb24oc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAJCWdvdG8g b3V0Owo+ICAJfQo+ICAKPiAtCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID4gMikKPiAtCQlJOTE1 X1dSSVRFX01PREUoZW5naW5lLCBfTUFTS0VEX0JJVF9ESVNBQkxFKFNUT1BfUklORykpOwo+ICsJ aW50ZWxfZW5naW5lX2NhbmNlbF9zdG9wX2NzKGVuZ2luZSk7Cj4gIAo+ICAJLyogTm93IGF3YWtl LCBsZXQgaXQgZ2V0IHN0YXJ0ZWQgKi8KPiAgCWlmIChyaW5nLT50YWlsICE9IHJpbmctPmhlYWQp IHsKPiAtLSAKPiAyLjE3LjEKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50 ZWwtZ2Z4