From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2 7/7] drm/i915/crt: simplify CRT VBT check on pre-VLV/DDI Date: Thu, 24 Jan 2019 09:40:16 +0200 Message-ID: <87pnsm1p27.fsf@intel.com> References: <20190122082307.4003-1-jani.nikula@intel.com> <20190122082307.4003-7-jani.nikula@intel.com> <20190123183636.GH20097@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id D53116F0B1 for ; Thu, 24 Jan 2019 07:38:35 +0000 (UTC) In-Reply-To: <20190123183636.GH20097@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMyBKYW4gMjAxOSwgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4gd3JvdGU6Cj4gT24gVHVlLCBKYW4gMjIsIDIwMTkgYXQgMTA6MjM6MDdBTSAr MDIwMCwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4+IFRoZSBWQlQgaW50X2NydF9zdXBwb3J0IGNhbid0 IGJlIHRydXN0ZWQgb24gZWFybGllciBwbGF0Zm9ybXMsIGFuZCBpcwo+PiBhbHdheXMgc2V0IHRv IHRydWUgaW4gaW50ZWxfYmlvcy5jIGZvciBwcmUtRERJIGFuZCBwcmUtVkxWIHBsYXRmb3Jtcy4g V2UKPj4gY2FuIHNpbXBsaWZ5IHRoZSBvdXRwdXQgc2V0dXAgYnkgdW5jb25kaXRpb25hbGx5IGNh bGxpbmcKPj4gaW50ZWxfY3J0X2luaXQoKSBmb3IgdGhlc2UgcGxhdGZvcm1zLgo+PiAKPj4gU3Vn Z2VzdGVkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t Pgo+PiBTaWduZWQtb2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+ Cj4gUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl bC5jb20+CgpNYW55IHRoYW5rcywgcHVzaGVkIHRoZSBzZXJpZXMuCgpCUiwKSmFuaS4KCgoKPgo+ PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDE1ICsrKyst LS0tLS0tLS0tLQo+PiAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRp b25zKC0pCj4+IAo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+IGluZGV4IGVk Mzc4MGYyNDYzOC4uZDMyODU5OTI0MGNiIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jCj4+IEBAIC0xNDM4Miw5ICsxNDM4Miw3IEBAIHN0YXRpYyB2b2lkIGludGVsX3Nl dHVwX291dHB1dHMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+PiAgCQkgKiBp bmNvcnJlY3Qgc2hhcmluZyBvZiB0aGUgUFBTLgo+PiAgCQkgKi8KPj4gIAkJaW50ZWxfbHZkc19p bml0KGRldl9wcml2KTsKPj4gLQo+PiAtCQlpZiAoZGV2X3ByaXYtPnZidC5pbnRfY3J0X3N1cHBv cnQpCj4+IC0JCQlpbnRlbF9jcnRfaW5pdChkZXZfcHJpdik7Cj4+ICsJCWludGVsX2NydF9pbml0 KGRldl9wcml2KTsKPj4gIAo+PiAgCQlkcGRfaXNfZWRwID0gaW50ZWxfZHBfaXNfcG9ydF9lZHAo ZGV2X3ByaXYsIFBPUlRfRCk7Cj4+ICAKPj4gQEAgLTE0NDYxLDE3ICsxNDQ1OSwxNCBAQCBzdGF0 aWMgdm9pZCBpbnRlbF9zZXR1cF9vdXRwdXRzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdikKPj4gIAkJdmx2X2RzaV9pbml0KGRldl9wcml2KTsKPj4gIAl9IGVsc2UgaWYgKElTX1BJ TkVWSUVXKGRldl9wcml2KSkgewo+PiAgCQlpbnRlbF9sdmRzX2luaXQoZGV2X3ByaXYpOwo+PiAt Cj4+IC0JCWlmIChkZXZfcHJpdi0+dmJ0LmludF9jcnRfc3VwcG9ydCkKPj4gLQkJCWludGVsX2Ny dF9pbml0KGRldl9wcml2KTsKPj4gKwkJaW50ZWxfY3J0X2luaXQoZGV2X3ByaXYpOwo+PiAgCX0g ZWxzZSBpZiAoSVNfR0VOX1JBTkdFKGRldl9wcml2LCAzLCA0KSkgewo+PiAgCQlib29sIGZvdW5k ID0gZmFsc2U7Cj4+ICAKPj4gIAkJaWYgKElTX01PQklMRShkZXZfcHJpdikpCj4+ICAJCQlpbnRl bF9sdmRzX2luaXQoZGV2X3ByaXYpOwo+PiAgCj4+IC0JCWlmIChkZXZfcHJpdi0+dmJ0LmludF9j cnRfc3VwcG9ydCkKPj4gLQkJCWludGVsX2NydF9pbml0KGRldl9wcml2KTsKPj4gKwkJaW50ZWxf Y3J0X2luaXQoZGV2X3ByaXYpOwo+PiAgCj4+ICAJCWlmIChJOTE1X1JFQUQoR0VOM19TRFZPQikg JiBTRFZPX0RFVEVDVEVEKSB7Cj4+ICAJCQlEUk1fREVCVUdfS01TKCJwcm9iaW5nIFNEVk9CXG4i KTsKPj4gQEAgLTE0NTExLDkgKzE0NTA2LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfc2V0dXBfb3V0 cHV0cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+ICAJCWlmIChJU19JODVY KGRldl9wcml2KSkKPj4gIAkJCWludGVsX2x2ZHNfaW5pdChkZXZfcHJpdik7Cj4+ICAKPj4gLQkJ aWYgKGRldl9wcml2LT52YnQuaW50X2NydF9zdXBwb3J0KQo+PiAtCQkJaW50ZWxfY3J0X2luaXQo ZGV2X3ByaXYpOwo+PiAtCj4+ICsJCWludGVsX2NydF9pbml0KGRldl9wcml2KTsKPj4gIAkJaW50 ZWxfZHZvX2luaXQoZGV2X3ByaXYpOwo+PiAgCX0KPj4gIAo+PiAtLSAKPj4gMi4yMC4xCgotLSAK SmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK