From: Dominick Grift <dac.override@gmail.com>
To: Nicolas Iooss <nicolas.iooss@m4x.org>
Cc: Chris PeBenito <pebenito@ieee.org>,
selinux-refpolicy@vger.kernel.org,
Russell Coker <russell@coker.com.au>
Subject: Re: [PATCH] systemd related interfaces
Date: Sat, 05 Jan 2019 22:49:22 +0100 [thread overview]
Message-ID: <87pnta93ml.fsf@gmail.com> (raw)
In-Reply-To: <CAJfZ7==bQu=F_rUcRcJQPOx6KR1RG5D0eVmnW25TuJDQpELDYA@mail.gmail.com> (Nicolas Iooss's message of "Sat, 5 Jan 2019 22:39:55 +0100")
Nicolas Iooss <nicolas.iooss@m4x.org> writes:
> On Sat, Jan 5, 2019 at 8:39 PM Chris PeBenito <pebenito@ieee.org> wrote:
>>
>> On 1/4/19 2:51 AM, Russell Coker wrote:
>> > This patch has interface changes related to systemd support as well as policy
>> > that uses the new interfaces.
>> > [...]
>> > Index: refpolicy-2.20180701/policy/modules/system/logging.te
>> > ===================================================================
>> > --- refpolicy-2.20180701.orig/policy/modules/system/logging.te
>> > +++ refpolicy-2.20180701/policy/modules/system/logging.te
>> > @@ -541,15 +541,19 @@ ifdef(`init_systemd',`
>> > dev_read_urand(syslogd_t)
>> > dev_write_kmsg(syslogd_t)
>> >
>> > + domain_getattr_all_domains(syslogd_t)
>> > domain_read_all_domains_state(syslogd_t)
>> >
>> > init_create_pid_dirs(syslogd_t)
>> > init_daemon_pid_file(syslogd_var_run_t, dir, "syslogd")
>> > + init_getattr(syslogd_t)
>> > init_rename_pid_files(syslogd_t)
>> > init_delete_pid_files(syslogd_t)
>> > init_dgram_send(syslogd_t)
>> > init_read_pid_pipes(syslogd_t)
>> > init_read_state(syslogd_t)
>> > + # for /run/systemd/units/invocation:* links
>> > + init_read_unit_links(syslogd_t)
>> >
>> > systemd_manage_journal_files(syslogd_t)
>> >
>
> This change has not been merged and I see the relevant AVC on an Arch
> Linux virtual machine (using systemd 239.370):
>
> type=AVC msg=audit(1546723651.696:2091): avc: denied { read } for
> pid=240 comm="systemd-journal" name="invocation:user@1000.service"
> dev="tmpfs" ino=17614 scontext=system_u:system_r:syslogd_t
> tcontext=system_u:object_r:init_var_run_t tclass=lnk_file permissive=0
> type=AVC msg=audit(1546723651.799:2092): avc: denied { read } for
> pid=240 comm="systemd-journal" name="invocation:dbus.service"
> dev="tmpfs" ino=12542 scontext=system_u:system_r:syslogd_t
> tcontext=system_u:object_r:init_var_run_t tclass=lnk_file permissive=0
This should be ok to allow, afaik only journald reads these
symlinks.
>
> What prevented init_read_unit_links(syslogd_t) from being added?
>
> Nicolas
>
--
Key fingerprint = 5F4D 3CDB D3F8 3652 FBD8 02D5 3B6C 5F1D 2C7B 6B02
https://sks-keyservers.net/pks/lookup?op=get&search=0x3B6C5F1D2C7B6B02
Dominick Grift
next prev parent reply other threads:[~2019-01-05 21:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 7:51 [PATCH] systemd related interfaces Russell Coker
2019-01-05 19:18 ` Chris PeBenito
2019-01-05 21:39 ` Nicolas Iooss
2019-01-05 21:49 ` Dominick Grift [this message]
2019-01-06 18:39 ` Chris PeBenito
2019-01-06 22:10 ` Nicolas Iooss
2019-01-07 23:36 ` Chris PeBenito
2019-01-10 23:10 ` Nicolas Iooss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnta93ml.fsf@gmail.com \
--to=dac.override@gmail.com \
--cc=nicolas.iooss@m4x.org \
--cc=pebenito@ieee.org \
--cc=russell@coker.com.au \
--cc=selinux-refpolicy@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.