From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 3/3] drm/vc4: Prefer PPF over TPZ when dst >= 2/3 src Date: Thu, 08 Nov 2018 07:18:48 -0800 Message-ID: <87pnvfoaw7.fsf@anholt.net> References: <20181024100505.22436-1-boris.brezillon@bootlin.com> <20181024100505.22436-3-boris.brezillon@bootlin.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1216260295==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id CA7B36E104 for ; Thu, 8 Nov 2018 15:18:50 +0000 (UTC) In-Reply-To: <20181024100505.22436-3-boris.brezillon@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Cc: Boris Brezillon , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1216260295== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Boris Brezillon writes: > The HVS spec recommends using PPF when the downscaling ratio is > between 2/3 and 1. Let's modify vc4_get_scaling_mode() to follow this > recommendation. > > Signed-off-by: Boris Brezillon > --- > drivers/gpu/drm/vc4/vc4_plane.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_pl= ane.c > index 5950e6b6b7f0..1d0d91e50aaf 100644 > --- a/drivers/gpu/drm/vc4/vc4_plane.c > +++ b/drivers/gpu/drm/vc4/vc4_plane.c > @@ -129,12 +129,12 @@ static const struct hvs_format *vc4_get_hvs_format(= u32 drm_format) >=20=20 > static enum vc4_scaling_mode vc4_get_scaling_mode(u32 src, u32 dst) > { > - if (dst > src) > + if (dst =3D=3D src) > + return VC4_SCALING_NONE; > + if (3 * dst >=3D 2 * src) > return VC4_SCALING_PPF; > - else if (dst < src) > - return VC4_SCALING_TPZ; > else > - return VC4_SCALING_NONE; > + return VC4_SCALING_TPZ; > } Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlvkU9gACgkQtdYpNtH8 nujc/Q//b8o8F5PO2st6WWEZZy/rMAs/qY7wuWm5eMFlpZjM2i+ZbTyTR7PLe2Ps 1OdQGa3WXEkiKtf02CPULCW/fagUAHZXTq9Qct2EqipEDEKvgYSk4XRobI2Hah+Z 0G/lES4eQ2564D7UJraNr6Esh6s/wOo5AIznkBvZap7qttq/6Vtwe0QlJfrydN/Y n6cmMzmvDFRb7sDZIVqaWXMjBUs60qZZBr9llGqlH1R5AaDt7ETgcCM6s4I4ltMt RLpogH3zlJ8fVJn466Nk2fi+4BX0NabPkk8H6/oEiRuv1T8ULzCRphixCJKvxYjD zyV5xQDexzqv1VC4GFpoVxv0+IXKxV+e53KGbvtPw0aEtmvpyZkjtt2pG8n/yGoz Gzov1VNX0lsVyisvlNKK1Y9reErUC2fDhVRMdm2GQ8XzlSHL0CTEe5VmNy4twSTP ODqz+m/4yiElp+KO44Vj9W2EdL9+LhB70W/43kAU8y9QTrkTtQsiLcO03cZrTLn7 sbTPLZLXQezcZnbvQar6oVvKiYKbKWl/raMlbmnylGkB65BwBs+QglXUCcNjJgnA q/1tvLwuoH51NDoDb7iAVtYt1gOYtdIUldBRK7HtvH9YP1c37jADDqE0on+7RS5k fcJoCgTuskGQVmwk6EAwHdFVN2eHFppzovPAFPocW8QfhoU/FaI= =C5hO -----END PGP SIGNATURE----- --=-=-=-- --===============1216260295== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1216260295==--