From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/2] sysfs: constify sysfs create/remove files harder Date: Tue, 16 Oct 2018 14:38:53 +0300 Message-ID: <87pnwakto2.fsf@intel.com> References: <20181004143750.30880-1-jani.nikula@intel.com> <20181016104845.GB4768@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 92482898AF for ; Tue, 16 Oct 2018 11:39:11 +0000 (UTC) In-Reply-To: <20181016104845.GB4768@kroah.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Greg Kroah-Hartman Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAxNiBPY3QgMjAxOCwgR3JlZyBLcm9haC1IYXJ0bWFuIDxncmVna2hAbGludXhmb3Vu ZGF0aW9uLm9yZz4gd3JvdGU6Cj4gT24gVGh1LCBPY3QgMDQsIDIwMTggYXQgMDU6Mzc6NDlQTSAr MDMwMCwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4+IExldCB0aGUgcGFzc2VkIGluIGFycmF5IGJlIGNv bnN0IChhbmQgdGh1cyBwbGFjZWQgaW4gcm9kYXRhKSBpbnN0ZWFkIG9mCj4+IGEgbXV0YWJsZSBh cnJheSBvZiBjb25zdCBwb2ludGVycy4KPj4gCj4+IENjOiBHcmVnIEtyb2FoLUhhcnRtYW4gPGdy ZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPgo+PiBDYzogIlJhZmFlbCBKLiBXeXNvY2tpIiA8cmFm YWVsQGtlcm5lbC5vcmc+Cj4+IFNpZ25lZC1vZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3Vs YUBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgZnMvc3lzZnMvZmlsZS5jICAgICAgIHwgNCArKy0tCj4+ ICBpbmNsdWRlL2xpbnV4L3N5c2ZzLmggfCA4ICsrKystLS0tCj4+ICAyIGZpbGVzIGNoYW5nZWQs IDYgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPgo+IFJldmlld2VkLWJ5OiBHcmVnIEty b2FoLUhhcnRtYW4gPGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPgoKVGhhbmtzOyB3aG8gc2hv dWxkIHBpY2sgdGhlbSB1cD8KCkJSLApKYW5pLgoKCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3Bl biBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9090C04EBD for ; Tue, 16 Oct 2018 11:39:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 73750208E4 for ; Tue, 16 Oct 2018 11:39:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 73750208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727084AbeJPT3N (ORCPT ); Tue, 16 Oct 2018 15:29:13 -0400 Received: from mga11.intel.com ([192.55.52.93]:19640 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726711AbeJPT3N (ORCPT ); Tue, 16 Oct 2018 15:29:13 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2018 04:39:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,388,1534834800"; d="scan'208";a="99621276" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.72.61]) by fmsmga001.fm.intel.com with ESMTP; 16 Oct 2018 04:39:09 -0700 From: Jani Nikula To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, "Rafael J. Wysocki" Subject: Re: [PATCH 1/2] sysfs: constify sysfs create/remove files harder In-Reply-To: <20181016104845.GB4768@kroah.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20181004143750.30880-1-jani.nikula@intel.com> <20181016104845.GB4768@kroah.com> Date: Tue, 16 Oct 2018 14:38:53 +0300 Message-ID: <87pnwakto2.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Oct 2018, Greg Kroah-Hartman wrote: > On Thu, Oct 04, 2018 at 05:37:49PM +0300, Jani Nikula wrote: >> Let the passed in array be const (and thus placed in rodata) instead of >> a mutable array of const pointers. >> >> Cc: Greg Kroah-Hartman >> Cc: "Rafael J. Wysocki" >> Signed-off-by: Jani Nikula >> --- >> fs/sysfs/file.c | 4 ++-- >> include/linux/sysfs.h | 8 ++++---- >> 2 files changed, 6 insertions(+), 6 deletions(-) > > Reviewed-by: Greg Kroah-Hartman Thanks; who should pick them up? BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center