From: "Alex Bennée" <alex.bennee@linaro.org>
To: "Emilio G. Cota" <cota@braap.org>
Cc: Richard Henderson <richard.henderson@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/4] softfloat: Fix division
Date: Thu, 04 Oct 2018 16:43:23 +0100 [thread overview]
Message-ID: <87pnwpra3o.fsf@linaro.org> (raw)
In-Reply-To: <20181004145525.GA9715@flamenco>
Emilio G. Cota <cota@braap.org> writes:
> On Thu, Oct 04, 2018 at 10:13:55 +0100, Alex Bennée wrote:
>>
>> Richard Henderson <richard.henderson@linaro.org> writes:
>>
>> > Changes from v1:
>> > * Preserve udiv_qrnnd as a separate division primitive that
>> > could be used as a building block for float128 division.
>> > * Include asm fragments for x86_64, s390x, and ppc64.
>>
>> It passes my fops fdiv_double test but Emilio's test is reporting:
>>
>> Errors found in f64_div, rounding near_even:
>> +252.7FFFFFFFFFF80 +001.FFFFFFFFFFFFE
>> => +64F.7FFFFFFFFFF82 ....x expected +64F.7FFFFFFFFFF81 ....x
>
> Did you rebuild the test program? v2 passes all f64_div tests for me.
>
> Tested-by: Emilio G. Cota <cota@braap.org>
> for patches 1 and 2.
Hmm I did:
make clean
make
in the tests/fp dir multiple times while going through before/after fix
scenarios. And now of course it works....
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
>
> Thanks,
>
> E.
--
Alex Bennée
prev parent reply other threads:[~2018-10-04 15:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 18:07 [Qemu-devel] [PATCH v2 0/4] softfloat: Fix division Richard Henderson
2018-10-03 18:07 ` [Qemu-devel] [PATCH v2 1/4] " Richard Henderson
2018-10-03 18:07 ` [Qemu-devel] [PATCH v2 2/4] softfloat: Specialize udiv_qrnnd for x86_64 Richard Henderson
2018-10-03 18:07 ` [Qemu-devel] [PATCH v2 3/4] softfloat: Specialize udiv_qrnnd for s390x Richard Henderson
2018-10-05 9:56 ` David Hildenbrand
2018-10-03 18:07 ` [Qemu-devel] [PATCH v2 4/4] softfloat: Specialize udiv_qrnnd for ppc64 Richard Henderson
2018-10-04 0:18 ` David Gibson
2018-10-04 9:13 ` [Qemu-devel] [PATCH v2 0/4] softfloat: Fix division Alex Bennée
2018-10-04 14:55 ` Emilio G. Cota
2018-10-04 15:43 ` Alex Bennée [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnwpra3o.fsf@linaro.org \
--to=alex.bennee@linaro.org \
--cc=cota@braap.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.