From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [RFC 1/3] drm/i915/icl: Restructure ICL DPLL enable
 functionality
Date: Wed, 03 Oct 2018 10:54:59 +0300
Message-ID: <87pnwrqxbg.fsf@intel.com>
References: <1536908054-2176-1-git-send-email-vandita.kulkarni@intel.com>
 <1536908054-2176-2-git-send-email-vandita.kulkarni@intel.com>
 <20180914160655.GJ5565@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by gabe.freedesktop.org (Postfix) with ESMTPS id D2456894FE
 for <intel-gfx@lists.freedesktop.org>; Wed,  3 Oct 2018 07:55:05 +0000 (UTC)
In-Reply-To: <20180914160655.GJ5565@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville =?utf-8?B?U3lyasOkbMOk?= <ville.syrjala@linux.intel.com>, Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: intel-gfx@lists.freedesktop.org, paulo.r.zanoni@intel.com
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCAxNCBTZXAgMjAxOCwgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4
LmludGVsLmNvbT4gd3JvdGU6Cj4gT24gRnJpLCBTZXAgMTQsIDIwMTggYXQgMTI6MjQ6MTJQTSAr
MDUzMCwgVmFuZGl0YSBLdWxrYXJuaSB3cm90ZToKPj4gRnJvbTogTWFkaGF2IENoYXVoYW4gPG1h
ZGhhdi5jaGF1aGFuQGludGVsLmNvbT4KPj4gCj4+IEluIEdlbjExLCBEUExMIDAgYW5kIDEgYXJl
IHNoYXJlZCBiZXR3ZWVuIERESSBhbmQgRFNJLgo+PiBNb3N0IG9mIHRoZSBzdGVwcyBmb3IgZW5h
YmxpbmcgRFBMTCBhcmUgY29tbW9uIGFjcm9zcyBEREkKPj4gYW5kIERTSS4gVGhpcyBwYXRjaCBt
YWtlcyBpY2xfZHBsbF9lbmFibGUoKSBnZW5lcmljIHdoaWNoCj4+IHdpbGwgYmUgdXNlZCBieSBh
bGwgdGhlIGVuY29kZXJzLgo+PiAKPj4gU2lnbmVkLW9mZi1ieTogTWFkaGF2IENoYXVoYW4gPG1h
ZGhhdi5jaGF1aGFuQGludGVsLmNvbT4KPj4gU2lnbmVkLW9mZi1ieTogVmFuZGl0YSBLdWxrYXJu
aSA8dmFuZGl0YS5rdWxrYXJuaUBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfZGRpLmMgICAgICB8IDEyICsrKysrKysrKysrKwo+PiAgZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYyB8IDE5ICsrLS0tLS0tLS0tLS0tLS0tLS0KPj4gIGRy
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmggfCAgMiArLQo+PiAgMyBmaWxlcyBj
aGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxOCBkZWxldGlvbnMoLSkKPj4gCj4+IGRpZmYgLS1n
aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyBiL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2RkaS5jCj4+IGluZGV4IGNkMDFhMDkuLjI5NDJhMjQgMTAwNjQ0Cj4+IC0tLSBh
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2RkaS5jCj4+IEBAIC0yODEwLDYgKzI4MTAsMTggQEAgc3RhdGljIHZvaWQg
aW50ZWxfZGRpX2Nsa19zZWxlY3Qoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4+ICAJ
bXV0ZXhfbG9jaygmZGV2X3ByaXYtPmRwbGxfbG9jayk7Cj4+ICAKPj4gIAlpZiAoSVNfSUNFTEFL
RShkZXZfcHJpdikpIHsKPj4gKwkJZW51bSBpbnRlbF9kcGxsX2lkIGlkID0gcGxsLT5pbmZvLT5p
ZDsKPj4gKwkJaTkxNV9yZWdfdCBlbmFibGVfcmVnID0gaWNsX3BsbF9pZF90b19lbmFibGVfcmVn
KGlkKTsKPj4gKwo+PiArCQl2YWwgPSBJOTE1X1JFQUQoZW5hYmxlX3JlZyk7Cj4+ICsJCXZhbCB8
PSBQTExfRU5BQkxFOwo+PiArCQlJOTE1X1dSSVRFKGVuYWJsZV9yZWcsIHZhbCk7Cj4+ICsKPj4g
KwkJLyogVE9ETzogd2FpdCB0aW1lcyBtaXNzaW5nIGZyb20gdGhlIHNwZWMuICovCj4+ICsJCWlm
IChpbnRlbF93YWl0X2Zvcl9yZWdpc3RlcihkZXZfcHJpdiwgZW5hYmxlX3JlZywgUExMX0xPQ0ss
Cj4+ICsJCQkJCSAgICBQTExfTE9DSywgNSkpCj4+ICsJCQlEUk1fRVJST1IoIlBMTCAlZCBub3Qg
bG9ja2VkXG4iLCBpZCk7Cj4+ICsKPgo+IEkgZG9uJ3QgcmVhbGx5IHNlZSB3aHkgdGhpcyBjYW4n
dCBzdGF5IGluIHRoZSBkcGxsIG1nci4KCkFncmVlZCwgSSB0aGluayBpdCBzaG91bGQgc3RheSBp
biBEUExMIG1hbmFnZXIuCgpUaGUgdGhpbmcgaXMsIERQTEwgZW5hYmxpbmcgZm9yIERTSSByZXF1
aXJlcyBlbmNvZGVyIHNwZWNpZmljIHN0ZXBzIGluCnRoZSBtaWRkbGUgb2YgdGhlIHNlcXVlbmNl
IGhpZGRlbiBpbiBEUExMIG1hbmFnZXIuIEl0J3Mgbm90IHByZXR0eSB0bwphZGQgdGhhdCBpbiBE
UExMIG1hbmFnZXIuCgpPbmUgYXBwcm9hY2ggbWlnaHQgYmUgdG8gYWRkIGVuY29kZXIgaG9va3Mg
dG8gY2FsbCBmcm9tIHRoZSByaWdodCBzcG90CmluIHRoZSBEUExMIG1hbmFnZXIsICJtaWRfcGxs
X2VuYWJsZSIuIEl0J3MgYW5ub3lpbmcgYmVjYXVzZSBpdCB3b3VsZApoYXZlIHRvIGhhcHBlbiBp
biB0aGUgbWlkZGxlIG9mIHRoZSBwbGF0Zm9ybSBzcGVjaWZpYyBEUExMIG1hbmFnZXIKcGxsLT5p
bmZvLT5mdW5jcy0+ZW5hYmxlIGhvb2suIFdlJ2QgaGF2ZSB0byBjYWxsIHRoZSBob29rcyBmcm9t
IHBsYXRmb3JtCnNwZWNpZmljIGNvZGUsIG9yIHNwbGl0IHRob3NlIGhvb2tzIGluIHR3by4gVGhl
IGZvcm1lciBpcyB1Z2x5IGJlY2F1c2UKaXQgcmVxdWlyZXMgcGFzc2luZyBjcnRjIHRvIHRoZSBw
bGwgZW5hYmxlIGhvb2suIFNvIEkgZ3Vlc3MgYWRkIGEgcGxsCnBvc3QgZW5hYmxlIGhvb2suCgpC
ZWxvdydzIHNvbWUgZHJhZnQgY29kZSB0byBnaXZlIGFuIGlkZWEgd2hhdCBJIG1lYW4uIFlvdSdk
IG1vdmUgdGhlCmFib3ZlIGh1bmsgdG8gdGhlIHBvc3QgaG9vayBpbnN0ZWFkLgoKU28gdGhlbiB3
ZSdkIGFkZCBtaWRfcGxsX2VuYWJsZSBob29rcyBhbmQgZG8gdGhlIHJlcXVpcmVkIG1hZ2ljIGlu
IHRoZQpEU0kgbWlkIHBsbCBob29rLgoKT3ZlcmFsbCBJJ20gc3RhcnRpbmcgdG8gZmVlbCB0aGUg
YXBwZWFsIG9mIGRyaXZpbmcgbW9kZXNldCBmcm9tCmVuY29kZXJzLCB3aXRoIGxpYnJhcnkgc3R5
bGUgaGVscGVycyBwcm92aWRlZCBmcm9tIGludGVsX2Rpc3BsYXkuYywKaW5zdGVhZCBvZiBhZGRp
bmcgbW9yZSBhbmQgbW9yZSBlbmNvZGVyIGhvb2tzIHRvIGRvIHN0dWZmIGF0IHNwZWNpZmljCnBs
YWNlcy4gQnV0IEkgZGlncmVzcy4KCkJSLApKYW5pLgoKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf
ZHBsbF9tZ3IuYwppbmRleCBlNmNhYzkyMjU1MzYuLmE0Y2ExYjRhMTI0YyAxMDA2NDQKLS0tIGEv
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuYworKysgYi9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCkBAIC0xOTEsNiArMTkxLDEyIEBAIHZvaWQgaW50ZWxf
ZW5hYmxlX3NoYXJlZF9kcGxsKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQogCiAJRFJNX0RFQlVH
X0tNUygiZW5hYmxpbmcgJXNcbiIsIHBsbC0+aW5mby0+bmFtZSk7CiAJcGxsLT5pbmZvLT5mdW5j
cy0+ZW5hYmxlKGRldl9wcml2LCBwbGwpOworCisJaW50ZWxfZW5jb2RlcnNfbWlkX3BsbF9lbmFi
bGUoY3J0Yyk7IC8qIHBpcGVfY29uZmlnLCBvbGRfc3RhdGU/ICovCisKKwlpZiAocGxsLT5pbmZv
LT5mdW5jcy0+cG9zdF9lbmFibGUpCisJCXBsbC0+aW5mby0+ZnVuY3MtPnBvc3RfZW5hYmxlKGRl
dl9wcml2LCBwbGwpOworCiAJcGxsLT5vbiA9IHRydWU7CiAKIG91dDoKQEAgLTMxOTksNiArMzIw
NSw3IEBAIHN0YXRpYyB2b2lkIGljbF9kdW1wX2h3X3N0YXRlKHN0cnVjdCBkcm1faTkxNV9wcml2
YXRlICpkZXZfcHJpdiwKIAogc3RhdGljIGNvbnN0IHN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbF9m
dW5jcyBpY2xfcGxsX2Z1bmNzID0gewogCS5lbmFibGUgPSBpY2xfcGxsX2VuYWJsZSwKKwkucG9z
dF9lbmFibGUgPSBpY2xfcGxsX3Bvc3RfZW5hYmxlLAogCS5kaXNhYmxlID0gaWNsX3BsbF9kaXNh
YmxlLAogCS5nZXRfaHdfc3RhdGUgPSBpY2xfcGxsX2dldF9od19zdGF0ZSwKIH07CmRpZmYgLS1n
aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5oIGIvZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaAppbmRleCBiZjBkZThhNGRjNjMuLmVjZWVlZjNiODg3
MiAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHBsbF9tZ3IuaAorKysg
Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5oCkBAIC0yMzEsNiArMjMxLDE2
IEBAIHN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbF9mdW5jcyB7CiAJCSAgICAgICBzdHJ1Y3QgaW50
ZWxfc2hhcmVkX2RwbGwgKnBsbCk7CiAKIAkvKioKKwkgKiBAcG9zdF9lbmFibGU6CisJICoKKwkg
KiBPcHRpb25hbCBob29rIHRvIGNhbGwgYWZ0ZXIgZW5jb2RlciBzcGVjaWZpYyBtaWQgcGxsIGhv
b2tzIGhhdmUgYmVlbgorCSAqIGNhbGxlZCBmcm9tIGludGVsX2VuYWJsZV9zaGFyZWRfZHBsbCgp
LgorCSAqLworCXZvaWQgKCpwb3N0X2VuYWJsZSkoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl
dl9wcml2LAorCQkJICAgIHN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbCAqcGxsKTsKKworCisJLyoq
CiAJICogQGRpc2FibGU6CiAJICoKIAkgKiBIb29rIGZvciBkaXNhYmxpbmcgdGhlIHBsbCwgY2Fs
bGVkIGZyb20gaW50ZWxfZGlzYWJsZV9zaGFyZWRfZHBsbCgpCgoKCi0tIApKYW5pIE5pa3VsYSwg
SW50ZWwgT3BlbiBTb3VyY2UgR3JhcGhpY3MgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4
QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls
bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=