From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915/dp: optimize eDP 1.4+ link config fast and narrow Date: Thu, 27 Sep 2018 14:15:26 +0300 Message-ID: <87pnwzry29.fsf@intel.com> References: <20180905095321.13843-1-jani.nikula@intel.com> <20180927101045.GA3651@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 677DC6E58B for ; Thu, 27 Sep 2018 11:15:28 +0000 (UTC) In-Reply-To: <20180927101045.GA3651@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Manasi Navare Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAyNyBTZXAgMjAxOCwgTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVs LmNvbT4gd3JvdGU6Cj4gT24gV2VkLCBTZXAgMDUsIDIwMTggYXQgMTI6NTM6MjFQTSArMDMwMCwg SmFuaSBOaWt1bGEgd3JvdGU6Cj4+IFdlJ3ZlIG9wdGVkIHRvIHVzZSB0aGUgbWF4aW11bSBsaW5r IHJhdGUgYW5kIGxhbmUgY291bnQgZm9yIGVEUCBwYW5lbHMsCj4+IGJlY2F1c2UgdHlwaWNhbGx5 IHRoZSBtYXhpbXVtIHN1cHBvcnRlZCBjb25maWd1cmF0aW9uIHJlcG9ydGVkIGJ5IHRoZQo+PiBw YW5lbCBoYXMgbWF0Y2hlZCB0aGUgbmF0aXZlIHJlc29sdXRpb24gcmVxdWlyZW1lbnRzIG9mIHRo ZSBwYW5lbCwgYW5kCj4+IG9wdGltaXppbmcgdGhlIGxpbmsgaGFzIGxlYWQgdG8gcHJvYmxlbXMu Cj4+IAo+PiBXaXRoIGVEUCAxLjQgcmF0ZSBzZWxlY3QgbWV0aG9kIGFuZCBEU0MgZmVhdHVyZXMs IHRoaXMgaXMgZGVjcmVhc2luZ2x5Cj4+IHRoZSBjYXNlLiBUaGVyZSdzIGEgbmVlZCB0byBvcHRp bWl6ZSB0aGUgbGluayBwYXJhbWV0ZXJzLiBNb3Jlb3ZlciwKPj4gYWxyZWFkeSBlRFAgMS4zIHN0 YXRlcyBmYXN0IGxpbmsgd2l0aCBmZXdlciBsYW5lcyBpcyBwcmVmZXJyZWQgb3ZlciB0aGUKPj4g d2lkZSBhbmQgc2xvdy4gKFdpZGUgYW5kIHNsb3cgc2hvdWxkIHN0aWxsIGJlIG1vcmUgcmVsaWFi bGUgZm9yIGxvbmdlcgo+PiBjYWJsZSBsZW5ndGhzLikKPj4gCj4+IEFkZGl0aW9uYWxseSwgdGhl cmUgaGF2ZSBiZWVuIHJlcG9ydHMgb2YgcGFuZWxzIGZhaWxpbmcgb24gYXJiaXRyYXJ5Cj4+IGxp bmsgY29uZmlndXJhdGlvbnMsIGFsdGhvdWdoIGFyZ3VhYmx5IGFsbCBjb25maWd1cmF0aW9ucyB0 aGV5IGNsYWltIHRvCj4+IHN1cHBvcnQgc2hvdWxkIHdvcmsuCj4+IAo+PiBPcHRpbWl6ZSBlRFAg MS40KyBsaW5rIGNvbmZpZyBmYXN0IGFuZCBuYXJyb3cuCj4+IAo+PiBTaWRlIG5vdGU6IFRoZSBp bXBsZW1lbnRhdGlvbiBoYXMgYSBuZWFyIGR1cGxpY2F0ZSBvZiB0aGUgbGluayBjb25maWcKPj4g ZnVuY3Rpb24sIHdpdGgganVzdCB0aGUgdHdvIGlubmVyIGZvciBsb29wcyB0dXJuZWQgaW5zaWRl IG91dC4gUGVyaGFwcwo+PiB0aGVyZSdkIGJlIGEgd2F5IHRvIG1ha2UgdGhpcywgc2F5LCBtb3Jl IHRhYmxlIGRyaXZlbiB0byByZWR1Y2UgdGhlCj4+IGR1cGxpY2F0aW9uLCBidXQgc2VlbXMgbGlr ZSB0aGF0IHdvdWxkIGxlYWQgdG8gZHVwbGljYXRpb24gaW4gdGhlIHRhYmxlCj4+IGdlbmVyYXRp b24uIFdlJ2xsIGFsc28gaGF2ZSB0byBzZWUgaG93IHRoZSBsaW5rIGNvbmZpZyBvcHRpbWl6YXRp b24gZm9yCj4+IERTQyB0dXJucyBvdXQuCj4+IAo+PiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxs ZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPj4gQ2M6IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5k Lm5hdmFyZUBpbnRlbC5jb20+Cj4+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRl bC5jb20+Cj4+IENjOiBNYXR0IEF0d29vZCA8bWF0dGhldy5zLmF0d29vZEBpbnRlbC5jb20+Cj4+ IENjOiAiTGVlLCBTaGF3biBDIiA8c2hhd24uYy5sZWVAaW50ZWwuY29tPgo+PiBBY2tlZC1ieTog Um9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+PiBCdWd6aWxsYTogaHR0cHM6 Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA1MjY3Cj4+IFNpZ25lZC1v ZmYtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4+IAo+PiAtLS0KPj4g Cj4+IHYyIG9mIGh0dHA6Ly9wYXRjaHdvcmsuZnJlZWRlc2t0b3Aub3JnL3BhdGNoL21zZ2lkLzIw MTgwNTA5MDcxMzIxLjI4NTYzLTEtamFuaS5uaWt1bGFAaW50ZWwuY29tCj4+IAo+PiBVbnRlc3Rl ZC4gSXQncyBwb3NzaWJsZSB0aGlzIGhlbHBzIHRoZSByZWZlcmVuY2VkIGJ1Zy4gVGhlIGRvd25z aWRlIGlzCj4+IHRoYXQgdGhpcyBwYXRjaCBoYXMgYSBidW5jaCBvZiBkZXBlbmRlbmNpZXMgdGhh dCBhcmUgdG9vIG11Y2ggdG8KPj4gYmFja3BvcnQgdG8gc3RhYmxlIGtlcm5lbHMuIElmIHRoZSBw YXRjaCB3b3Jrcywgd2UgbWF5IG5lZWQgdG8gY29uc2lkZXIKPj4gaGFja2luZyB0b2dldGhlciBh biB1Z2xpZXIgYmFja3BvcnQuCj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHAuYyB8IDczICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tCj4+ICAx IGZpbGUgY2hhbmdlZCwgNjIgaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCj4+IAo+PiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RwLmMKPj4gaW5kZXggNDM2YzIyZGUzM2I2Li5iZjdiOTE4MzJjOGEg MTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+PiBAQCAtMTkyMSw2ICsxOTIxLDQyIEBA IGludGVsX2RwX2NvbXB1dGVfbGlua19jb25maWdfd2lkZShzdHJ1Y3QgaW50ZWxfZHAgKmludGVs X2RwLAo+PiAgCXJldHVybiBmYWxzZTsKPj4gIH0KPj4gIAo+PiArLyogT3B0aW1pemUgbGluayBj b25maWcgaW4gb3JkZXI6IG1heCBicHAsIG1pbiBsYW5lcywgbWluIGNsb2NrICovCj4+ICtzdGF0 aWMgYm9vbAo+PiAraW50ZWxfZHBfY29tcHV0ZV9saW5rX2NvbmZpZ19mYXN0KHN0cnVjdCBpbnRl bF9kcCAqaW50ZWxfZHAsCj4+ICsJCQkJICBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9j b25maWcsCj4+ICsJCQkJICBjb25zdCBzdHJ1Y3QgbGlua19jb25maWdfbGltaXRzICpsaW1pdHMp Cj4+ICt7Cj4+ICsJc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKmFkanVzdGVkX21vZGUgPSAmcGlw ZV9jb25maWctPmJhc2UuYWRqdXN0ZWRfbW9kZTsKPj4gKwlpbnQgYnBwLCBjbG9jaywgbGFuZV9j b3VudDsKPj4gKwlpbnQgbW9kZV9yYXRlLCBsaW5rX2Nsb2NrLCBsaW5rX2F2YWlsOwo+PiArCj4+ ICsJZm9yIChicHAgPSBsaW1pdHMtPm1heF9icHA7IGJwcCA+PSBsaW1pdHMtPm1pbl9icHA7IGJw cCAtPSAyICogMykgewo+PiArCQltb2RlX3JhdGUgPSBpbnRlbF9kcF9saW5rX3JlcXVpcmVkKGFk anVzdGVkX21vZGUtPmNydGNfY2xvY2ssCj4+ICsJCQkJCQkgICBicHApOwo+PiArCj4+ICsJCWZv ciAobGFuZV9jb3VudCA9IGxpbWl0cy0+bWluX2xhbmVfY291bnQ7Cj4+ICsJCSAgICAgbGFuZV9j b3VudCA8PSBsaW1pdHMtPm1heF9sYW5lX2NvdW50Owo+PiArCQkgICAgIGxhbmVfY291bnQgPDw9 IDEpIHsKPj4gKwkJCWZvciAoY2xvY2sgPSBsaW1pdHMtPm1pbl9jbG9jazsgY2xvY2sgPD0gbGlt aXRzLT5tYXhfY2xvY2s7IGNsb2NrKyspIHsKPj4gKwkJCQlsaW5rX2Nsb2NrID0gaW50ZWxfZHAt PmNvbW1vbl9yYXRlc1tjbG9ja107Cj4+ICsJCQkJbGlua19hdmFpbCA9IGludGVsX2RwX21heF9k YXRhX3JhdGUobGlua19jbG9jaywKPj4gKwkJCQkJCQkJICAgIGxhbmVfY291bnQpOwo+PiArCj4+ ICsJCQkJaWYgKG1vZGVfcmF0ZSA8PSBsaW5rX2F2YWlsKSB7Cj4+ICsJCQkJCXBpcGVfY29uZmln LT5sYW5lX2NvdW50ID0gbGFuZV9jb3VudDsKPj4gKwkJCQkJcGlwZV9jb25maWctPnBpcGVfYnBw ID0gYnBwOwo+PiArCQkJCQlwaXBlX2NvbmZpZy0+cG9ydF9jbG9jayA9IGxpbmtfY2xvY2s7Cj4+ ICsKPj4gKwkJCQkJcmV0dXJuIHRydWU7Cj4+ICsJCQkJfQo+PiArCQkJfQo+PiArCQl9Cj4+ICsJ fQo+PiArCj4+ICsJcmV0dXJuIGZhbHNlOwo+PiArfQo+PiArCj4+ICBzdGF0aWMgYm9vbAo+PiAg aW50ZWxfZHBfY29tcHV0ZV9saW5rX2NvbmZpZyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2Rl ciwKPj4gIAkJCSAgICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnKQo+PiBA QCAtMTk0NSwxMyArMTk4MSwxNSBAQCBpbnRlbF9kcF9jb21wdXRlX2xpbmtfY29uZmlnKHN0cnVj dCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+PiAgCWxpbWl0cy5taW5fYnBwID0gNiAqIDM7Cj4+ ICAJbGltaXRzLm1heF9icHAgPSBpbnRlbF9kcF9jb21wdXRlX2JwcChpbnRlbF9kcCwgcGlwZV9j b25maWcpOwo+PiAgCj4+IC0JaWYgKGludGVsX2RwX2lzX2VkcChpbnRlbF9kcCkpIHsKPj4gKwlp ZiAoaW50ZWxfZHBfaXNfZWRwKGludGVsX2RwKSAmJiBpbnRlbF9kcC0+ZWRwX2RwY2RbMF0gPCBE UF9FRFBfMTQpIHsKPj4gIAkJLyoKPj4gIAkJICogVXNlIHRoZSBtYXhpbXVtIGNsb2NrIGFuZCBu dW1iZXIgb2YgbGFuZXMgdGhlIGVEUCBwYW5lbAo+PiAtCQkgKiBhZHZlcnRpemVzIGJlaW5nIGNh cGFibGUgb2YuIFRoZSBwYW5lbHMgYXJlIGdlbmVyYWxseQo+PiAtCQkgKiBkZXNpZ25lZCB0byBz dXBwb3J0IG9ubHkgYSBzaW5nbGUgY2xvY2sgYW5kIGxhbmUKPj4gLQkJICogY29uZmlndXJhdGlv biwgYW5kIHR5cGljYWxseSB0aGVzZSB2YWx1ZXMgY29ycmVzcG9uZCB0byB0aGUKPj4gLQkJICog bmF0aXZlIHJlc29sdXRpb24gb2YgdGhlIHBhbmVsLgo+PiArCQkgKiBhZHZlcnRpemVzIGJlaW5n IGNhcGFibGUgb2YuIFRoZSBlRFAgMS4zIGFuZCBlYXJsaWVyIHBhbmVscwo+PiArCQkgKiBhcmUg Z2VuZXJhbGx5IGRlc2lnbmVkIHRvIHN1cHBvcnQgb25seSBhIHNpbmdsZSBjbG9jayBhbmQKPj4g KwkJICogbGFuZSBjb25maWd1cmF0aW9uLCBhbmQgdHlwaWNhbGx5IHRoZXNlIHZhbHVlcyBjb3Jy ZXNwb25kIHRvCj4+ICsJCSAqIHRoZSBuYXRpdmUgcmVzb2x1dGlvbiBvZiB0aGUgcGFuZWwuIFdp dGggZURQIDEuNCByYXRlIHNlbGVjdAo+PiArCQkgKiBhbmQgRFNDLCB0aGlzIGlzIGRlY3JlYXNp bmdseSB0aGUgY2FzZSwgYW5kIHdlIG5lZWQgdG8gYmUKPj4gKwkJICogYWJsZSB0byBzZWxlY3Qg bGVzcyB0aGFuIG1heGltdW0gbGluayBjb25maWcuCj4+ICAJCSAqLwo+PiAgCQlsaW1pdHMubWlu X2xhbmVfY291bnQgPSBsaW1pdHMubWF4X2xhbmVfY291bnQ7Cj4+ICAJCWxpbWl0cy5taW5fY2xv Y2sgPSBsaW1pdHMubWF4X2Nsb2NrOwo+PiBAQCAtMTk2NSwxMiArMjAwMywyNSBAQCBpbnRlbF9k cF9jb21wdXRlX2xpbmtfY29uZmlnKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+PiAg CQkgICAgICBpbnRlbF9kcC0+Y29tbW9uX3JhdGVzW2xpbWl0cy5tYXhfY2xvY2tdLAo+PiAgCQkg ICAgICBsaW1pdHMubWF4X2JwcCwgYWRqdXN0ZWRfbW9kZS0+Y3J0Y19jbG9jayk7Cj4+ICAKPj4g LQkvKgo+PiAtCSAqIE9wdGltaXplIGZvciBzbG93IGFuZCB3aWRlLiBUaGlzIGlzIHRoZSBwbGFj ZSB0byBhZGQgYWx0ZXJuYXRpdmUKPj4gLQkgKiBvcHRpbWl6YXRpb24gcG9saWN5Lgo+PiAtCSAq Lwo+PiAtCWlmICghaW50ZWxfZHBfY29tcHV0ZV9saW5rX2NvbmZpZ193aWRlKGludGVsX2RwLCBw aXBlX2NvbmZpZywgJmxpbWl0cykpCj4+IC0JCXJldHVybiBmYWxzZTsKPj4gKwlpZiAoaW50ZWxf ZHBfaXNfZWRwKGludGVsX2RwKSkgewo+Cj4gTml0cGljayBiZWxvdzoKPiBDYW4gd2UgbmVzdCB0 aGUgZWRwX3JldiA8IERQX0VEUF8xNCBjb25kaXRpb24gd2l0aGluIHRoaXMgaWYgY29uZGl0aW9u PyBMaWtlIGJlbG93Ogo+Cj4gCQlpZiAoaW50ZWxfZHAtPmVkcF9kcGNkWzBdIDwgRFBfRURQXzE0 KSB7Cj4gCQkJbGltaXRzLm1pbl9sYW5lX2NvdW50ID0gbGltaXRzLm1heF9sYW5lX2NvdW50Owo+ IAkJCWxpbWl0cy5taW5fY2xvY2sgPSBsaW1pdHMubWF4X2Nsb2NrOwo+IAkJfQoKRG9pbmcgdGhh dCB3b3VsZCByZXF1aXJlIGR1cGxpY2F0aW5nIHRoZSBkZWJ1ZyBsb2dnaW5nIHRvIGJvdGggYnJh bmNoZXMKb2YgdGhlIGlmIChpbnRlbF9kcF9pc19lZHAoaW50ZWxfZHApKSBjb25kaXRpb24uCgpC UiwKSmFuaS4KCj4KPiBXaXRoIHRoYXQsCj4KPiBSZXZpZXdlZC1ieTogTWFuYXNpIE5hdmFyZSA8 bWFuYXNpLmQubmF2YXJlQGludGVsLmNvbT4KPgo+IE1hbmFzaQo+Cj4+ICsJCS8qCj4+ICsJCSAq IE9wdGltaXplIGZvciBmYXN0IGFuZCBuYXJyb3cuIGVEUCAxLjMgc2VjdGlvbiAzLjMgYW5kIGVE UCAxLjQKPj4gKwkJICogc2VjdGlvbiBBLjE6ICJJdCBpcyByZWNvbW1lbmRlZCB0aGF0IHRoZSBt aW5pbXVtIG51bWJlciBvZgo+PiArCQkgKiBsYW5lcyBiZSB1c2VkLCB1c2luZyB0aGUgbWluaW11 bSBsaW5rIHJhdGUgYWxsb3dlZCBmb3IgdGhhdAo+PiArCQkgKiBsYW5lIGNvbmZpZ3VyYXRpb24u Igo+PiArCQkgKgo+PiArCQkgKiBOb3RlIHRoYXQgd2UgdXNlIHRoZSBtYXggY2xvY2sgYW5kIGxh bmUgY291bnQgZm9yIGVEUCAxLjMgYW5kCj4+ICsJCSAqIGVhcmxpZXIsIGFuZCBmYXN0IHZzLiB3 aWRlIGlzIGlycmVsZXZhbnQuCj4+ICsJCSAqLwo+PiArCQlpZiAoIWludGVsX2RwX2NvbXB1dGVf bGlua19jb25maWdfZmFzdChpbnRlbF9kcCwgcGlwZV9jb25maWcsCj4+ICsJCQkJCQkgICAgICAg JmxpbWl0cykpCj4+ICsJCQlyZXR1cm4gZmFsc2U7Cj4+ICsJfSBlbHNlIHsKPj4gKwkJLyogT3B0 aW1pemUgZm9yIHNsb3cgYW5kIHdpZGUuICovCj4+ICsJCWlmICghaW50ZWxfZHBfY29tcHV0ZV9s aW5rX2NvbmZpZ193aWRlKGludGVsX2RwLCBwaXBlX2NvbmZpZywKPj4gKwkJCQkJCSAgICAgICAm bGltaXRzKSkKPj4gKwkJCXJldHVybiBmYWxzZTsKPj4gKwl9Cj4+ICAKPj4gIAlEUk1fREVCVUdf S01TKCJEUCBsYW5lIGNvdW50ICVkIGNsb2NrICVkIGJwcCAlZFxuIiwKPj4gIAkJICAgICAgcGlw ZV9jb25maWctPmxhbmVfY291bnQsIHBpcGVfY29uZmlnLT5wb3J0X2Nsb2NrLAo+PiAtLSAKPj4g Mi4xMS4wCj4+IAoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBD ZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==