From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Introduce BITS_PER_TYPE Date: Wed, 26 Sep 2018 13:58:48 +0300 Message-ID: <87pnx0tthz.fsf@intel.com> References: <20180926104707.17410-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7B33C89B06 for ; Wed, 26 Sep 2018 10:59:41 +0000 (UTC) In-Reply-To: <20180926104707.17410-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyNiBTZXAgMjAxOCwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+IHdyb3RlOgo+IEJvcnJvdyB0aGUgaWRlYSBmcm9tIG5ldF9kaW0uaCB0byBzaW1wbGlmeSB0 aGUgY29tbW9uIGRldGVybWluYXRpb24gb2YKPiBob3cgbWFueSBiaXRzIGluIGEgcGFydGljdWxh ciB0eXBlIChzaXplb2YodHlwZSkgKiBCSVRTX1BFUl9CWVRFKS4KCkkgZ3Vlc3MgdGhlIGNvbW1p dCBtZXNzYWdlIHdhcyB3cml0dGVuIGJlZm9yZSB5b3UgYWRkZWQgQklUU19QRVJfVFlQRSB0bwpi aXRvcHMuaC4gV2l0aCB0aGF0IHVwZGF0ZWQsCgpSZXZpZXdlZC1ieTogSmFuaSBOaWt1bGEgPGph bmkubmlrdWxhQGludGVsLmNvbT4KCj4gU3VnZ2VzdGVkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZp bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNv biA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFA aW50ZWwuY29tPgo+IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5p bnRlbC5jb20+Cj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+ Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgICAgICAgICAgfCA0ICsr LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyAgICAgICAgICB8IDIgKy0KPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9xdWVyeS5jICAgICAgICB8IDIgKy0KPiAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9zeW5jbWFwLmMgICAgICB8IDIgKy0KPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV91dGlscy5oICAgICAgICB8IDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGV2aWNlX2luZm8uYyB8IDMgKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2VuZ2luZV9jcy5jICAgfCAyICstCj4gIDcgZmlsZXMgY2hhbmdlZCwgOCBpbnNlcnRpb25z KCspLCA5IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gaW5kZXggNDRl MmMwZjVlYzUwLi5hZGU5YmNhMjUwZmEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiBA QCAtMTY0OSw4ICsxNjQ5LDggQEAgaTkxNV9kcml2ZXJfY3JlYXRlKHN0cnVjdCBwY2lfZGV2ICpw ZGV2LCBjb25zdCBzdHJ1Y3QgcGNpX2RldmljZV9pZCAqZW50KQo+ICAJZGV2aWNlX2luZm8tPmRl dmljZV9pZCA9IHBkZXYtPmRldmljZTsKPiAgCj4gIAlCVUlMRF9CVUdfT04oSU5URUxfTUFYX1BM QVRGT1JNUyA+Cj4gLQkJICAgICBzaXplb2YoZGV2aWNlX2luZm8tPnBsYXRmb3JtX21hc2spICog QklUU19QRVJfQllURSk7Cj4gLQlCVUdfT04oZGV2aWNlX2luZm8tPmdlbiA+IHNpemVvZihkZXZp Y2VfaW5mby0+Z2VuX21hc2spICogQklUU19QRVJfQllURSk7Cj4gKwkJICAgICBCSVRTX1BFUl9U WVBFKGRldmljZV9pbmZvLT5wbGF0Zm9ybV9tYXNrKSk7Cj4gKwlCVUdfT04oZGV2aWNlX2luZm8t PmdlbiA+IEJJVFNfUEVSX1RZUEUoZGV2aWNlX2luZm8tPmdlbl9tYXNrKSk7Cj4gIAo+ICAJcmV0 dXJuIGk5MTU7Cj4gIH0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiBpbmRleCBkYjk2ODhkMTQ5 MTIuLjcxN2Y0MzIxZTk4NyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+IEBAIC01OTU5 LDcgKzU5NTksNyBAQCB2b2lkIGk5MTVfZ2VtX3RyYWNrX2ZiKHN0cnVjdCBkcm1faTkxNV9nZW1f b2JqZWN0ICpvbGQsCj4gIAkgKiB0aGUgYml0cy4KPiAgCSAqLwo+ICAJQlVJTERfQlVHX09OKElO VEVMX0ZST05UQlVGRkVSX0JJVFNfUEVSX1BJUEUgKiBJOTE1X01BWF9QSVBFUyA+Cj4gLQkJICAg ICBzaXplb2YoYXRvbWljX3QpICogQklUU19QRVJfQllURSk7Cj4gKwkJICAgICBCSVRTX1BFUl9U WVBFKGF0b21pY190KSk7Cj4gIAo+ICAJaWYgKG9sZCkgewo+ICAJCVdBUk5fT04oIShhdG9taWNf cmVhZCgmb2xkLT5mcm9udGJ1ZmZlcl9iaXRzKSAmIGZyb250YnVmZmVyX2JpdHMpKTsKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9xdWVyeS5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9xdWVyeS5jCj4gaW5kZXggM2Y1MDJlZWYyNDMxLi41ODIxMDAyY2FkNDIg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9xdWVyeS5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9xdWVyeS5jCj4gQEAgLTI4LDcgKzI4LDcgQEAgc3Rh dGljIGludCBxdWVyeV90b3BvbG9neV9pbmZvKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdiwKPiAgCXNsaWNlX2xlbmd0aCA9IHNpemVvZihzc2V1LT5zbGljZV9tYXNrKTsKPiAgCXN1 YnNsaWNlX2xlbmd0aCA9IHNzZXUtPm1heF9zbGljZXMgKgo+ICAJCURJVl9ST1VORF9VUChzc2V1 LT5tYXhfc3Vic2xpY2VzLAo+IC0JCQkgICAgIHNpemVvZihzc2V1LT5zdWJzbGljZV9tYXNrWzBd KSAqIEJJVFNfUEVSX0JZVEUpOwo+ICsJCQkgICAgIEJJVFNfUEVSX1RZUEUoc3NldS0+c3Vic2xp Y2VfbWFza1swXSkpOwo+ICAJZXVfbGVuZ3RoID0gc3NldS0+bWF4X3NsaWNlcyAqIHNzZXUtPm1h eF9zdWJzbGljZXMgKgo+ICAJCURJVl9ST1VORF9VUChzc2V1LT5tYXhfZXVzX3Blcl9zdWJzbGlj ZSwgQklUU19QRVJfQllURSk7Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X3N5bmNtYXAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfc3luY21hcC5jCj4g aW5kZXggNThmOGQwY2MxMjVjLi42MDQwNGRiYjJlOWYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9zeW5jbWFwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X3N5bmNtYXAuYwo+IEBAIC05Miw3ICs5Miw3IEBAIHZvaWQgaTkxNV9zeW5jbWFwX2luaXQo c3RydWN0IGk5MTVfc3luY21hcCAqKnJvb3QpCj4gIHsKPiAgCUJVSUxEX0JVR19PTl9OT1RfUE9X RVJfT0ZfMihLU1lOQ01BUCk7Cj4gIAlCVUlMRF9CVUdfT05fTk9UX1BPV0VSX09GXzIoU0hJRlQp Owo+IC0JQlVJTERfQlVHX09OKEtTWU5DTUFQID4gQklUU19QRVJfQllURSAqIHNpemVvZigoKnJv b3QpLT5iaXRtYXApKTsKPiArCUJVSUxEX0JVR19PTihLU1lOQ01BUCA+IEJJVFNfUEVSX1RZUEUo KCpyb290KS0+Yml0bWFwKSk7Cj4gIAkqcm9vdCA9IE5VTEw7Cj4gIH0KPiAgCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdXRpbHMuaCBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfdXRpbHMuaAo+IGluZGV4IDM5NWRkMjUxMTU2OC4uNTg1OGE0M2UxOWRhIDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdXRpbHMuaAo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfdXRpbHMuaAo+IEBAIC02OCw3ICs2OCw3IEBACj4gIAo+ICAv KiBOb3RlIHdlIGRvbid0IGNvbnNpZGVyIHNpZ25iaXRzIDp8ICovCj4gICNkZWZpbmUgb3ZlcmZs b3dzX3R5cGUoeCwgVCkgXAo+IC0JKHNpemVvZih4KSA+IHNpemVvZihUKSAmJiAoeCkgPj4gKHNp emVvZihUKSAqIEJJVFNfUEVSX0JZVEUpKQo+ICsJKHNpemVvZih4KSA+IHNpemVvZihUKSAmJiAo eCkgPj4gQklUU19QRVJfVFlQRShUKSkKPiAgCj4gICNkZWZpbmUgcHRyX21hc2tfYml0cyhwdHIs IG4pICh7CQkJCQlcCj4gIAl1bnNpZ25lZCBsb25nIF9fdiA9ICh1bnNpZ25lZCBsb25nKShwdHIp OwkJCVwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGV2aWNlX2lu Zm8uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RldmljZV9pbmZvLmMKPiBpbmRleCAw ZWYwYzY0NDhkNTMuLjMxZjZiZTc3NDgzMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kZXZpY2VfaW5mby5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGV2aWNlX2luZm8uYwo+IEBAIC03NTAsOCArNzUwLDcgQEAgdm9pZCBpbnRlbF9kZXZpY2Vf aW5mb19ydW50aW1lX2luaXQoc3RydWN0IGludGVsX2RldmljZV9pbmZvICppbmZvKQo+ICAJCWlu Zm8tPm51bV9zY2FsZXJzW1BJUEVfQ10gPSAxOwo+ICAJfQo+ICAKPiAtCUJVSUxEX0JVR19PTihJ OTE1X05VTV9FTkdJTkVTID4KPiAtCQkgICAgIHNpemVvZihpbnRlbF9yaW5nX21hc2tfdCkgKiBC SVRTX1BFUl9CWVRFKTsKPiArCUJVSUxEX0JVR19PTihJOTE1X05VTV9FTkdJTkVTID4gQklUU19Q RVJfVFlQRShpbnRlbF9yaW5nX21hc2tfdCkpOwo+ICAKPiAgCS8qCj4gIAkgKiBTa3lsYWtlIGFu ZCBCcm94dG9uIGN1cnJlbnRseSBkb24ndCBleHBvc2UgdGhlIHRvcG1vc3QgcGxhbmUgYXMgaXRz Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9jcy5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5lX2NzLmMKPiBpbmRleCAyMTdlZDNlZTFj YWIuLjY3MjZkNTdmMDE4ZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9lbmdpbmVfY3MuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2VuZ2luZV9j cy5jCj4gQEAgLTMzNSw3ICszMzUsNyBAQCBpbnQgaW50ZWxfZW5naW5lc19pbml0X21taW8oc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAKPiAgCVdBUk5fT04ocmluZ19tYXNr ID09IDApOwo+ICAJV0FSTl9PTihyaW5nX21hc2sgJgo+IC0JCUdFTk1BU0soc2l6ZW9mKG1hc2sp ICogQklUU19QRVJfQllURSAtIDEsIEk5MTVfTlVNX0VOR0lORVMpKTsKPiArCQlHRU5NQVNLKEJJ VFNfUEVSX1RZUEUobWFzaykgLSAxLCBJOTE1X05VTV9FTkdJTkVTKSk7Cj4gIAo+ICAJZm9yIChp ID0gMDsgaSA8IEFSUkFZX1NJWkUoaW50ZWxfZW5naW5lcyk7IGkrKykgewo+ICAJCWlmICghSEFT X0VOR0lORShkZXZfcHJpdiwgaSkpCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNl IEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl bC1nZngK