All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: linux-watchdog@vger.kernel.org, wim@linux-watchdog.org,
	Guenter Roeck <linux@roeck-us.net>,
	Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v3 4/4] arm64: dts: marvell: armada-37xx: add nodes to support watchdog
Date: Fri, 21 Sep 2018 12:48:26 +0200	[thread overview]
Message-ID: <87pnx7i0sl.fsf@bootlin.com> (raw)
In-Reply-To: <20180907130553.14271-5-marek.behun@nic.cz> ("Marek Behún"'s message of "Fri, 7 Sep 2018 15:05:53 +0200")

Hi Marek,
 
 On ven., sept. 07 2018, Marek Behún <marek.behun@nic.cz> wrote:

> This adds the system controller node for CPU Miscellaneous Registers
> (which is needed for the watchdog node) and the watchdog node.
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>


I just want to let you know that once you will modify the device tree
according to Rob's comment about the binding, I will apply this patch on
mvebu trees.

Thanks,

Gregory

> ---
>  arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> index d9531e242eb4..048b072080c2 100644
> --- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
> @@ -80,6 +80,18 @@
>  			/* 32M internal register @ 0xd000_0000 */
>  			ranges = <0x0 0x0 0xd0000000 0x2000000>;
>  
> +			wdt: watchdog-timer@8300 {
> +				compatible = "marvell,armada-3700-wdt";
> +				reg = <0x8300 0x40>;
> +				marvell,system-controller = <&cpu_misc>;
> +				clocks = <&xtalclk>;
> +			};
> +
> +			cpu_misc: system-controller@d000 {
> +				compatible = "syscon", "simple-mfd";
> +				reg = <0xd000 0x1000>;
> +			};
> +
>  			spi0: spi@10600 {
>  				compatible = "marvell,armada-3700-spi";
>  				#address-cells = <1>;
> -- 
> 2.16.4
>

-- 
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com

      reply	other threads:[~2018-09-21 16:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07 13:05 [PATCH v3 0/4] Add support for Armada 37xx CPU watchdog Marek Behún
2018-09-07 13:05 ` [PATCH v3 1/4] watchdog: " Marek Behún
2018-09-07 19:40   ` Guenter Roeck
2018-09-24  9:18   ` Miquel Raynal
2018-09-07 13:05 ` [PATCH v3 2/4] dt-bindings: watchdog: Document armada-37xx-wdt binding Marek Behún
2018-09-10 21:21   ` Rob Herring
2018-09-10 21:21     ` Rob Herring
2018-09-07 13:05 ` [PATCH v3 3/4] documentation: watchdog: add documentation for armada-37xx-wdt Marek Behún
2018-09-16  0:52   ` [v3, " Guenter Roeck
2018-09-07 13:05 ` [PATCH v3 4/4] arm64: dts: marvell: armada-37xx: add nodes to support watchdog Marek Behún
2018-09-21 10:48   ` Gregory CLEMENT [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pnx7i0sl.fsf@bootlin.com \
    --to=gregory.clement@bootlin.com \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=marek.behun@nic.cz \
    --cc=miquel.raynal@bootlin.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.