From: Markus Armbruster <armbru@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>,
thuth@redhat.com, sagark@eecs.berkeley.edu, mst@redhat.com,
qemu-trivial@nongnu.org, kbastian@mail.uni-paderborn.de,
palmer@sifive.com, qemu-devel@nongnu.org, agraf@suse.de,
mjc@sifive.com, qemu-ppc@nongnu.org, pbonzini@redhat.com,
david@gibson.dropbear.id.au, rth@twiddle.net
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Drop the "qemu:" prefix from error_report()
Date: Thu, 20 Sep 2018 20:59:51 +0200 [thread overview]
Message-ID: <87pnx8dmfs.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20180920173453.GP30558@habkost.net> (Eduardo Habkost's message of "Thu, 20 Sep 2018 14:34:53 -0300")
Eduardo Habkost <ehabkost@redhat.com> writes:
> On Thu, Sep 20, 2018 at 07:08:32AM -0400, Mao Zhongyi wrote:
>> error_report and friends already add a "qemu-system-xxx" prefix
>> to the string, so a "qemu:" prefix is redundant in the string.
>> Just drop it.
>>
>> Reported-by: Thomas Huth <thuth@redhat.com>
>> Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
>
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
>
> Markus, do you want to merge it through your tree?
Yes.
> If we are already touching those messages, it would be nice if we
> removed punctuation too on some cases below[1].
Yes. Done in my tree.
I'm also tweaking the subject to
Drop "qemu:" prefix from error_report() arguments
Queued, thanks!
next prev parent reply other threads:[~2018-09-20 19:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 11:08 [Qemu-trivial] [PATCH] Drop the "qemu:" prefix from error_report() Mao Zhongyi
2018-09-20 17:34 ` Eduardo Habkost
2018-09-20 17:39 ` [Qemu-trivial] [Qemu-devel] " Peter Maydell
2018-09-21 1:18 ` Mao Zhongyi
2018-09-20 18:59 ` Markus Armbruster [this message]
2018-09-21 1:28 ` [Qemu-trivial] " Mao Zhongyi
2018-09-21 0:49 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pnx8dmfs.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=maozhongyi@cmss.chinamobile.com \
--cc=mjc@sifive.com \
--cc=mst@redhat.com \
--cc=palmer@sifive.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
--cc=sagark@eecs.berkeley.edu \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.