From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 2/3] drm/i915/csr: keep max firmware size together with firmare name and version Date: Thu, 06 Sep 2018 13:30:40 +0300 Message-ID: <87pnxqzzn3.fsf@intel.com> References: <20180906082126.15539-1-jani.nikula@intel.com> <20180906082126.15539-2-jani.nikula@intel.com> <153622677574.3050.8290289100524994402@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6FE686E67E for ; Thu, 6 Sep 2018 10:31:08 +0000 (UTC) In-Reply-To: <153622677574.3050.8290289100524994402@skylake-alporthouse-com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCAwNiBTZXAgMjAxOCwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+IHdyb3RlOgo+IFF1b3RpbmcgSmFuaSBOaWt1bGEgKDIwMTgtMDktMDYgMDk6MjE6MjUpCj4+ IE1vdmUgbWF4IGZpcm13YXJlIHNpemUgdG8gdGhlIHNhbWUgaWYgbGFkZGVyIHdpdGggZmlybXdh cmUgbmFtZSBhbmQKPj4gcmVxdWlyZWQgdmVyc2lvbi4gVGhpcyBhbGxvd3MgdXMgdG8gZGV0ZWN0 IHRoZSBtaXNzaW5nIG1heCBzaXplIGZvciBhCj4+IHBsYXRmb3JtIHdpdGhvdXQgYWN0dWFsbHkg bG9hZGluZyB0aGUgZmlybXdhcmUsIGFuZCBtYWtlcyB0aGUgd2hvbGUKPj4gdGhpbmcgZWFzaWVy IHRvIG1haW50YWluLgo+PiAKPj4gV2UgbmVlZCB0byBtb3ZlIHRoZSBwb3dlciBnZXQgZWFybGll ciB0byBhbGxvdyBmb3IgZWFybHkgcmV0dXJuIGluIHRoZQo+PiBtaXNzaW5nIHBsYXRmb3JtIGNh c2UuIFdlIGFsc28gbmVlZCB0byBtb3ZlIHRoZSBtb2R1bGUgcGFyYW1ldGVyCj4+IG92ZXJyaWRl IGxhdGVyIHRvIHJldXNlIHRoZSBtYXggZmlybXdhcmUgc2l6ZSwgd2hpY2ggaXMgaW5kZXBlbmRl bnQgb2YKPj4gdGhlIG92ZXJyaWRlLiBOb3RlIGhvdyB0aGlzIHdvcmtzIHdpdGggZ2VuIDExKyB3 aGljaCBkb24ndCBoYXZlIGEKPj4gc3BlY2lmaWVkIGZpcm13YXJlIGJsb2IgeWV0LCBidXQgZG8g aGF2ZSBhIG1heGltdW0gc2l6ZS4KPj4gCj4+IFNpZ25lZC1vZmYtYnk6IEphbmkgTmlrdWxhIDxq YW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuaCAgfCAgMyArKy0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Nzci5jIHwg NDEgKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLQo+PiAgMiBmaWxlcyBj aGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAyMCBkZWxldGlvbnMoLSkKPj4gCj4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9kcnYuaAo+PiBpbmRleCAzNjgwNjYwMTBmOTQuLjYyNDQ0ZjRjM2M4ZSAxMDA2NDQK Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+PiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4+IEBAIC00NjUsOCArNDY1LDkgQEAgc3RydWN0IGlu dGVsX2NzciB7Cj4+ICAgICAgICAgc3RydWN0IHdvcmtfc3RydWN0IHdvcms7Cj4+ICAgICAgICAg Y29uc3QgY2hhciAqZndfcGF0aDsKPj4gICAgICAgICB1aW50MzJfdCByZXF1aXJlZF92ZXJzaW9u Owo+PiArICAgICAgIHVpbnQzMl90IG1heF9md19zaXplOyAvKiBieXRlcyAqLwo+PiAgICAgICAg IHVpbnQzMl90ICpkbWNfcGF5bG9hZDsKPj4gLSAgICAgICB1aW50MzJfdCBkbWNfZndfc2l6ZTsK Pj4gKyAgICAgICB1aW50MzJfdCBkbWNfZndfc2l6ZTsgLyogZHdvcmRzICovCj4KPiBBcHByZWNp YXRlZC4KPgo+PiAgICAgICAgIHVpbnQzMl90IHZlcnNpb247Cj4+ICAgICAgICAgdWludDMyX3Qg bW1pb19jb3VudDsKPj4gICAgICAgICBpOTE1X3JlZ190IG1taW9hZGRyWzhdOwo+PiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3NyLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9jc3IuYwo+PiBpbmRleCA5YTYwYmI5Y2M0NDMuLjk1NmFjOGJiZjVlNCAxMDA2 NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3NyLmMKPj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3NyLmMKPj4gQEAgLTI4MSw3ICsyODEsNiBAQCBzdGF0 aWMgdWludDMyX3QgKnBhcnNlX2Nzcl9mdyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYsCj4+ICAgICAgICAgc3RydWN0IGludGVsX2NzciAqY3NyID0gJmRldl9wcml2LT5jc3I7Cj4+ ICAgICAgICAgY29uc3Qgc3RydWN0IHN0ZXBwaW5nX2luZm8gKnNpID0gaW50ZWxfZ2V0X3N0ZXBw aW5nX2luZm8oZGV2X3ByaXYpOwo+PiAgICAgICAgIHVpbnQzMl90IGRtY19vZmZzZXQgPSBDU1Jf REVGQVVMVF9GV19PRkZTRVQsIHJlYWRjb3VudCA9IDAsIG5ieXRlczsKPj4gLSAgICAgICB1aW50 MzJfdCBtYXhfZndfc2l6ZSA9IDA7Cj4+ICAgICAgICAgdWludDMyX3QgaTsKPj4gICAgICAgICB1 aW50MzJfdCAqZG1jX3BheWxvYWQ7Cj4+ICAKPj4gQEAgLTM3OCwxNSArMzc3LDcgQEAgc3RhdGlj IHVpbnQzMl90ICpwYXJzZV9jc3JfZncoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LAo+PiAgCj4+ICAgICAgICAgLyogZndfc2l6ZSBpcyBpbiBkd29yZHMsIHNvIG11bHRpcGxpZWQg YnkgNCB0byBjb252ZXJ0IGludG8gYnl0ZXMuICovCj4+ICAgICAgICAgbmJ5dGVzID0gZG1jX2hl YWRlci0+Zndfc2l6ZSAqIDQ7Cj4+IC0gICAgICAgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0g MTEpCj4+IC0gICAgICAgICAgICAgICBtYXhfZndfc2l6ZSA9IElDTF9DU1JfTUFYX0ZXX1NJWkU7 Cj4+IC0gICAgICAgZWxzZSBpZiAoSVNfQ0FOTk9OTEFLRShkZXZfcHJpdikgfHwgSVNfR0VNSU5J TEFLRShkZXZfcHJpdikpCj4+IC0gICAgICAgICAgICAgICBtYXhfZndfc2l6ZSA9IEdMS19DU1Jf TUFYX0ZXX1NJWkU7Cj4+IC0gICAgICAgZWxzZSBpZiAoSVNfR0VOOShkZXZfcHJpdikpCj4+IC0g ICAgICAgICAgICAgICBtYXhfZndfc2l6ZSA9IEJYVF9DU1JfTUFYX0ZXX1NJWkU7Cj4+IC0gICAg ICAgZWxzZQo+PiAtICAgICAgICAgICAgICAgTUlTU0lOR19DQVNFKElOVEVMX1JFVklEKGRldl9w cml2KSk7Cj4+IC0gICAgICAgaWYgKG5ieXRlcyA+IG1heF9md19zaXplKSB7Cj4+ICsgICAgICAg aWYgKG5ieXRlcyA+IGNzci0+bWF4X2Z3X3NpemUpIHsKPgo+IE9rLgo+PiAgICAgICAgICAgICAg ICAgRFJNX0VSUk9SKCJETUMgRlcgdG9vIGJpZyAoJXUgYnl0ZXMpXG4iLCBuYnl0ZXMpOwo+PiAg ICAgICAgICAgICAgICAgcmV0dXJuIE5VTEw7Cj4+ICAgICAgICAgfQo+PiBAQCAtNDUxLDMyICs0 NDIsNDQgQEAgdm9pZCBpbnRlbF9jc3JfdWNvZGVfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYpCj4+ICAgICAgICAgaWYgKCFIQVNfQ1NSKGRldl9wcml2KSkKPj4gICAgICAg ICAgICAgICAgIHJldHVybjsKPj4gIAo+PiAtICAgICAgIGlmIChpOTE1X21vZHBhcmFtcy5kbWNf ZmlybXdhcmVfcGF0aCkgewo+PiAtICAgICAgICAgICAgICAgY3NyLT5md19wYXRoID0gaTkxNV9t b2RwYXJhbXMuZG1jX2Zpcm13YXJlX3BhdGg7Cj4+IC0gICAgICAgICAgICAgICAvKiBCeXBhc3Mg dmVyc2lvbiBjaGVjayBmb3IgZmlybXdhcmUgb3ZlcnJpZGUuICovCj4+IC0gICAgICAgICAgICAg ICBjc3ItPnJlcXVpcmVkX3ZlcnNpb24gPSAwOwo+PiArICAgICAgIC8qCj4+ICsgICAgICAgICog T2J0YWluIGEgcnVudGltZSBwbSByZWZlcmVuY2UsIHVudGlsIENTUiBpcyBsb2FkZWQsCj4+ICsg ICAgICAgICogdG8gYXZvaWQgZW50ZXJpbmcgcnVudGltZS1zdXNwZW5kLgo+Cj4gCSAgICogT24g ZXJyb3IsIHdlIHJldHVybiB3aXRoIHRoZSBycG0gd2FrZXJlZiBoZWxkIHRvIHByZXZlbnQKPiAJ ICAgKiBydW50aW1lIHN1c3BlbmQgYXMgcnVudGltZSBzdXNwZW5kICpyZXF1aXJlcyogYSB3b3Jr aW5nCj4gCSAgICogQ1NSIGZvciB3aGF0ZXZlciByZWFzb24uCj4+ICsgICAgICAgICovCj4+ICsg ICAgICAgaW50ZWxfZGlzcGxheV9wb3dlcl9nZXQoZGV2X3ByaXYsIFBPV0VSX0RPTUFJTl9JTklU KTsKPgo+IEEgcmVtaW5kZXIgdGhhdCB0aGUgbGVhayBpcyBieSBkZXNpZ24uIEJvbnVzIHBvaW50 cyBmb3IgaW50ZWdyYXRpbmcgd2l0aAo+IHRoZSB3YWtlcmVmIHRyYWNraW5nIHNvIHRoYXQgd2Ug ZGVtb25zdHJhdGUgd2UgYXJlbid0IGp1c3QgbGVha2luZyBmb3IKPiB0aGUgZnVuIG9mIGl0Lgo+ Cj4+ICsgICAgICAgaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gMTEpIHsKPj4gKyAgICAgICAg ICAgICAgIGNzci0+bWF4X2Z3X3NpemUgPSBJQ0xfQ1NSX01BWF9GV19TSVpFOwo+Cj4gT2suCj4K Pj4gICAgICAgICB9IGVsc2UgaWYgKElTX0NBTk5PTkxBS0UoZGV2X3ByaXYpKSB7Cj4+ICAgICAg ICAgICAgICAgICBjc3ItPmZ3X3BhdGggPSBJOTE1X0NTUl9DTkw7Cj4+ICAgICAgICAgICAgICAg ICBjc3ItPnJlcXVpcmVkX3ZlcnNpb24gPSBDTkxfQ1NSX1ZFUlNJT05fUkVRVUlSRUQ7Cj4+ICsg ICAgICAgICAgICAgICBjc3ItPm1heF9md19zaXplID0gR0xLX0NTUl9NQVhfRldfU0laRTsKPiBP ay4KPgo+PiAgICAgICAgIH0gZWxzZSBpZiAoSVNfR0VNSU5JTEFLRShkZXZfcHJpdikpIHsKPj4g ICAgICAgICAgICAgICAgIGNzci0+ZndfcGF0aCA9IEk5MTVfQ1NSX0dMSzsKPj4gICAgICAgICAg ICAgICAgIGNzci0+cmVxdWlyZWRfdmVyc2lvbiA9IEdMS19DU1JfVkVSU0lPTl9SRVFVSVJFRDsK Pj4gKyAgICAgICAgICAgICAgIGNzci0+bWF4X2Z3X3NpemUgPSBHTEtfQ1NSX01BWF9GV19TSVpF Owo+IE9rLgo+Cj4+ICAgICAgICAgfSBlbHNlIGlmIChJU19LQUJZTEFLRShkZXZfcHJpdikgfHwg SVNfQ09GRkVFTEFLRShkZXZfcHJpdikpIHsKPj4gICAgICAgICAgICAgICAgIGNzci0+ZndfcGF0 aCA9IEk5MTVfQ1NSX0tCTDsKPj4gICAgICAgICAgICAgICAgIGNzci0+cmVxdWlyZWRfdmVyc2lv biA9IEtCTF9DU1JfVkVSU0lPTl9SRVFVSVJFRDsKPj4gKyAgICAgICAgICAgICAgIGNzci0+bWF4 X2Z3X3NpemUgPSBCWFRfQ1NSX01BWF9GV19TSVpFOwo+IE9rLgo+Cj4+ICAgICAgICAgfSBlbHNl IGlmIChJU19TS1lMQUtFKGRldl9wcml2KSkgewo+PiAgICAgICAgICAgICAgICAgY3NyLT5md19w YXRoID0gSTkxNV9DU1JfU0tMOwo+PiAgICAgICAgICAgICAgICAgY3NyLT5yZXF1aXJlZF92ZXJz aW9uID0gU0tMX0NTUl9WRVJTSU9OX1JFUVVJUkVEOwo+PiArICAgICAgICAgICAgICAgY3NyLT5t YXhfZndfc2l6ZSA9IEJYVF9DU1JfTUFYX0ZXX1NJWkU7Cj4gT2ssIGJ1dCBpbnRlcmVzdGluZyBu YW1pbmcgc2NoZW1lLgoKSSBrbm93Li4uIGJ1dCBkZWNpZGVkIHRvIG5vdCBvcGVuIHRoYXQgY2Fu IG9mIHdvcm1zLgoKPgo+PiAgICAgICAgIH0gZWxzZSBpZiAoSVNfQlJPWFRPTihkZXZfcHJpdikp IHsKPj4gICAgICAgICAgICAgICAgIGNzci0+ZndfcGF0aCA9IEk5MTVfQ1NSX0JYVDsKPj4gICAg ICAgICAgICAgICAgIGNzci0+cmVxdWlyZWRfdmVyc2lvbiA9IEJYVF9DU1JfVkVSU0lPTl9SRVFV SVJFRDsKPj4gKyAgICAgICAgICAgICAgIGNzci0+bWF4X2Z3X3NpemUgPSBCWFRfQ1NSX01BWF9G V19TSVpFOwo+Cj4gT2suCj4KPj4gKyAgICAgICB9IGVsc2Ugewo+PiArICAgICAgICAgICAgICAg TUlTU0lOR19DQVNFKElOVEVMX1JFVklEKGRldl9wcml2KSk7Cj4+ICsgICAgICAgICAgICAgICBy ZXR1cm47Cj4KPiBIbW0uIEZlZWxzIGxpa2UgdGhpcyBzaG91bGQgYmUgcmV0cm9maXR0ZWQgdG8g cGF0Y2ggMSwgYnV0IHdoYXRldmVyLgoKVGhhdCBkb2Vzbid0IHNpdCB3ZWxsIHdpdGggZ2VuIDEx KyB1bnRpbCB3ZSBtb3ZlIHRoZSBtYXggc2l6ZSBoZXJlIHRvby4KCj4+ICAgICAgICAgfQo+PiAg Cj4+IC0gICAgICAgLyoKPj4gLSAgICAgICAgKiBPYnRhaW4gYSBydW50aW1lIHBtIHJlZmVyZW5j ZSwgdW50aWwgQ1NSIGlzIGxvYWRlZCwKPj4gLSAgICAgICAgKiB0byBhdm9pZCBlbnRlcmluZyBy dW50aW1lLXN1c3BlbmQuCj4+IC0gICAgICAgICovCj4+IC0gICAgICAgaW50ZWxfZGlzcGxheV9w b3dlcl9nZXQoZGV2X3ByaXYsIFBPV0VSX0RPTUFJTl9JTklUKTsKPj4gKyAgICAgICBpZiAoaTkx NV9tb2RwYXJhbXMuZG1jX2Zpcm13YXJlX3BhdGgpIHsKPj4gKyAgICAgICAgICAgICAgIGNzci0+ ZndfcGF0aCA9IGk5MTVfbW9kcGFyYW1zLmRtY19maXJtd2FyZV9wYXRoOwo+PiArICAgICAgICAg ICAgICAgLyogQnlwYXNzIHZlcnNpb24gY2hlY2sgZm9yIGZpcm13YXJlIG92ZXJyaWRlLiAqLwo+ PiArICAgICAgICAgICAgICAgY3NyLT5yZXF1aXJlZF92ZXJzaW9uID0gMDsKPj4gKyAgICAgICB9 Cj4KPiBPay4KPgo+IFBsZWFzZSBhZGQgdGhlIGNvbW1lbnQgZGVzY3JpYmluZyB0aGUgaW50ZW50 aW9uYWwgbGVhaywKPiBSZXZpZXdlZC1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxz b24uY28udWs+CgpXaWxsIGZpeCwgdGhhbmtzIGZvciB0aGUgcmV2aWV3LgoKQlIsCkphbmkuCgo+ IC1DaHJpcwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50 ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==